* [PATCH] xfs: fix warnings about unused stack variables
@ 2017-05-12 0:53 Darrick J. Wong
2017-05-15 9:03 ` Carlos Maiolino
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2017-05-12 0:53 UTC (permalink / raw)
To: xfs; +Cc: Christoph Hellwig
Reduce stack usage and get rid of compiler warnings by eliminating
unused variables. The variables were eliminated during one of
Christoph's cleanups for 4.12.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/libxfs/xfs_bmap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 8adb91b..a7048eaf 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -1280,7 +1280,6 @@ xfs_bmap_read_extents(
xfs_bmbt_rec_t *frp;
xfs_fsblock_t nextbno;
xfs_extnum_t num_recs;
- xfs_extnum_t start;
num_recs = xfs_btree_get_numrecs(block);
if (unlikely(i + num_recs > room)) {
@@ -1303,7 +1302,6 @@ xfs_bmap_read_extents(
* Copy records into the extent records.
*/
frp = XFS_BMBT_REC_ADDR(mp, block, 1);
- start = i;
for (j = 0; j < num_recs; j++, i++, frp++) {
xfs_bmbt_rec_host_t *trp = xfs_iext_get_ext(ifp, i);
trp->l0 = be64_to_cpu(frp->l0);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix warnings about unused stack variables
2017-05-12 0:53 [PATCH] xfs: fix warnings about unused stack variables Darrick J. Wong
@ 2017-05-15 9:03 ` Carlos Maiolino
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Maiolino @ 2017-05-15 9:03 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs, Christoph Hellwig
On Thu, May 11, 2017 at 05:53:52PM -0700, Darrick J. Wong wrote:
> Reduce stack usage and get rid of compiler warnings by eliminating
> unused variables. The variables were eliminated during one of
> Christoph's cleanups for 4.12.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_bmap.c | 2 --
> 1 file changed, 2 deletions(-)
Looks fine
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index 8adb91b..a7048eaf 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -1280,7 +1280,6 @@ xfs_bmap_read_extents(
> xfs_bmbt_rec_t *frp;
> xfs_fsblock_t nextbno;
> xfs_extnum_t num_recs;
> - xfs_extnum_t start;
>
> num_recs = xfs_btree_get_numrecs(block);
> if (unlikely(i + num_recs > room)) {
> @@ -1303,7 +1302,6 @@ xfs_bmap_read_extents(
> * Copy records into the extent records.
> */
> frp = XFS_BMBT_REC_ADDR(mp, block, 1);
> - start = i;
> for (j = 0; j < num_recs; j++, i++, frp++) {
> xfs_bmbt_rec_host_t *trp = xfs_iext_get_ext(ifp, i);
> trp->l0 = be64_to_cpu(frp->l0);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Carlos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-15 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 0:53 [PATCH] xfs: fix warnings about unused stack variables Darrick J. Wong
2017-05-15 9:03 ` Carlos Maiolino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.