All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Mikhaylov <ivan@de.ibm.com>
To: Alistair Popple <alistair@popple.id.au>,
	Matt Porter <mporter@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joel Stanley <joel@ozlabs.au.ibm.com>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite
Date: Mon, 15 May 2017 16:07:54 +0300	[thread overview]
Message-ID: <20170515130754.59363-5-ivan@de.ibm.com> (raw)

Prevent a kernel panic caused by unintentionally clearing TCR
watchdog bits.  At this point in the kernel boot, the watchdog has
already been enabled by u-boot.  The original code's attempt to
write to the TCR register results in an inadvertent clearing of the
watchdog configuration bits, causing the 476 to reset.
Panic happens in case of error as silently reboot without any outputs
on serial.

Signed-off-by: Ivan Mikhaylov <ivan@de.ibm.com>
---
 arch/powerpc/kernel/time.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index 2b33cfa..f75e512 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -738,12 +738,28 @@ static int __init get_freq(char *name, int cells, unsigned long *val)
 
 static void start_cpu_decrementer(void)
 {
+	unsigned int tcr;
 #if defined(CONFIG_BOOKE) || defined(CONFIG_40x)
 	/* Clear any pending timer interrupts */
 	mtspr(SPRN_TSR, TSR_ENW | TSR_WIS | TSR_DIS | TSR_FIS);
 
+#ifdef CONFIG_FSP2
+	/*
+	 * Prevent a kernel panic caused by unintentionally clearing TCR
+	 * watchdog bits.  At this point in the kernel boot, the watchdog has
+	 * already been enabled by u-boot.  The original code's attempt to
+	 * write to the TCR register results in an inadvertent clearing of the
+	 * watchdog configuration bits, causing the 440 to reset.
+	 */
+	tcr = mfspr(SPRN_TCR);
+	tcr &= TCR_WP_MASK; /* clear all bits except for TCR[WP] */
+	tcr |= TCR_DIE; /* enable decrementer */
+	mtspr(SPRN_TCR, tcr);
+#else
 	/* Enable decrementer interrupt */
 	mtspr(SPRN_TCR, TCR_DIE);
+#endif
+
 #endif /* defined(CONFIG_BOOKE) || defined(CONFIG_40x) */
 }
 
-- 
1.7.1

             reply	other threads:[~2017-05-15 13:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-15 13:07 Ivan Mikhaylov [this message]
2017-05-19 10:24 ` [PATCH 4/4] arch/powerpc/44x/fsp2: wdt tcr update instead of whole rewrite Michael Ellerman
2017-05-19 10:24   ` Michael Ellerman
2017-05-19 15:47   ` Ivan Mikhaylov
2017-05-19 15:47     ` Ivan Mikhaylov
2017-05-23  4:09     ` Michael Ellerman
2017-05-26 10:37       ` Michael Ellerman
2017-05-30  9:11     ` [4/4] " Michael Ellerman
2017-05-19 10:30 ` [PATCH 4/4] " Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170515130754.59363-5-ivan@de.ibm.com \
    --to=ivan@de.ibm.com \
    --cc=alistair@popple.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=joel@ozlabs.au.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=mporter@kernel.crashing.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.