* [PATCH] ib_core: Enable and expose force_mr module parameter @ 2017-05-15 14:52 Chuck Lever [not found] ` <20170515145203.10708.16921.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-05-15 14:52 UTC (permalink / raw) To: linux-rdma-u79uwXL29TY76Z2rM5mHXA The fourth parameter of the module_param_named macro is a set of file permissions. Passing 0 there means that module parameter is not created and that adding "options ib_core force_mr=1" to a modprobe.conf file has no effect. The default setting of rdma_rw_force_mr continues to be 0, or false. Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> --- drivers/infiniband/core/rw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c index dbfd854..1cc8f07 100644 --- a/drivers/infiniband/core/rw.c +++ b/drivers/infiniband/core/rw.c @@ -23,7 +23,7 @@ enum { }; static bool rdma_rw_force_mr; -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); /* -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 28+ messages in thread
[parent not found: <20170515145203.10708.16921.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170515145203.10708.16921.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> @ 2017-05-15 14:57 ` Leon Romanovsky [not found] ` <20170515145757.GI3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-05-15 14:57 UTC (permalink / raw) To: Chuck Lever; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1351 bytes --] On Mon, May 15, 2017 at 10:52:44AM -0400, Chuck Lever wrote: > The fourth parameter of the module_param_named macro is a set of > file permissions. Passing 0 there means that module parameter is > not created and that adding "options ib_core force_mr=1" to a > modprobe.conf file has no effect. > > The default setting of rdma_rw_force_mr continues to be 0, or false. > > Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") > Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Chuck, Do we really need this parameter? > --- > drivers/infiniband/core/rw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > index dbfd854..1cc8f07 100644 > --- a/drivers/infiniband/core/rw.c > +++ b/drivers/infiniband/core/rw.c > @@ -23,7 +23,7 @@ enum { > }; > > static bool rdma_rw_force_mr; > -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); > +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); > MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); > > /* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170515145757.GI3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170515145757.GI3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-05-15 15:09 ` Chuck Lever [not found] ` <02AFF424-A387-47F7-BD24-61C7734B9008-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-05-15 15:09 UTC (permalink / raw) To: Leon Romanovsky; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA > On May 15, 2017, at 10:57 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > On Mon, May 15, 2017 at 10:52:44AM -0400, Chuck Lever wrote: >> The fourth parameter of the module_param_named macro is a set of >> file permissions. Passing 0 there means that module parameter is >> not created and that adding "options ib_core force_mr=1" to a >> modprobe.conf file has no effect. >> >> The default setting of rdma_rw_force_mr continues to be 0, or false. >> >> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") >> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > > Chuck, > > Do we really need this parameter? Hi Leon- Christoph and Sagi introduced this with the new rdma_rw API. The default behavior is to avoid the use of FRWR, even for devices that can support FRWR but also work without. FRWR is used only for iWARP devices, which require it; but FRWR can have a (slight) negative performance impact, which is why it is not the default. The purpose of this module parameter is to enable the use of FRWR for devices that can go either way, as a way to test the FRWR capability when using those devices. I'm not sure we _need_ to have the module parameter. But I've certainly used it while developing the NFSD conversion to use the rdma_rw API, since I have no iWARP devices here. >> --- >> drivers/infiniband/core/rw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c >> index dbfd854..1cc8f07 100644 >> --- a/drivers/infiniband/core/rw.c >> +++ b/drivers/infiniband/core/rw.c >> @@ -23,7 +23,7 @@ enum { >> }; >> >> static bool rdma_rw_force_mr; >> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); >> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); >> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); >> >> /* >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <02AFF424-A387-47F7-BD24-61C7734B9008-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <02AFF424-A387-47F7-BD24-61C7734B9008-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> @ 2017-05-15 17:00 ` Leon Romanovsky [not found] ` <20170515170021.GJ3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-05-15 17:00 UTC (permalink / raw) To: Chuck Lever; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 2854 bytes --] On Mon, May 15, 2017 at 11:09:06AM -0400, Chuck Lever wrote: > > > On May 15, 2017, at 10:57 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > > > On Mon, May 15, 2017 at 10:52:44AM -0400, Chuck Lever wrote: > >> The fourth parameter of the module_param_named macro is a set of > >> file permissions. Passing 0 there means that module parameter is > >> not created and that adding "options ib_core force_mr=1" to a > >> modprobe.conf file has no effect. > >> > >> The default setting of rdma_rw_force_mr continues to be 0, or false. > >> > >> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") > >> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > > > > Chuck, > > > > Do we really need this parameter? > > Hi Leon- > > Christoph and Sagi introduced this with the new rdma_rw API. > The default behavior is to avoid the use of FRWR, even for > devices that can support FRWR but also work without. FRWR is > used only for iWARP devices, which require it; but FRWR can > have a (slight) negative performance impact, which is why it > is not the default. > > The purpose of this module parameter is to enable the use of > FRWR for devices that can go either way, as a way to test the > FRWR capability when using those devices. > > I'm not sure we _need_ to have the module parameter. But I've > certainly used it while developing the NFSD conversion to use > the rdma_rw API, since I have no iWARP devices here. I asked that question because commit a060b5629ab0 was added a year ago and since then no one noticed that it is not usable, including authors. I think that we can safely remove it and for development, we can set rdma_rw_force_mr internally in the code. Thanks > > > >> --- > >> drivers/infiniband/core/rw.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > >> index dbfd854..1cc8f07 100644 > >> --- a/drivers/infiniband/core/rw.c > >> +++ b/drivers/infiniband/core/rw.c > >> @@ -23,7 +23,7 @@ enum { > >> }; > >> > >> static bool rdma_rw_force_mr; > >> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); > >> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); > >> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); > >> > >> /* > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Chuck Lever > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170515170021.GJ3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170515170021.GJ3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-05-15 17:22 ` Chuck Lever [not found] ` <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-05-15 17:22 UTC (permalink / raw) To: Leon Romanovsky, Christoph Hellwig, Sagi Grimberg; +Cc: List Linux RDMA Mailing > On May 15, 2017, at 1:00 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > On Mon, May 15, 2017 at 11:09:06AM -0400, Chuck Lever wrote: >> >>> On May 15, 2017, at 10:57 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >>> >>> On Mon, May 15, 2017 at 10:52:44AM -0400, Chuck Lever wrote: >>>> The fourth parameter of the module_param_named macro is a set of >>>> file permissions. Passing 0 there means that module parameter is >>>> not created and that adding "options ib_core force_mr=1" to a >>>> modprobe.conf file has no effect. >>>> >>>> The default setting of rdma_rw_force_mr continues to be 0, or false. >>>> >>>> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") >>>> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> >>> >>> Chuck, >>> >>> Do we really need this parameter? >> >> Hi Leon- >> >> Christoph and Sagi introduced this with the new rdma_rw API. >> The default behavior is to avoid the use of FRWR, even for >> devices that can support FRWR but also work without. FRWR is >> used only for iWARP devices, which require it; but FRWR can >> have a (slight) negative performance impact, which is why it >> is not the default. >> >> The purpose of this module parameter is to enable the use of >> FRWR for devices that can go either way, as a way to test the >> FRWR capability when using those devices. >> >> I'm not sure we _need_ to have the module parameter. But I've >> certainly used it while developing the NFSD conversion to use >> the rdma_rw API, since I have no iWARP devices here. > > I asked that question because commit a060b5629ab0 was added a year ago > and since then no one noticed that it is not usable, including authors. I noticed a while ago, but haven't had time to track it down until now. > I think that we can safely remove it and for development, we can set > rdma_rw_force_mr internally in the code. It is safe to remove. Since it was never exposed to user space due to this bug, removal would not result in a kernel API breakage. I find the feature useful. But it is correct to say that such development knobs are often left to kernel compile-time, as it is not especially useful to end users. In this case, the module parameter is global: one has to take some care when there are multiple HCAs in a system and they each have different MEMMGT capabilities. Instead of removing the setting altogether, one might replace it with a driver- mediated per-device-port attribute. I will let Sagi and Christoph have the last word. > Thanks > >> >> >>>> --- >>>> drivers/infiniband/core/rw.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c >>>> index dbfd854..1cc8f07 100644 >>>> --- a/drivers/infiniband/core/rw.c >>>> +++ b/drivers/infiniband/core/rw.c >>>> @@ -23,7 +23,7 @@ enum { >>>> }; >>>> >>>> static bool rdma_rw_force_mr; >>>> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); >>>> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); >>>> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); >>>> >>>> /* >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> Chuck Lever >> >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> @ 2017-05-15 17:46 ` Jason Gunthorpe [not found] ` <20170515174646.GC6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2017-05-16 5:42 ` Christoph Hellwig 1 sibling, 1 reply; 28+ messages in thread From: Jason Gunthorpe @ 2017-05-15 17:46 UTC (permalink / raw) To: Chuck Lever Cc: Leon Romanovsky, Christoph Hellwig, Sagi Grimberg, List Linux RDMA Mailing On Mon, May 15, 2017 at 01:22:59PM -0400, Chuck Lever wrote: > I find the feature useful. But it is correct to say that such > development knobs are often left to kernel compile-time, as > it is not especially useful to end users. Put it in debugfs? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170515174646.GC6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170515174646.GC6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> @ 2017-05-15 18:55 ` Leon Romanovsky 0 siblings, 0 replies; 28+ messages in thread From: Leon Romanovsky @ 2017-05-15 18:55 UTC (permalink / raw) To: Jason Gunthorpe Cc: Chuck Lever, Christoph Hellwig, Sagi Grimberg, List Linux RDMA Mailing [-- Attachment #1: Type: text/plain, Size: 458 bytes --] On Mon, May 15, 2017 at 11:46:46AM -0600, Jason Gunthorpe wrote: > On Mon, May 15, 2017 at 01:22:59PM -0400, Chuck Lever wrote: > > > I find the feature useful. But it is correct to say that such > > development knobs are often left to kernel compile-time, as > > it is not especially useful to end users. > > Put it in debugfs? Why bother? In good year, we will have one new user of this RW API who will need that knob during development phase. > > Jason [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-05-15 17:46 ` Jason Gunthorpe @ 2017-05-16 5:42 ` Christoph Hellwig [not found] ` <20170516054256.GA4013-jcswGhMUV9g@public.gmane.org> 1 sibling, 1 reply; 28+ messages in thread From: Christoph Hellwig @ 2017-05-16 5:42 UTC (permalink / raw) To: Chuck Lever Cc: Leon Romanovsky, Christoph Hellwig, Sagi Grimberg, List Linux RDMA Mailing On Mon, May 15, 2017 at 01:22:59PM -0400, Chuck Lever wrote: > In this case, the module parameter is global: one has to take > some care when there are multiple HCAs in a system and they > each have different MEMMGT capabilities. Instead of removing > the setting altogether, one might replace it with a driver- > mediated per-device-port attribute. > > I will let Sagi and Christoph have the last word. I think I only added it on requests from someone (you?), and when writing the code debugged it by manually forcing it to on. Thay being said a module parameter is entirely trivial and thus I'm fine with it. Think like debugfs or per-device setting for such a trivial debug tool have just way to much boilerplate code. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170516054256.GA4013-jcswGhMUV9g@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170516054256.GA4013-jcswGhMUV9g@public.gmane.org> @ 2017-05-16 7:22 ` Sagi Grimberg [not found] ` <d46b0a41-92c2-2ce2-5cf2-ac5c6c3811cd-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Sagi Grimberg @ 2017-05-16 7:22 UTC (permalink / raw) To: Christoph Hellwig, Chuck Lever; +Cc: Leon Romanovsky, List Linux RDMA Mailing > I think I only added it on requests from someone (you?), and when > writing the code debugged it by manually forcing it to on. Thay > being said a module parameter is entirely trivial and thus I'm fine > with it. Think like debugfs or per-device setting for such a trivial > debug tool have just way to much boilerplate code. I tend to agree. It's a very simple knob, can't imagine why we'd want it to be per-device. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <d46b0a41-92c2-2ce2-5cf2-ac5c6c3811cd-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <d46b0a41-92c2-2ce2-5cf2-ac5c6c3811cd-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> @ 2017-05-16 14:57 ` Chuck Lever 0 siblings, 0 replies; 28+ messages in thread From: Chuck Lever @ 2017-05-16 14:57 UTC (permalink / raw) To: Sagi Grimberg; +Cc: Christoph Hellwig, Leon Romanovsky, List Linux RDMA Mailing > On May 16, 2017, at 3:22 AM, Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> wrote: > > >> I think I only added it on requests from someone (you?), and when >> writing the code debugged it by manually forcing it to on. Thay >> being said a module parameter is entirely trivial and thus I'm fine >> with it. Think like debugfs or per-device setting for such a trivial >> debug tool have just way to much boilerplate code. Agree that debugfs would work, but might be overkill. > I tend to agree. It's a very simple knob, can't imagine why we'd want it > to be per-device. Per-device port ... The internal helper includes @port_num as a parameter: static inline bool rdma_rw_can_use_mr(struct ib_device *dev, u8 port_num) IIRC the idea was to eventually have a white list of devices (besides iWARP devices, which require it) that prefer FRWR. And some modes of operation (VF, or split RoCE-IB) might want to force FRWR or not. See core/rw.c: 48 * XXX: In the future we can hopefully fine tune this based on HCA driver 49 * input. The original impetus was to have a simple method of forcing the use of FRWR so we could study the performance differences. When I started using rdma_rw for NFSD, however, it was clear that there were different constraints on ULP behavior depending on whether FRWR was used or not. However, I'm not stuck on keeping it. It's certainly not hard to build a patched kernel that forces the use of FRWR, when I need to test specific code paths. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH] ib_core: Enable and expose force_mr module parameter @ 2017-06-19 15:26 Chuck Lever [not found] ` <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-06-19 15:26 UTC (permalink / raw) To: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA The fourth parameter of the module_param_named macro is a set of file permissions. Passing 0 there means that module parameter is not created and that adding "options ib_core force_mr=1" to a modprobe.conf file has no effect. The default setting of rdma_rw_force_mr continues to be 0, or false. Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> --- Hi Doug- This doesn't seem appropriate to go through Bruce's tree for 4.13. Last discussion didn't seem to conclude with full consensus. Probably people don't care enough one way or another. But I'd like to see this get fixed if there aren't strong objections. Would you take it for 4.13? drivers/infiniband/core/rw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c index dbfd854..1cc8f07 100644 --- a/drivers/infiniband/core/rw.c +++ b/drivers/infiniband/core/rw.c @@ -23,7 +23,7 @@ enum { }; static bool rdma_rw_force_mr; -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); /* -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 28+ messages in thread
[parent not found: <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> @ 2017-06-19 15:30 ` Christoph Hellwig 2017-06-20 7:24 ` Sagi Grimberg 2017-06-20 7:32 ` Leon Romanovsky 2 siblings, 0 replies; 28+ messages in thread From: Christoph Hellwig @ 2017-06-19 15:30 UTC (permalink / raw) To: Chuck Lever Cc: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> (it's a nice and cheap debug tool!) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2017-06-19 15:30 ` Christoph Hellwig @ 2017-06-20 7:24 ` Sagi Grimberg 2017-06-20 7:32 ` Leon Romanovsky 2 siblings, 0 replies; 28+ messages in thread From: Sagi Grimberg @ 2017-06-20 7:24 UTC (permalink / raw) To: Chuck Lever, doug.ledford-H+wXaHxf7aLQT0dZR+AlfA Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2017-06-19 15:30 ` Christoph Hellwig 2017-06-20 7:24 ` Sagi Grimberg @ 2017-06-20 7:32 ` Leon Romanovsky [not found] ` <20170620073236.GO17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-06-20 7:32 UTC (permalink / raw) To: Chuck Lever Cc: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1798 bytes --] On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: > The fourth parameter of the module_param_named macro is a set of > file permissions. Passing 0 there means that module parameter is > not created and that adding "options ib_core force_mr=1" to a > modprobe.conf file has no effect. > > The default setting of rdma_rw_force_mr continues to be 0, or false. > > Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") > Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > --- > Hi Doug- > > This doesn't seem appropriate to go through Bruce's tree for 4.13. > > Last discussion didn't seem to conclude with full consensus. > Probably people don't care enough one way or another. But I'd like > to see this get fixed if there aren't strong objections. Would you > take it for 4.13? I care and believe that it should be removed from exposure to users. The variable force_mr should be leaved in the code for the debug, but module_param should be removed. Thanks > > > drivers/infiniband/core/rw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > index dbfd854..1cc8f07 100644 > --- a/drivers/infiniband/core/rw.c > +++ b/drivers/infiniband/core/rw.c > @@ -23,7 +23,7 @@ enum { > }; > > static bool rdma_rw_force_mr; > -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); > +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); > MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); > > /* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170620073236.GO17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170620073236.GO17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-06-20 15:43 ` Chuck Lever [not found] ` <DE0C511C-A4CB-4D76-8BA7-6BFF81F590B3-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-06-20 15:43 UTC (permalink / raw) To: Leon Romanovsky Cc: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA Hi Leon- > On Jun 20, 2017, at 3:32 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: >> The fourth parameter of the module_param_named macro is a set of >> file permissions. Passing 0 there means that module parameter is >> not created and that adding "options ib_core force_mr=1" to a >> modprobe.conf file has no effect. >> >> The default setting of rdma_rw_force_mr continues to be 0, or false. >> >> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") >> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> >> --- >> Hi Doug- >> >> This doesn't seem appropriate to go through Bruce's tree for 4.13. >> >> Last discussion didn't seem to conclude with full consensus. >> Probably people don't care enough one way or another. But I'd like >> to see this get fixed if there aren't strong objections. Would you >> take it for 4.13? > > I care and believe that it should be removed from exposure to users. > The variable force_mr should be leaved in the code for the debug, > but module_param should be removed. I don't understand the technical grounds of your objection. Why is options mlx4_core internal_err_reset=0 acceptable, but options ib_core force_mr=1 not? > Thanks > > >> >> >> drivers/infiniband/core/rw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c >> index dbfd854..1cc8f07 100644 >> --- a/drivers/infiniband/core/rw.c >> +++ b/drivers/infiniband/core/rw.c >> @@ -23,7 +23,7 @@ enum { >> }; >> >> static bool rdma_rw_force_mr; >> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); >> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); >> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); >> >> /* >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <DE0C511C-A4CB-4D76-8BA7-6BFF81F590B3-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <DE0C511C-A4CB-4D76-8BA7-6BFF81F590B3-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> @ 2017-06-20 18:03 ` Leon Romanovsky [not found] ` <20170620180348.GV17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-06-20 18:03 UTC (permalink / raw) To: Chuck Lever Cc: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 2612 bytes --] On Tue, Jun 20, 2017 at 11:43:56AM -0400, Chuck Lever wrote: > Hi Leon- > > > > On Jun 20, 2017, at 3:32 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > > > On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: > >> The fourth parameter of the module_param_named macro is a set of > >> file permissions. Passing 0 there means that module parameter is > >> not created and that adding "options ib_core force_mr=1" to a > >> modprobe.conf file has no effect. > >> > >> The default setting of rdma_rw_force_mr continues to be 0, or false. > >> > >> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") > >> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > >> --- > >> Hi Doug- > >> > >> This doesn't seem appropriate to go through Bruce's tree for 4.13. > >> > >> Last discussion didn't seem to conclude with full consensus. > >> Probably people don't care enough one way or another. But I'd like > >> to see this get fixed if there aren't strong objections. Would you > >> take it for 4.13? > > > > I care and believe that it should be removed from exposure to users. > > The variable force_mr should be leaved in the code for the debug, > > but module_param should be removed. > > I don't understand the technical grounds of your objection. > Why is > > options mlx4_core internal_err_reset=0 > > acceptable, but > > options ib_core force_mr=1 > > not? That mlx4 variable was exposed before I started to follow after Mellanox's submissions. The force_mr parameter is for debug of new ULP and/or conversion of existing ULP to RW API. This is not very common situation and it is for the developers and not for the users. Thanks > > > > Thanks > > > > > >> > >> > >> drivers/infiniband/core/rw.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > >> index dbfd854..1cc8f07 100644 > >> --- a/drivers/infiniband/core/rw.c > >> +++ b/drivers/infiniband/core/rw.c > >> @@ -23,7 +23,7 @@ enum { > >> }; > >> > >> static bool rdma_rw_force_mr; > >> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); > >> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); > >> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); > >> > >> /* > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Chuck Lever > > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170620180348.GV17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170620180348.GV17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-06-20 18:23 ` Chuck Lever [not found] ` <C27E2410-44B7-451E-8069-DF1444048158-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-06-20 18:23 UTC (permalink / raw) To: Leon Romanovsky Cc: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA > On Jun 20, 2017, at 2:03 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > On Tue, Jun 20, 2017 at 11:43:56AM -0400, Chuck Lever wrote: >> Hi Leon- >> >> >>> On Jun 20, 2017, at 3:32 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >>> >>> On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: >>>> The fourth parameter of the module_param_named macro is a set of >>>> file permissions. Passing 0 there means that module parameter is >>>> not created and that adding "options ib_core force_mr=1" to a >>>> modprobe.conf file has no effect. >>>> >>>> The default setting of rdma_rw_force_mr continues to be 0, or false. >>>> >>>> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") >>>> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> >>>> --- >>>> Hi Doug- >>>> >>>> This doesn't seem appropriate to go through Bruce's tree for 4.13. >>>> >>>> Last discussion didn't seem to conclude with full consensus. >>>> Probably people don't care enough one way or another. But I'd like >>>> to see this get fixed if there aren't strong objections. Would you >>>> take it for 4.13? >>> >>> I care and believe that it should be removed from exposure to users. >>> The variable force_mr should be leaved in the code for the debug, >>> but module_param should be removed. >> >> I don't understand the technical grounds of your objection. >> Why is >> >> options mlx4_core internal_err_reset=0 >> >> acceptable, but >> >> options ib_core force_mr=1 >> >> not? > > That mlx4 variable was exposed before I started to follow after > Mellanox's submissions. > > The force_mr parameter is for debug of new ULP and/or conversion of > existing ULP to RW API. This is not very common situation and it is > for the developers and not for the users. No disagreement on that, but that's still not an argument not to expose it. What is the risk, as you see it? > Thanks > >> >> >>> Thanks >>> >>> >>>> >>>> >>>> drivers/infiniband/core/rw.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c >>>> index dbfd854..1cc8f07 100644 >>>> --- a/drivers/infiniband/core/rw.c >>>> +++ b/drivers/infiniband/core/rw.c >>>> @@ -23,7 +23,7 @@ enum { >>>> }; >>>> >>>> static bool rdma_rw_force_mr; >>>> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); >>>> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); >>>> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); >>>> >>>> /* >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- >> Chuck Lever -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <C27E2410-44B7-451E-8069-DF1444048158-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <C27E2410-44B7-451E-8069-DF1444048158-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> @ 2017-06-20 18:40 ` Leon Romanovsky [not found] ` <20170620184046.GW17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-06-20 18:40 UTC (permalink / raw) To: Chuck Lever Cc: doug.ledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 3356 bytes --] On Tue, Jun 20, 2017 at 02:23:21PM -0400, Chuck Lever wrote: > > > On Jun 20, 2017, at 2:03 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > > > On Tue, Jun 20, 2017 at 11:43:56AM -0400, Chuck Lever wrote: > >> Hi Leon- > >> > >> > >>> On Jun 20, 2017, at 3:32 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > >>> > >>> On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: > >>>> The fourth parameter of the module_param_named macro is a set of > >>>> file permissions. Passing 0 there means that module parameter is > >>>> not created and that adding "options ib_core force_mr=1" to a > >>>> modprobe.conf file has no effect. > >>>> > >>>> The default setting of rdma_rw_force_mr continues to be 0, or false. > >>>> > >>>> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") > >>>> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > >>>> --- > >>>> Hi Doug- > >>>> > >>>> This doesn't seem appropriate to go through Bruce's tree for 4.13. > >>>> > >>>> Last discussion didn't seem to conclude with full consensus. > >>>> Probably people don't care enough one way or another. But I'd like > >>>> to see this get fixed if there aren't strong objections. Would you > >>>> take it for 4.13? > >>> > >>> I care and believe that it should be removed from exposure to users. > >>> The variable force_mr should be leaved in the code for the debug, > >>> but module_param should be removed. > >> > >> I don't understand the technical grounds of your objection. > >> Why is > >> > >> options mlx4_core internal_err_reset=0 > >> > >> acceptable, but > >> > >> options ib_core force_mr=1 > >> > >> not? > > > > That mlx4 variable was exposed before I started to follow after > > Mellanox's submissions. > > > > The force_mr parameter is for debug of new ULP and/or conversion of > > existing ULP to RW API. This is not very common situation and it is > > for the developers and not for the users. > > No disagreement on that, but that's still not an argument > not to expose it. What is the risk, as you see it? It will be "marked" as UAPI and we won't be able to change it, which IMHO bad for the debug. It also invites users to set it and in perfect world, we should test our HCAs with this flag on and off, because curious user can set it. Thanks > > > > Thanks > > > >> > >> > >>> Thanks > >>> > >>> > >>>> > >>>> > >>>> drivers/infiniband/core/rw.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > >>>> index dbfd854..1cc8f07 100644 > >>>> --- a/drivers/infiniband/core/rw.c > >>>> +++ b/drivers/infiniband/core/rw.c > >>>> @@ -23,7 +23,7 @@ enum { > >>>> }; > >>>> > >>>> static bool rdma_rw_force_mr; > >>>> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); > >>>> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); > >>>> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); > >>>> > >>>> /* > >>>> > >>>> -- > >>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > >>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > >> -- > >> Chuck Lever > > -- > Chuck Lever > > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170620184046.GW17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170620184046.GW17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-06-21 14:46 ` Chuck Lever [not found] ` <B34E95B2-A7D9-4725-B7C2-3DA4DACD29B7-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-06-21 14:46 UTC (permalink / raw) To: Leon Romanovsky; +Cc: linux-rdma [ Removing Doug since all mail to him seems to be bouncing ] > On Jun 20, 2017, at 2:40 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > On Tue, Jun 20, 2017 at 02:23:21PM -0400, Chuck Lever wrote: >> >>> On Jun 20, 2017, at 2:03 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >>> >>> On Tue, Jun 20, 2017 at 11:43:56AM -0400, Chuck Lever wrote: >>>> Hi Leon- >>>> >>>> >>>>> On Jun 20, 2017, at 3:32 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >>>>> >>>>> On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: >>>>>> The fourth parameter of the module_param_named macro is a set of >>>>>> file permissions. Passing 0 there means that module parameter is >>>>>> not created and that adding "options ib_core force_mr=1" to a >>>>>> modprobe.conf file has no effect. >>>>>> >>>>>> The default setting of rdma_rw_force_mr continues to be 0, or false. >>>>>> >>>>>> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") >>>>>> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> >>>>>> --- >>>>>> Hi Doug- >>>>>> >>>>>> This doesn't seem appropriate to go through Bruce's tree for 4.13. >>>>>> >>>>>> Last discussion didn't seem to conclude with full consensus. >>>>>> Probably people don't care enough one way or another. But I'd like >>>>>> to see this get fixed if there aren't strong objections. Would you >>>>>> take it for 4.13? >>>>> >>>>> I care and believe that it should be removed from exposure to users. >>>>> The variable force_mr should be leaved in the code for the debug, >>>>> but module_param should be removed. >>>> >>>> I don't understand the technical grounds of your objection. >>>> Why is >>>> >>>> options mlx4_core internal_err_reset=0 >>>> >>>> acceptable, but >>>> >>>> options ib_core force_mr=1 >>>> >>>> not? >>> >>> That mlx4 variable was exposed before I started to follow after >>> Mellanox's submissions. >>> >>> The force_mr parameter is for debug of new ULP and/or conversion of >>> existing ULP to RW API. This is not very common situation and it is >>> for the developers and not for the users. >> >> No disagreement on that, but that's still not an argument >> not to expose it. What is the risk, as you see it? > > It will be "marked" as UAPI and we won't be able to change it, > which IMHO bad for the debug. It also invites users to set it > and in perfect world, we should test our HCAs with this flag > on and off, because curious user can set it. We have loads of legacy debugging interfaces. And yes, ULP developers should be aware of it and test with both settings. I'm not convinced any of this is a problem for this particular setting. However, I guess the thing for you to do is propose a patch. > Thanks > >> >> >>> Thanks >>> >>>> >>>> >>>>> Thanks >>>>> >>>>> >>>>>> >>>>>> >>>>>> drivers/infiniband/core/rw.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c >>>>>> index dbfd854..1cc8f07 100644 >>>>>> --- a/drivers/infiniband/core/rw.c >>>>>> +++ b/drivers/infiniband/core/rw.c >>>>>> @@ -23,7 +23,7 @@ enum { >>>>>> }; >>>>>> >>>>>> static bool rdma_rw_force_mr; >>>>>> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); >>>>>> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); >>>>>> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); >>>>>> >>>>>> /* >>>>>> >>>>>> -- >>>>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >>>>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>>> -- >>>> Chuck Lever >> >> -- >> Chuck Lever >> >> >> -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <B34E95B2-A7D9-4725-B7C2-3DA4DACD29B7-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <B34E95B2-A7D9-4725-B7C2-3DA4DACD29B7-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> @ 2017-06-21 14:56 ` Leon Romanovsky 2017-06-27 9:24 ` Sagi Grimberg 1 sibling, 0 replies; 28+ messages in thread From: Leon Romanovsky @ 2017-06-21 14:56 UTC (permalink / raw) To: Chuck Lever; +Cc: linux-rdma [-- Attachment #1: Type: text/plain, Size: 4163 bytes --] On Wed, Jun 21, 2017 at 10:46:44AM -0400, Chuck Lever wrote: > [ Removing Doug since all mail to him seems to be bouncing ] > > > On Jun 20, 2017, at 2:40 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > > > On Tue, Jun 20, 2017 at 02:23:21PM -0400, Chuck Lever wrote: > >> > >>> On Jun 20, 2017, at 2:03 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > >>> > >>> On Tue, Jun 20, 2017 at 11:43:56AM -0400, Chuck Lever wrote: > >>>> Hi Leon- > >>>> > >>>> > >>>>> On Jun 20, 2017, at 3:32 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > >>>>> > >>>>> On Mon, Jun 19, 2017 at 11:26:40AM -0400, Chuck Lever wrote: > >>>>>> The fourth parameter of the module_param_named macro is a set of > >>>>>> file permissions. Passing 0 there means that module parameter is > >>>>>> not created and that adding "options ib_core force_mr=1" to a > >>>>>> modprobe.conf file has no effect. > >>>>>> > >>>>>> The default setting of rdma_rw_force_mr continues to be 0, or false. > >>>>>> > >>>>>> Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API") > >>>>>> Signed-off-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > >>>>>> --- > >>>>>> Hi Doug- > >>>>>> > >>>>>> This doesn't seem appropriate to go through Bruce's tree for 4.13. > >>>>>> > >>>>>> Last discussion didn't seem to conclude with full consensus. > >>>>>> Probably people don't care enough one way or another. But I'd like > >>>>>> to see this get fixed if there aren't strong objections. Would you > >>>>>> take it for 4.13? > >>>>> > >>>>> I care and believe that it should be removed from exposure to users. > >>>>> The variable force_mr should be leaved in the code for the debug, > >>>>> but module_param should be removed. > >>>> > >>>> I don't understand the technical grounds of your objection. > >>>> Why is > >>>> > >>>> options mlx4_core internal_err_reset=0 > >>>> > >>>> acceptable, but > >>>> > >>>> options ib_core force_mr=1 > >>>> > >>>> not? > >>> > >>> That mlx4 variable was exposed before I started to follow after > >>> Mellanox's submissions. > >>> > >>> The force_mr parameter is for debug of new ULP and/or conversion of > >>> existing ULP to RW API. This is not very common situation and it is > >>> for the developers and not for the users. > >> > >> No disagreement on that, but that's still not an argument > >> not to expose it. What is the risk, as you see it? > > > > It will be "marked" as UAPI and we won't be able to change it, > > which IMHO bad for the debug. It also invites users to set it > > and in perfect world, we should test our HCAs with this flag > > on and off, because curious user can set it. > > We have loads of legacy debugging interfaces. > > And yes, ULP developers should be aware of it and test with > both settings. > > I'm not convinced any of this is a problem for this particular > setting. However, I guess the thing for you to do is propose a > patch. Thanks, I'll do it with great pleasure. > > > > Thanks > > > >> > >> > >>> Thanks > >>> > >>>> > >>>> > >>>>> Thanks > >>>>> > >>>>> > >>>>>> > >>>>>> > >>>>>> drivers/infiniband/core/rw.c | 2 +- > >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c > >>>>>> index dbfd854..1cc8f07 100644 > >>>>>> --- a/drivers/infiniband/core/rw.c > >>>>>> +++ b/drivers/infiniband/core/rw.c > >>>>>> @@ -23,7 +23,7 @@ enum { > >>>>>> }; > >>>>>> > >>>>>> static bool rdma_rw_force_mr; > >>>>>> -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); > >>>>>> +module_param_named(force_mr, rdma_rw_force_mr, bool, 0644); > >>>>>> MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); > >>>>>> > >>>>>> /* > >>>>>> > >>>>>> -- > >>>>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > >>>>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html > >>>> > >>>> -- > >>>> Chuck Lever > >> > >> -- > >> Chuck Lever > >> > >> > >> > > -- > Chuck Lever > > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <B34E95B2-A7D9-4725-B7C2-3DA4DACD29B7-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-06-21 14:56 ` Leon Romanovsky @ 2017-06-27 9:24 ` Sagi Grimberg [not found] ` <16d52534-5564-8137-a8b3-6c66df6bb508-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 1 sibling, 1 reply; 28+ messages in thread From: Sagi Grimberg @ 2017-06-27 9:24 UTC (permalink / raw) To: Chuck Lever, Leon Romanovsky; +Cc: linux-rdma >> It will be "marked" as UAPI and we won't be able to change it, >> which IMHO bad for the debug. It also invites users to set it >> and in perfect world, we should test our HCAs with this flag >> on and off, because curious user can set it. > > We have loads of legacy debugging interfaces. > > And yes, ULP developers should be aware of it and test with > both settings. > > I'm not convinced any of this is a problem for this particular > setting. However, I guess the thing for you to do is propose a > patch. Are you guys seriously still on this? Its simply a trivial debug flag, whats all the fuss really about? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <16d52534-5564-8137-a8b3-6c66df6bb508-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <16d52534-5564-8137-a8b3-6c66df6bb508-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> @ 2017-06-28 9:56 ` Leon Romanovsky [not found] ` <20170628095640.GB1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-06-28 9:56 UTC (permalink / raw) To: Sagi Grimberg; +Cc: Chuck Lever, linux-rdma [-- Attachment #1: Type: text/plain, Size: 798 bytes --] On Tue, Jun 27, 2017 at 12:24:20PM +0300, Sagi Grimberg wrote: > > > > It will be "marked" as UAPI and we won't be able to change it, > > > which IMHO bad for the debug. It also invites users to set it > > > and in perfect world, we should test our HCAs with this flag > > > on and off, because curious user can set it. > > > > We have loads of legacy debugging interfaces. > > > > And yes, ULP developers should be aware of it and test with > > both settings. > > > > I'm not convinced any of this is a problem for this particular > > setting. However, I guess the thing for you to do is propose a > > patch. > > Are you guys seriously still on this? Its simply a trivial > debug flag, whats all the fuss really about? I hope that we are done. https://patchwork.kernel.org/patch/9808615/ Thanks [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170628095640.GB1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170628095640.GB1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-06-28 10:15 ` Sagi Grimberg [not found] ` <64eae30c-9490-b801-550d-d871473f0d29-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-06-28 14:49 ` Chuck Lever 1 sibling, 1 reply; 28+ messages in thread From: Sagi Grimberg @ 2017-06-28 10:15 UTC (permalink / raw) To: Leon Romanovsky; +Cc: Chuck Lever, linux-rdma > I hope that we are done. > https://patchwork.kernel.org/patch/9808615/ You have a bogus empty line change there. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <64eae30c-9490-b801-550d-d871473f0d29-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <64eae30c-9490-b801-550d-d871473f0d29-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> @ 2017-06-28 13:45 ` Leon Romanovsky [not found] ` <20170628134528.GE1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Leon Romanovsky @ 2017-06-28 13:45 UTC (permalink / raw) To: Sagi Grimberg; +Cc: Chuck Lever, linux-rdma [-- Attachment #1: Type: text/plain, Size: 257 bytes --] On Wed, Jun 28, 2017 at 01:15:39PM +0300, Sagi Grimberg wrote: > > I hope that we are done. > > https://patchwork.kernel.org/patch/9808615/ > > You have a bogus empty line change there. If I remember correctly, It was needed to silence checkpatch. Thanks [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20170628134528.GE1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170628134528.GE1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> @ 2017-06-28 14:48 ` Sagi Grimberg [not found] ` <275acec0-215e-8157-e6a0-4c0f48fe3d75-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 0 siblings, 1 reply; 28+ messages in thread From: Sagi Grimberg @ 2017-06-28 14:48 UTC (permalink / raw) To: Leon Romanovsky; +Cc: Chuck Lever, linux-rdma >>> I hope that we are done. >>> https://patchwork.kernel.org/patch/9808615/ >> >> You have a bogus empty line change there. > > If I remember correctly, It was needed to silence checkpatch. So it should not be a part of the patch. Also, I think that the statement is _really_ unnecessary: "* Setting it to "true" will allow to mimic with IB devices, * the slow memory registration of iWARP devices." And, its simply not true. Its designed to test the rw logic for sg patterns that would normally not be registered. The fact that iWARP registers memory for rdma reads is completely orthogonal. And this statement is not true either: "* This parameter is useful for new ULP bringup * and/or conversion to this R/W API." Its designed to test the code itself, not for ULP bringup or conversion, although it is useful for that. And, I can't say that I 100% agree with not making it configurable, but since you insist so much, at least give a proper description. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <275acec0-215e-8157-e6a0-4c0f48fe3d75-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <275acec0-215e-8157-e6a0-4c0f48fe3d75-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> @ 2017-06-28 15:40 ` Leon Romanovsky 0 siblings, 0 replies; 28+ messages in thread From: Leon Romanovsky @ 2017-06-28 15:40 UTC (permalink / raw) To: Sagi Grimberg; +Cc: Chuck Lever, linux-rdma [-- Attachment #1: Type: text/plain, Size: 1137 bytes --] On Wed, Jun 28, 2017 at 05:48:33PM +0300, Sagi Grimberg wrote: > > > > > I hope that we are done. > > > > https://patchwork.kernel.org/patch/9808615/ > > > > > > You have a bogus empty line change there. > > > > If I remember correctly, It was needed to silence checkpatch. > > So it should not be a part of the patch. > > Also, I think that the statement is _really_ unnecessary: > > "* Setting it to "true" will allow to mimic with IB devices, > * the slow memory registration of iWARP devices." > > And, its simply not true. Its designed to test the rw logic for > sg patterns that would normally not be registered. The fact > that iWARP registers memory for rdma reads is completely orthogonal. > > And this statement is not true either: > > "* This parameter is useful for new ULP bringup > * and/or conversion to this R/W API." > > Its designed to test the code itself, not for ULP > bringup or conversion, although it is useful for that. > > And, I can't say that I 100% agree with not making it > configurable, but since you insist so much, at least > give a proper description. No problem, I'll send updated version. Thanks [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <20170628095640.GB1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-28 10:15 ` Sagi Grimberg @ 2017-06-28 14:49 ` Chuck Lever [not found] ` <373E6A00-8505-468C-A974-DCDAC15A3B7B-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 1 sibling, 1 reply; 28+ messages in thread From: Chuck Lever @ 2017-06-28 14:49 UTC (permalink / raw) To: Leon Romanovsky; +Cc: Sagi Grimberg, linux-rdma > On Jun 28, 2017, at 5:56 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > On Tue, Jun 27, 2017 at 12:24:20PM +0300, Sagi Grimberg wrote: >> >>>> It will be "marked" as UAPI and we won't be able to change it, >>>> which IMHO bad for the debug. It also invites users to set it >>>> and in perfect world, we should test our HCAs with this flag >>>> on and off, because curious user can set it. >>> >>> We have loads of legacy debugging interfaces. >>> >>> And yes, ULP developers should be aware of it and test with >>> both settings. >>> >>> I'm not convinced any of this is a problem for this particular >>> setting. However, I guess the thing for you to do is propose a >>> patch. >> >> Are you guys seriously still on this? Its simply a trivial >> debug flag, whats all the fuss really about? > > I hope that we are done. > https://patchwork.kernel.org/patch/9808615/ Somehow this got by me. The patch description says "exposed to regular users." The force_mr option is not exposed to regular users. Module parameters are visible only to system administrators. Also, just looking at the patch, it's not obvious why "The force_mr module parameter wasn't exposed ... from the beginning". IMO an explanation of what has prevented exposure is needed. Commit a060b5629ab0 got the fourth parameter of module_param_named wrong. Maybe a Fixes: tag is needed too. But frankly there is no visible change from this patch. Before the patch, force_mr is not visible, and after the patch it is not visible. Why then is this change necessary? It would be helpful to cite a policy about why removal is preferred over fixing the incorrect parameter. Therefore IMO the patch description is not adequate. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <373E6A00-8505-468C-A974-DCDAC15A3B7B-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] ib_core: Enable and expose force_mr module parameter [not found] ` <373E6A00-8505-468C-A974-DCDAC15A3B7B-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> @ 2017-06-28 15:41 ` Leon Romanovsky 0 siblings, 0 replies; 28+ messages in thread From: Leon Romanovsky @ 2017-06-28 15:41 UTC (permalink / raw) To: Chuck Lever; +Cc: Sagi Grimberg, linux-rdma [-- Attachment #1: Type: text/plain, Size: 1924 bytes --] On Wed, Jun 28, 2017 at 10:49:00AM -0400, Chuck Lever wrote: > > > On Jun 28, 2017, at 5:56 AM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > > > On Tue, Jun 27, 2017 at 12:24:20PM +0300, Sagi Grimberg wrote: > >> > >>>> It will be "marked" as UAPI and we won't be able to change it, > >>>> which IMHO bad for the debug. It also invites users to set it > >>>> and in perfect world, we should test our HCAs with this flag > >>>> on and off, because curious user can set it. > >>> > >>> We have loads of legacy debugging interfaces. > >>> > >>> And yes, ULP developers should be aware of it and test with > >>> both settings. > >>> > >>> I'm not convinced any of this is a problem for this particular > >>> setting. However, I guess the thing for you to do is propose a > >>> patch. > >> > >> Are you guys seriously still on this? Its simply a trivial > >> debug flag, whats all the fuss really about? > > > > I hope that we are done. > > https://patchwork.kernel.org/patch/9808615/ > > Somehow this got by me. > > The patch description says "exposed to regular users." The > force_mr option is not exposed to regular users. Module > parameters are visible only to system administrators. > > Also, just looking at the patch, it's not obvious why "The > force_mr module parameter wasn't exposed ... from the > beginning". IMO an explanation of what has prevented > exposure is needed. Commit a060b5629ab0 got the fourth > parameter of module_param_named wrong. Maybe a Fixes: > tag is needed too. > > But frankly there is no visible change from this patch. > Before the patch, force_mr is not visible, and after the > patch it is not visible. Why then is this change necessary? > It would be helpful to cite a policy about why removal is > preferred over fixing the incorrect parameter. > > Therefore IMO the patch description is not adequate. I'll update it. Thanks > > > -- > Chuck Lever > > > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2017-06-28 15:41 UTC | newest] Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-15 14:52 [PATCH] ib_core: Enable and expose force_mr module parameter Chuck Lever [not found] ` <20170515145203.10708.16921.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2017-05-15 14:57 ` Leon Romanovsky [not found] ` <20170515145757.GI3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-05-15 15:09 ` Chuck Lever [not found] ` <02AFF424-A387-47F7-BD24-61C7734B9008-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-05-15 17:00 ` Leon Romanovsky [not found] ` <20170515170021.GJ3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-05-15 17:22 ` Chuck Lever [not found] ` <AE3152CC-B7C8-4C51-ADDE-C3822533BB94-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-05-15 17:46 ` Jason Gunthorpe [not found] ` <20170515174646.GC6229-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2017-05-15 18:55 ` Leon Romanovsky 2017-05-16 5:42 ` Christoph Hellwig [not found] ` <20170516054256.GA4013-jcswGhMUV9g@public.gmane.org> 2017-05-16 7:22 ` Sagi Grimberg [not found] ` <d46b0a41-92c2-2ce2-5cf2-ac5c6c3811cd-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-05-16 14:57 ` Chuck Lever 2017-06-19 15:26 Chuck Lever [not found] ` <20170619152351.2866.11046.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2017-06-19 15:30 ` Christoph Hellwig 2017-06-20 7:24 ` Sagi Grimberg 2017-06-20 7:32 ` Leon Romanovsky [not found] ` <20170620073236.GO17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-20 15:43 ` Chuck Lever [not found] ` <DE0C511C-A4CB-4D76-8BA7-6BFF81F590B3-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-06-20 18:03 ` Leon Romanovsky [not found] ` <20170620180348.GV17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-20 18:23 ` Chuck Lever [not found] ` <C27E2410-44B7-451E-8069-DF1444048158-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-06-20 18:40 ` Leon Romanovsky [not found] ` <20170620184046.GW17846-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-21 14:46 ` Chuck Lever [not found] ` <B34E95B2-A7D9-4725-B7C2-3DA4DACD29B7-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-06-21 14:56 ` Leon Romanovsky 2017-06-27 9:24 ` Sagi Grimberg [not found] ` <16d52534-5564-8137-a8b3-6c66df6bb508-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-06-28 9:56 ` Leon Romanovsky [not found] ` <20170628095640.GB1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-28 10:15 ` Sagi Grimberg [not found] ` <64eae30c-9490-b801-550d-d871473f0d29-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-06-28 13:45 ` Leon Romanovsky [not found] ` <20170628134528.GE1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-28 14:48 ` Sagi Grimberg [not found] ` <275acec0-215e-8157-e6a0-4c0f48fe3d75-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-06-28 15:40 ` Leon Romanovsky 2017-06-28 14:49 ` Chuck Lever [not found] ` <373E6A00-8505-468C-A974-DCDAC15A3B7B-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> 2017-06-28 15:41 ` Leon Romanovsky
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.