* [PATCH nft] netlink_delink_delinearize: don't store dependency unless relop checks is eq check
@ 2017-05-09 15:37 Florian Westphal
2017-05-15 17:05 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2017-05-09 15:37 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal
'ip protocol ne 6' is not a dependency for nexthdr protocol, and must
not be stored as such.
Fixes: 0b858391781ba308 ("src: annotate follow up dependency just after killing another")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/netlink_delinearize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index a65a97da89fb..f0288cd49914 100644
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -1332,7 +1332,7 @@ static void payload_match_expand(struct rule_pp_ctx *ctx,
payload_dependency_store(&ctx->pdctx, nstmt, base - stacked);
} else {
payload_dependency_kill(&ctx->pdctx, nexpr->left);
- if (left->flags & EXPR_F_PROTOCOL)
+ if (expr->op == OP_EQ && left->flags & EXPR_F_PROTOCOL)
payload_dependency_store(&ctx->pdctx, nstmt, base - stacked);
}
}
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nft] netlink_delink_delinearize: don't store dependency unless relop checks is eq check
2017-05-09 15:37 [PATCH nft] netlink_delink_delinearize: don't store dependency unless relop checks is eq check Florian Westphal
@ 2017-05-15 17:05 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2017-05-15 17:05 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
On Tue, May 09, 2017 at 05:37:11PM +0200, Florian Westphal wrote:
> 'ip protocol ne 6' is not a dependency for nexthdr protocol, and must
> not be stored as such.
>
> Fixes: 0b858391781ba308 ("src: annotate follow up dependency just after killing another")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-15 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09 15:37 [PATCH nft] netlink_delink_delinearize: don't store dependency unless relop checks is eq check Florian Westphal
2017-05-15 17:05 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.