* [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests
@ 2017-05-16 3:01 Tsutomu Itoh
2017-05-16 4:46 ` Lakshmipathi.G
2017-05-29 16:43 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Tsutomu Itoh @ 2017-05-16 3:01 UTC (permalink / raw)
To: linux-btrfs
In btrfs-progs-v4.11-rc1, the following convert-tests failed.
[TEST/conv] 008-readonly-image
[TEST/conv] readonly image test, btrfs defaults
failed: mke2fs -t ext4 -b 4096 -F /Build/btrfs-progs-v4.11-rc1/tests/test.img
test failed for case 008-readonly-image
Makefile:271: recipe for target 'test-convert' failed
make: *** [test-convert] Error 1
[TEST/conv] 009-common-inode-flags
[TEST/conv] common inode flags test, btrfs defaults
failed: mke2fs -t ext4 -b 4096 -F /Build/btrfs-progs-v4.11-rc1/tests/test.img
test failed for case 009-common-inode-flags
Makefile:271: recipe for target 'test-convert' failed
make: *** [test-convert] Error 1
So, remove quotes from $default_mke2fs.
Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
---
tests/convert-tests/008-readonly-image/test.sh | 2 +-
tests/convert-tests/009-common-inode-flags/test.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/convert-tests/008-readonly-image/test.sh b/tests/convert-tests/008-readonly-image/test.sh
index b2f1ae37..27c9373e 100755
--- a/tests/convert-tests/008-readonly-image/test.sh
+++ b/tests/convert-tests/008-readonly-image/test.sh
@@ -10,7 +10,7 @@ check_prereq btrfs-convert
default_mke2fs="mke2fs -t ext4 -b 4096"
convert_test_preamble '' 'readonly image test' 16k "$default_mke2fs"
-convert_test_prep_fs "$default_mke2fs"
+convert_test_prep_fs $default_mke2fs
run_check_umount_test_dev
convert_test_do_convert
run_check_mount_test_dev
diff --git a/tests/convert-tests/009-common-inode-flags/test.sh b/tests/convert-tests/009-common-inode-flags/test.sh
index a5828790..02823e14 100755
--- a/tests/convert-tests/009-common-inode-flags/test.sh
+++ b/tests/convert-tests/009-common-inode-flags/test.sh
@@ -11,7 +11,7 @@ check_prereq btrfs-convert
fail=0
default_mke2fs="mke2fs -t ext4 -b 4096"
convert_test_preamble '' 'common inode flags test' 16k "$default_mke2fs"
-convert_test_prep_fs "$default_mke2fs"
+convert_test_prep_fs $default_mke2fs
# create file with specific flags
run_check $SUDO_HELPER touch "$TEST_MNT/flag_test"
--
2.12.2
----
Tsutomu Itoh t-itoh@jp.fujitsu.com
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests
2017-05-16 3:01 [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests Tsutomu Itoh
@ 2017-05-16 4:46 ` Lakshmipathi.G
2017-05-29 16:43 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Lakshmipathi.G @ 2017-05-16 4:46 UTC (permalink / raw)
To: Tsutomu Itoh; +Cc: linux-btrfs
Oops, sorry, I introduced those two issues in recent patches and
missed (skipped?) them while testing. With above patch, 008/009
test-cases are working fine now. thanks.
On 5/16/17, Tsutomu Itoh <t-itoh@jp.fujitsu.com> wrote:
> In btrfs-progs-v4.11-rc1, the following convert-tests failed.
>
> [TEST/conv] 008-readonly-image
> [TEST/conv] readonly image test, btrfs defaults
> failed: mke2fs -t ext4 -b 4096 -F
> /Build/btrfs-progs-v4.11-rc1/tests/test.img
> test failed for case 008-readonly-image
> Makefile:271: recipe for target 'test-convert' failed
> make: *** [test-convert] Error 1
> [TEST/conv] 009-common-inode-flags
> [TEST/conv] common inode flags test, btrfs defaults
> failed: mke2fs -t ext4 -b 4096 -F
> /Build/btrfs-progs-v4.11-rc1/tests/test.img
> test failed for case 009-common-inode-flags
> Makefile:271: recipe for target 'test-convert' failed
> make: *** [test-convert] Error 1
>
> So, remove quotes from $default_mke2fs.
>
> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
> ---
> tests/convert-tests/008-readonly-image/test.sh | 2 +-
> tests/convert-tests/009-common-inode-flags/test.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/convert-tests/008-readonly-image/test.sh
> b/tests/convert-tests/008-readonly-image/test.sh
> index b2f1ae37..27c9373e 100755
> --- a/tests/convert-tests/008-readonly-image/test.sh
> +++ b/tests/convert-tests/008-readonly-image/test.sh
> @@ -10,7 +10,7 @@ check_prereq btrfs-convert
>
> default_mke2fs="mke2fs -t ext4 -b 4096"
> convert_test_preamble '' 'readonly image test' 16k "$default_mke2fs"
> -convert_test_prep_fs "$default_mke2fs"
> +convert_test_prep_fs $default_mke2fs
> run_check_umount_test_dev
> convert_test_do_convert
> run_check_mount_test_dev
> diff --git a/tests/convert-tests/009-common-inode-flags/test.sh
> b/tests/convert-tests/009-common-inode-flags/test.sh
> index a5828790..02823e14 100755
> --- a/tests/convert-tests/009-common-inode-flags/test.sh
> +++ b/tests/convert-tests/009-common-inode-flags/test.sh
> @@ -11,7 +11,7 @@ check_prereq btrfs-convert
> fail=0
> default_mke2fs="mke2fs -t ext4 -b 4096"
> convert_test_preamble '' 'common inode flags test' 16k "$default_mke2fs"
> -convert_test_prep_fs "$default_mke2fs"
> +convert_test_prep_fs $default_mke2fs
>
> # create file with specific flags
> run_check $SUDO_HELPER touch "$TEST_MNT/flag_test"
> --
> 2.12.2
>
> ----
> Tsutomu Itoh t-itoh@jp.fujitsu.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
----
Cheers,
Lakshmipathi.G
http://www.giis.co.in http://www.webminal.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests
2017-05-16 3:01 [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests Tsutomu Itoh
2017-05-16 4:46 ` Lakshmipathi.G
@ 2017-05-29 16:43 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2017-05-29 16:43 UTC (permalink / raw)
To: Tsutomu Itoh; +Cc: linux-btrfs
On Tue, May 16, 2017 at 12:01:53PM +0900, Tsutomu Itoh wrote:
> In btrfs-progs-v4.11-rc1, the following convert-tests failed.
>
> [TEST/conv] 008-readonly-image
> [TEST/conv] readonly image test, btrfs defaults
> failed: mke2fs -t ext4 -b 4096 -F /Build/btrfs-progs-v4.11-rc1/tests/test.img
> test failed for case 008-readonly-image
> Makefile:271: recipe for target 'test-convert' failed
> make: *** [test-convert] Error 1
> [TEST/conv] 009-common-inode-flags
> [TEST/conv] common inode flags test, btrfs defaults
> failed: mke2fs -t ext4 -b 4096 -F /Build/btrfs-progs-v4.11-rc1/tests/test.img
> test failed for case 009-common-inode-flags
> Makefile:271: recipe for target 'test-convert' failed
> make: *** [test-convert] Error 1
>
> So, remove quotes from $default_mke2fs.
>
> Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-29 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 3:01 [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests Tsutomu Itoh
2017-05-16 4:46 ` Lakshmipathi.G
2017-05-29 16:43 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.