* [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
@ 2017-05-16 5:49 ` Raveendra Padasalagi
0 siblings, 0 replies; 8+ messages in thread
From: Raveendra Padasalagi @ 2017-05-16 5:49 UTC (permalink / raw)
To: Jonathan Cameron, Pavel Roskin, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Ray Jui,
Scott Branden
Cc: linux-iio, bcm-kernel-feedback-list, stable, linux-arm-kernel,
linux-kernel, Raveendra Padasalagi
The third argument of devm_request_threaded_irq() is the primary
handler. It is called in hardirq context and checks whether the
interrupt is relevant to the device. If the primary handler returns
IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
scheduled to run in process context.
bcm_iproc_adc.c uses the secondary handler as the primary one
and the other way around. So this patch fixes the same, along with
re-naming the secondary handler and primary handler names properly.
Tested on the BCM9583XX iProc SoC based boards.
Reported-by: Pavel Roskin <plroskin@gmail.com>
Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
---
drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 21d38c8..7f4f9c4 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -143,7 +143,7 @@ static void iproc_adc_reg_dump(struct iio_dev *indio_dev)
iproc_adc_dbg_reg(dev, adc_priv, IPROC_SOFT_BYPASS_DATA);
}
-static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
+static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
{
u32 channel_intr_status;
u32 intr_status;
@@ -167,7 +167,7 @@ static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
return IRQ_NONE;
}
-static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
+static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
{
irqreturn_t retval = IRQ_NONE;
struct iproc_adc_priv *adc_priv;
@@ -181,7 +181,7 @@ static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
adc_priv = iio_priv(indio_dev);
regmap_read(adc_priv->regmap, IPROC_INTERRUPT_STATUS, &intr_status);
- dev_dbg(&indio_dev->dev, "iproc_adc_interrupt_thread(),INTRPT_STS:%x\n",
+ dev_dbg(&indio_dev->dev, "iproc_adc_interrupt_handler(),INTRPT_STS:%x\n",
intr_status);
intr_channels = (intr_status & IPROC_ADC_INTR_MASK) >> IPROC_ADC_INTR;
@@ -566,8 +566,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
}
ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno,
- iproc_adc_interrupt_thread,
iproc_adc_interrupt_handler,
+ iproc_adc_interrupt_thread,
IRQF_SHARED, "iproc-adc", indio_dev);
if (ret) {
dev_err(&pdev->dev, "request_irq error %d\n", ret);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
@ 2017-05-16 5:49 ` Raveendra Padasalagi
0 siblings, 0 replies; 8+ messages in thread
From: Raveendra Padasalagi @ 2017-05-16 5:49 UTC (permalink / raw)
To: linux-arm-kernel
The third argument of devm_request_threaded_irq() is the primary
handler. It is called in hardirq context and checks whether the
interrupt is relevant to the device. If the primary handler returns
IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
scheduled to run in process context.
bcm_iproc_adc.c uses the secondary handler as the primary one
and the other way around. So this patch fixes the same, along with
re-naming the secondary handler and primary handler names properly.
Tested on the BCM9583XX iProc SoC based boards.
Reported-by: Pavel Roskin <plroskin@gmail.com>
Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
---
drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 21d38c8..7f4f9c4 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -143,7 +143,7 @@ static void iproc_adc_reg_dump(struct iio_dev *indio_dev)
iproc_adc_dbg_reg(dev, adc_priv, IPROC_SOFT_BYPASS_DATA);
}
-static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
+static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
{
u32 channel_intr_status;
u32 intr_status;
@@ -167,7 +167,7 @@ static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
return IRQ_NONE;
}
-static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
+static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
{
irqreturn_t retval = IRQ_NONE;
struct iproc_adc_priv *adc_priv;
@@ -181,7 +181,7 @@ static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
adc_priv = iio_priv(indio_dev);
regmap_read(adc_priv->regmap, IPROC_INTERRUPT_STATUS, &intr_status);
- dev_dbg(&indio_dev->dev, "iproc_adc_interrupt_thread(),INTRPT_STS:%x\n",
+ dev_dbg(&indio_dev->dev, "iproc_adc_interrupt_handler(),INTRPT_STS:%x\n",
intr_status);
intr_channels = (intr_status & IPROC_ADC_INTR_MASK) >> IPROC_ADC_INTR;
@@ -566,8 +566,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
}
ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno,
- iproc_adc_interrupt_thread,
iproc_adc_interrupt_handler,
+ iproc_adc_interrupt_thread,
IRQF_SHARED, "iproc-adc", indio_dev);
if (ret) {
dev_err(&pdev->dev, "request_irq error %d\n", ret);
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
2017-05-16 5:49 ` Raveendra Padasalagi
@ 2017-05-16 6:01 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2017-05-16 6:01 UTC (permalink / raw)
To: Raveendra Padasalagi
Cc: Jonathan Cameron, Pavel Roskin, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Ray Jui,
Scott Branden, linux-iio, bcm-kernel-feedback-list, stable,
linux-arm-kernel, linux-kernel
On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> The third argument of devm_request_threaded_irq() is the primary
> handler. It is called in hardirq context and checks whether the
> interrupt is relevant to the device. If the primary handler returns
> IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> scheduled to run in process context.
>
> bcm_iproc_adc.c uses the secondary handler as the primary one
> and the other way around. So this patch fixes the same, along with
> re-naming the secondary handler and primary handler names properly.
>
> Tested on the BCM9583XX iProc SoC based boards.
>
> Reported-by: Pavel Roskin <plroskin@gmail.com>
> Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> ---
> drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
@ 2017-05-16 6:01 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2017-05-16 6:01 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> The third argument of devm_request_threaded_irq() is the primary
> handler. It is called in hardirq context and checks whether the
> interrupt is relevant to the device. If the primary handler returns
> IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> scheduled to run in process context.
>
> bcm_iproc_adc.c uses the secondary handler as the primary one
> and the other way around. So this patch fixes the same, along with
> re-naming the secondary handler and primary handler names properly.
>
> Tested on the BCM9583XX iProc SoC based boards.
>
> Reported-by: Pavel Roskin <plroskin@gmail.com>
> Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> ---
> drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
2017-05-16 6:01 ` Greg KH
@ 2017-05-16 6:08 ` Baruch Siach
-1 siblings, 0 replies; 8+ messages in thread
From: Baruch Siach @ 2017-05-16 6:08 UTC (permalink / raw)
To: Greg KH
Cc: Raveendra Padasalagi, Lars-Peter Clausen, Scott Branden,
linux-iio, Ray Jui, linux-kernel, stable, Pavel Roskin,
bcm-kernel-feedback-list, linux-arm-kernel,
Peter Meerwald-Stadler, Hartmut Knaack, Jonathan Cameron
Hi Greg,
On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > The third argument of devm_request_threaded_irq() is the primary
> > handler. It is called in hardirq context and checks whether the
> > interrupt is relevant to the device. If the primary handler returns
> > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > scheduled to run in process context.
> >
> > bcm_iproc_adc.c uses the secondary handler as the primary one
> > and the other way around. So this patch fixes the same, along with
> > re-naming the secondary handler and primary handler names properly.
> >
> > Tested on the BCM9583XX iProc SoC based boards.
> >
> > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > ---
> > drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
Maybe linking to
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would
be better.
> </formletter>
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
@ 2017-05-16 6:08 ` Baruch Siach
0 siblings, 0 replies; 8+ messages in thread
From: Baruch Siach @ 2017-05-16 6:08 UTC (permalink / raw)
To: linux-arm-kernel
Hi Greg,
On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > The third argument of devm_request_threaded_irq() is the primary
> > handler. It is called in hardirq context and checks whether the
> > interrupt is relevant to the device. If the primary handler returns
> > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > scheduled to run in process context.
> >
> > bcm_iproc_adc.c uses the secondary handler as the primary one
> > and the other way around. So this patch fixes the same, along with
> > re-naming the secondary handler and primary handler names properly.
> >
> > Tested on the BCM9583XX iProc SoC based boards.
> >
> > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > ---
> > drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
Maybe linking to
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would
be better.
> </formletter>
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
2017-05-16 6:08 ` Baruch Siach
@ 2017-05-16 6:41 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2017-05-16 6:41 UTC (permalink / raw)
To: Baruch Siach
Cc: Raveendra Padasalagi, Lars-Peter Clausen, Scott Branden,
linux-iio, Ray Jui, linux-kernel, stable, Pavel Roskin,
bcm-kernel-feedback-list, linux-arm-kernel,
Peter Meerwald-Stadler, Hartmut Knaack, Jonathan Cameron
On Tue, May 16, 2017 at 09:08:27AM +0300, Baruch Siach wrote:
> Hi Greg,
>
> On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > > The third argument of devm_request_threaded_irq() is the primary
> > > handler. It is called in hardirq context and checks whether the
> > > interrupt is relevant to the device. If the primary handler returns
> > > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > > scheduled to run in process context.
> > >
> > > bcm_iproc_adc.c uses the secondary handler as the primary one
> > > and the other way around. So this patch fixes the same, along with
> > > re-naming the secondary handler and primary handler names properly.
> > >
> > > Tested on the BCM9583XX iProc SoC based boards.
> > >
> > > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > > ---
> > > drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
>
> File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
>
> Maybe linking to
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would
> be better.
Ah, good point, I've updated my formletter now, thanks for this.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
@ 2017-05-16 6:41 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2017-05-16 6:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 16, 2017 at 09:08:27AM +0300, Baruch Siach wrote:
> Hi Greg,
>
> On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > > The third argument of devm_request_threaded_irq() is the primary
> > > handler. It is called in hardirq context and checks whether the
> > > interrupt is relevant to the device. If the primary handler returns
> > > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > > scheduled to run in process context.
> > >
> > > bcm_iproc_adc.c uses the secondary handler as the primary one
> > > and the other way around. So this patch fixes the same, along with
> > > re-naming the secondary handler and primary handler names properly.
> > >
> > > Tested on the BCM9583XX iProc SoC based boards.
> > >
> > > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > > ---
> > > drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
>
> File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
>
> Maybe linking to
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would
> be better.
Ah, good point, I've updated my formletter now, thanks for this.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-16 6:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 5:49 [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's Raveendra Padasalagi
2017-05-16 5:49 ` Raveendra Padasalagi
2017-05-16 6:01 ` Greg KH
2017-05-16 6:01 ` Greg KH
2017-05-16 6:08 ` Baruch Siach
2017-05-16 6:08 ` Baruch Siach
2017-05-16 6:41 ` Greg KH
2017-05-16 6:41 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.