* [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning
@ 2017-05-16 7:42 Gerd Hoffmann
2017-05-16 7:52 ` Stefan Weil
2017-05-16 14:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2017-05-16 7:42 UTC (permalink / raw)
To: qemu-devel
Cc: Gerd Hoffmann, Kevin Wolf, Max Reitz, Stefan Weil, open list:raw
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
block/file-win32.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/file-win32.c b/block/file-win32.c
index 1a35dbabf2..8f14f0bdcd 100644
--- a/block/file-win32.c
+++ b/block/file-win32.c
@@ -346,6 +346,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags,
if (qdict_get_try_bool(options, "locking", false)) {
error_setg(errp, "locking=on is not supported on Windows");
+ ret = -EINVAL;
goto fail;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning
2017-05-16 7:42 [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning Gerd Hoffmann
@ 2017-05-16 7:52 ` Stefan Weil
2017-05-16 8:03 ` Fam Zheng
2017-05-16 14:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2017-05-16 7:52 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Cc: Kevin Wolf, Max Reitz, open list:raw, QEMU Trivial, Fam Zheng
Am 16.05.2017 um 09:42 schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> block/file-win32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/file-win32.c b/block/file-win32.c
> index 1a35dbabf2..8f14f0bdcd 100644
> --- a/block/file-win32.c
> +++ b/block/file-win32.c
> @@ -346,6 +346,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags,
>
> if (qdict_get_try_bool(options, "locking", false)) {
> error_setg(errp, "locking=on is not supported on Windows");
> + ret = -EINVAL;
> goto fail;
> }
This is a bug fix for commit 1c3a555c.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning
2017-05-16 7:52 ` Stefan Weil
@ 2017-05-16 8:03 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2017-05-16 8:03 UTC (permalink / raw)
To: Stefan Weil
Cc: Gerd Hoffmann, qemu-devel, Kevin Wolf, QEMU Trivial,
open list:raw, Max Reitz
On Tue, 05/16 09:52, Stefan Weil wrote:
> Am 16.05.2017 um 09:42 schrieb Gerd Hoffmann:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > block/file-win32.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/block/file-win32.c b/block/file-win32.c
> > index 1a35dbabf2..8f14f0bdcd 100644
> > --- a/block/file-win32.c
> > +++ b/block/file-win32.c
> > @@ -346,6 +346,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags,
> >
> > if (qdict_get_try_bool(options, "locking", false)) {
> > error_setg(errp, "locking=on is not supported on Windows");
> > + ret = -EINVAL;
> > goto fail;
> > }
>
>
> This is a bug fix for commit 1c3a555c.
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
>
Thank you!
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] block/win32: fix 'ret not initialized' warning
2017-05-16 7:42 [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning Gerd Hoffmann
2017-05-16 7:52 ` Stefan Weil
@ 2017-05-16 14:34 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-05-16 14:34 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: qemu-devel, Kevin Wolf, Stefan Weil, open list:raw, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
On Tue, May 16, 2017 at 09:42:55AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> block/file-win32.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-16 14:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 7:42 [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning Gerd Hoffmann
2017-05-16 7:52 ` Stefan Weil
2017-05-16 8:03 ` Fam Zheng
2017-05-16 14:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.