[PATCH net-next] cxgb4: keep carrier off after registering netdev

[PATCH net-next] cxgb4: keep carrier off after registering netdev

[Ganesh Goudar]

From: Surendra Mobiya <surendra@chelsio.com>

Mark carrier off after registering netdev to ensure that vlan device
picks up the correct state of the carrier

Signed-off-by: Surendra Mobiya <surendra@chelsio.com>
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 4249ffb..316ba8b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -4954,6 +4954,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 			break;
 		adapter->chan_map[pi->tx_chan] = i;
 		print_port_info(adapter->port[i]);
+		netif_carrier_off(adapter->port[i]);
 	}
 	if (i == 0) {
 		dev_err(&pdev->dev, "could not register any net devices\n");
-- 
2.1.0

Re: [PATCH net-next] cxgb4: keep carrier off after registering netdev

[David Miller]

From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Tue, 16 May 2017 21:26:25 +0530

> From: Surendra Mobiya <surendra@chelsio.com>
> 
> Mark carrier off after registering netdev to ensure that vlan device
> picks up the correct state of the carrier
> 
> Signed-off-by: Surendra Mobiya <surendra@chelsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>

This doesn't work.

At the very moment you perform the register netdev, it can be
openned, stacked onto other devices (like VLANs) etc. before
your line doing the carrier off occurs.

So once you do the netdev register, all the state must be
completely settled beforehand.