* [U-Boot] [PATCH v4 30/48] Kconfig: Add CONFIG_HASH to enable hashing API
@ 2017-05-17 15:05 Simon Glass
2017-05-17 17:30 ` Tom Rini
2017-05-22 18:07 ` [U-Boot] [U-Boot, v4, " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Simon Glass @ 2017-05-17 15:05 UTC (permalink / raw)
To: u-boot
At present CONFIG_CMD_HASH enables the 'hash' command which also brings
in the hashing API. Some boards may wish to enable the API without the
command. Add a separate CONFIG to permit this.
Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v4:
- Make CMD_HASH a hidden option
Changes in v3: None
Changes in v2: None
cmd/Kconfig | 2 ++
common/Kconfig | 12 ++++++++++++
common/Makefile | 2 +-
common/hash.c | 4 ++--
4 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index b05e69a8b7..1e3cd02703 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -350,6 +350,7 @@ config CMD_MEMORY
config CMD_CRC32
bool "crc32"
+ select HASH
default y
help
Compute CRC32.
@@ -998,6 +999,7 @@ config CMD_BLOB
config CMD_HASH
bool "Support 'hash' command"
+ select HASH
help
This provides a way to hash data in memory using various supported
algorithms (such as SHA1, MD5, CRC32). The computed digest can be
diff --git a/common/Kconfig b/common/Kconfig
index 1879aefaf8..5c39663f56 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -493,4 +493,16 @@ config BOARD_EARLY_INIT_F
endmenu
+menu "Security support"
+
+config HASH
+ bool # "Support hashing API (SHA1, SHA256, etc.)"
+ help
+ This provides a way to hash data in memory using various supported
+ algorithms (such as SHA1, MD5, CRC32). The API is defined in hash.h
+ and the algorithms it supports are defined in common/hash.c. See
+ also CMD_HASH for command-line access.
+
+endmenu
+
source "common/spl/Kconfig"
diff --git a/common/Makefile b/common/Makefile
index 14d01844ad..b2d663530d 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -10,7 +10,7 @@ ifndef CONFIG_SPL_BUILD
obj-y += init/
obj-y += main.o
obj-y += exports.o
-obj-y += hash.o
+obj-$(CONFIG_HASH) += hash.o
obj-$(CONFIG_HUSH_PARSER) += cli_hush.o
obj-$(CONFIG_AUTOBOOT) += autoboot.o
diff --git a/common/hash.c b/common/hash.c
index b645298afc..a0eded98d0 100644
--- a/common/hash.c
+++ b/common/hash.c
@@ -473,5 +473,5 @@ int hash_command(const char *algo_name, int flags, cmd_tbl_t *cmdtp, int flag,
return 0;
}
-#endif
-#endif
+#endif /* CONFIG_CMD_HASH || CONFIG_CMD_SHA1SUM || CONFIG_CMD_CRC32) */
+#endif /* !USE_HOSTCC */
--
2.13.0.303.g4ebf302169-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v4 30/48] Kconfig: Add CONFIG_HASH to enable hashing API
2017-05-17 15:05 [U-Boot] [PATCH v4 30/48] Kconfig: Add CONFIG_HASH to enable hashing API Simon Glass
@ 2017-05-17 17:30 ` Tom Rini
2017-05-22 18:07 ` [U-Boot] [U-Boot, v4, " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-05-17 17:30 UTC (permalink / raw)
To: u-boot
On Wed, May 17, 2017 at 09:05:34AM -0600, Simon Glass wrote:
> At present CONFIG_CMD_HASH enables the 'hash' command which also brings
> in the hashing API. Some boards may wish to enable the API without the
> command. Add a separate CONFIG to permit this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170517/93e791de/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot, v4, 30/48] Kconfig: Add CONFIG_HASH to enable hashing API
2017-05-17 15:05 [U-Boot] [PATCH v4 30/48] Kconfig: Add CONFIG_HASH to enable hashing API Simon Glass
2017-05-17 17:30 ` Tom Rini
@ 2017-05-22 18:07 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-05-22 18:07 UTC (permalink / raw)
To: u-boot
On Wed, May 17, 2017 at 09:05:34AM -0600, Simon Glass wrote:
> At present CONFIG_CMD_HASH enables the 'hash' command which also brings
> in the hashing API. Some boards may wish to enable the API without the
> command. Add a separate CONFIG to permit this.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170522/2cdc503e/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-22 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 15:05 [U-Boot] [PATCH v4 30/48] Kconfig: Add CONFIG_HASH to enable hashing API Simon Glass
2017-05-17 17:30 ` Tom Rini
2017-05-22 18:07 ` [U-Boot] [U-Boot, v4, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.