* [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-16 14:25 Anoob Soman
2017-05-16 19:55 ` Joe Stringer
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Anoob Soman @ 2017-05-16 14:25 UTC (permalink / raw)
To: stable; +Cc: pshelar, davem, netdev, dev, linux-kernel, Anoob Soman
Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
forwarding") the skb->sender_cpu needs to be cleared before forwarding
packets.
Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
---
net/openvswitch/vport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 31cbc8c..a4887e7 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -503,6 +503,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb)
}
skb->dev = vport->dev;
+ skb_sender_cpu_clear(skb);
vport->ops->send(skb);
return;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
2017-05-16 14:25 [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets Anoob Soman
@ 2017-05-16 19:55 ` Joe Stringer
2017-05-17 8:19 ` Greg KH
2017-05-21 8:47 ` kbuild test robot
2 siblings, 0 replies; 10+ messages in thread
From: Joe Stringer @ 2017-05-16 19:55 UTC (permalink / raw)
To: Anoob Soman
Cc: stable, Pravin B Shelar, David S. Miller, netdev, ovs dev, LKML
On 16 May 2017 at 07:25, Anoob Soman <anoob.soman@citrix.com> wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding") the skb->sender_cpu needs to be cleared before forwarding
> packets.
>
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
> Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
Is this needed for 4.1 too?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-17 8:19 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2017-05-17 8:19 UTC (permalink / raw)
To: Anoob Soman; +Cc: stable, pshelar, davem, netdev, dev, linux-kernel
On Tue, May 16, 2017 at 03:25:10PM +0100, Anoob Soman wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding") the skb->sender_cpu needs to be cleared before forwarding
> packets.
>
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
> Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
> ---
> net/openvswitch/vport.c | 1 +
> 1 file changed, 1 insertion(+)
Why is this a non-upstream patch? What commit in Linus's tree fixed
this? Why not just backport that?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-17 8:19 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2017-05-17 8:19 UTC (permalink / raw)
To: Anoob Soman
Cc: dev-yBygre7rU0TnMu66kgdUjQ, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
stable-u79uwXL29TY76Z2rM5mHXA, davem-fT/PcQaiUtIeIZ0/mPfg9Q
On Tue, May 16, 2017 at 03:25:10PM +0100, Anoob Soman wrote:
> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
> forwarding") the skb->sender_cpu needs to be cleared before forwarding
> packets.
>
> Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
> Signed-off-by: Anoob Soman <anoob.soman-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
> ---
> net/openvswitch/vport.c | 1 +
> 1 file changed, 1 insertion(+)
Why is this a non-upstream patch? What commit in Linus's tree fixed
this? Why not just backport that?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
2017-05-17 8:19 ` Greg KH
(?)
@ 2017-05-17 9:21 ` Anoob Soman
2017-05-18 8:11 ` Greg KH
-1 siblings, 1 reply; 10+ messages in thread
From: Anoob Soman @ 2017-05-17 9:21 UTC (permalink / raw)
To: Greg KH; +Cc: stable, pshelar, davem, netdev, dev, linux-kernel, Eric Dumazet
On 17/05/17 09:19, Greg KH wrote:
> Why is this a non-upstream patch? What commit in Linus's tree fixed
> this? Why not just backport that?
>
> thanks,
>
> greg k-h
Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better
skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than
having a different patch.
I think backport might be required for 4.1 as well, but I haven't checked.
-Anoob.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-18 8:11 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2017-05-18 8:11 UTC (permalink / raw)
To: Anoob Soman
Cc: stable, pshelar, davem, netdev, dev, linux-kernel, Eric Dumazet
On Wed, May 17, 2017 at 10:21:09AM +0100, Anoob Soman wrote:
> On 17/05/17 09:19, Greg KH wrote:
> > Why is this a non-upstream patch? What commit in Linus's tree fixed
> > this? Why not just backport that?
> >
> > thanks,
> >
> > greg k-h
>
> Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better
> skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than having a
> different patch.
So backporting that one patch solves the issue here? Can you please
verify it, and let me know before I apply it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-18 8:11 ` Greg KH
0 siblings, 0 replies; 10+ messages in thread
From: Greg KH @ 2017-05-18 8:11 UTC (permalink / raw)
To: Anoob Soman
Cc: dev-yBygre7rU0TnMu66kgdUjQ, Eric Dumazet,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
stable-u79uwXL29TY76Z2rM5mHXA, davem-fT/PcQaiUtIeIZ0/mPfg9Q
On Wed, May 17, 2017 at 10:21:09AM +0100, Anoob Soman wrote:
> On 17/05/17 09:19, Greg KH wrote:
> > Why is this a non-upstream patch? What commit in Linus's tree fixed
> > this? Why not just backport that?
> >
> > thanks,
> >
> > greg k-h
>
> Agreed, I think it is sensible to backport 52bd2d62ce67 "net: better
> skb->sender_cpu and skb->napi_id cohabitation" to 4.4, rather than having a
> different patch.
So backporting that one patch solves the issue here? Can you please
verify it, and let me know before I apply it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
2017-05-18 8:11 ` Greg KH
(?)
@ 2017-05-19 10:28 ` Anoob Soman
-1 siblings, 0 replies; 10+ messages in thread
From: Anoob Soman @ 2017-05-19 10:28 UTC (permalink / raw)
To: Greg KH; +Cc: stable, pshelar, davem, netdev, dev, linux-kernel, Eric Dumazet
On 18/05/17 09:11, Greg KH wrote:
> So backporting that one patch solves the issue here? Can you please
> verify it, and let me know before I apply it?
>
> thanks,
>
> greg k-h
yes, I can do that.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-21 8:47 ` kbuild test robot
0 siblings, 0 replies; 10+ messages in thread
From: kbuild test robot @ 2017-05-21 8:47 UTC (permalink / raw)
To: Anoob Soman
Cc: kbuild-all, stable, pshelar, davem, netdev, dev, linux-kernel,
Anoob Soman
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
Hi Anoob,
[auto build test ERROR on v4.9-rc8]
[also build test ERROR on next-20170519]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Anoob-Soman/openvswitch-clear-sender-cpu-before-forwarding-packets/20170519-111009
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/openvswitch/vport.c: In function 'ovs_vport_send':
>> net/openvswitch/vport.c:513:2: error: implicit declaration of function 'skb_sender_cpu_clear' [-Werror=implicit-function-declaration]
skb_sender_cpu_clear(skb);
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/skb_sender_cpu_clear +513 net/openvswitch/vport.c
507 packet_length(skb), mtu);
508 vport->dev->stats.tx_errors++;
509 goto drop;
510 }
511
512 skb->dev = vport->dev;
> 513 skb_sender_cpu_clear(skb);
514 vport->ops->send(skb);
515 return;
516
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38048 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets
@ 2017-05-21 8:47 ` kbuild test robot
0 siblings, 0 replies; 10+ messages in thread
From: kbuild test robot @ 2017-05-21 8:47 UTC (permalink / raw)
To: Anoob Soman
Cc: dev-yBygre7rU0TnMu66kgdUjQ, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
stable-u79uwXL29TY76Z2rM5mHXA, kbuild-all-JC7UmRfGjtg,
davem-fT/PcQaiUtIeIZ0/mPfg9Q
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
Hi Anoob,
[auto build test ERROR on v4.9-rc8]
[also build test ERROR on next-20170519]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Anoob-Soman/openvswitch-clear-sender-cpu-before-forwarding-packets/20170519-111009
config: x86_64-rhel (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/openvswitch/vport.c: In function 'ovs_vport_send':
>> net/openvswitch/vport.c:513:2: error: implicit declaration of function 'skb_sender_cpu_clear' [-Werror=implicit-function-declaration]
skb_sender_cpu_clear(skb);
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/skb_sender_cpu_clear +513 net/openvswitch/vport.c
507 packet_length(skb), mtu);
508 vport->dev->stats.tx_errors++;
509 goto drop;
510 }
511
512 skb->dev = vport->dev;
> 513 skb_sender_cpu_clear(skb);
514 vport->ops->send(skb);
515 return;
516
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-05-21 8:48 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-16 14:25 [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets Anoob Soman
2017-05-16 19:55 ` Joe Stringer
2017-05-17 8:19 ` Greg KH
2017-05-17 8:19 ` Greg KH
2017-05-17 9:21 ` Anoob Soman
2017-05-18 8:11 ` Greg KH
2017-05-18 8:11 ` Greg KH
2017-05-19 10:28 ` Anoob Soman
2017-05-21 8:47 ` kbuild test robot
2017-05-21 8:47 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.