* [PATCH] scsi: lpfc: make a couple of functions static
@ 2017-05-18 9:35 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-05-18 9:35 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context
can be made static as they do not need to be in global scope.
Cleans up sparse warnings:
"warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
Should it be static?"
"warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
index f94294b77b7b..469958e3d50a 100644
--- a/drivers/scsi/lpfc/lpfc_nvmet.c
+++ b/drivers/scsi/lpfc/lpfc_nvmet.c
@@ -828,7 +828,7 @@ static struct nvmet_fc_target_template lpfc_tgttemplate = {
.target_priv_sz = sizeof(struct lpfc_nvmet_tgtport),
};
-void
+static void
lpfc_nvmet_cleanup_io_context(struct lpfc_hba *phba)
{
struct lpfc_nvmet_ctxbuf *ctx_buf, *next_ctx_buf;
@@ -858,7 +858,7 @@ lpfc_nvmet_cleanup_io_context(struct lpfc_hba *phba)
}
}
-int
+static int
lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
{
struct lpfc_nvmet_ctxbuf *ctx_buf;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] scsi: lpfc: make a couple of functions static
@ 2017-05-18 9:35 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-05-18 9:35 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context
can be made static as they do not need to be in global scope.
Cleans up sparse warnings:
"warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
Should it be static?"
"warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
Should it be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
index f94294b77b7b..469958e3d50a 100644
--- a/drivers/scsi/lpfc/lpfc_nvmet.c
+++ b/drivers/scsi/lpfc/lpfc_nvmet.c
@@ -828,7 +828,7 @@ static struct nvmet_fc_target_template lpfc_tgttemplate = {
.target_priv_sz = sizeof(struct lpfc_nvmet_tgtport),
};
-void
+static void
lpfc_nvmet_cleanup_io_context(struct lpfc_hba *phba)
{
struct lpfc_nvmet_ctxbuf *ctx_buf, *next_ctx_buf;
@@ -858,7 +858,7 @@ lpfc_nvmet_cleanup_io_context(struct lpfc_hba *phba)
}
}
-int
+static int
lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
{
struct lpfc_nvmet_ctxbuf *ctx_buf;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: lpfc: make a couple of functions static
2017-05-18 9:35 ` Colin King
@ 2017-05-29 23:08 ` James Smart
-1 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2017-05-29 23:08 UTC (permalink / raw)
To: Colin King, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
Patch is fine.
Signed-off-by: James Smart <james.smart@broadcom.com>
-- james
On 5/18/2017 2:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context
> can be made static as they do not need to be in global scope.
>
> Cleans up sparse warnings:
> "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
> Should it be static?"
> "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
> Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: lpfc: make a couple of functions static
@ 2017-05-29 23:08 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2017-05-29 23:08 UTC (permalink / raw)
To: Colin King, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
Patch is fine.
Signed-off-by: James Smart <james.smart@broadcom.com>
-- james
On 5/18/2017 2:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context
> can be made static as they do not need to be in global scope.
>
> Cleans up sparse warnings:
> "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
> Should it be static?"
> "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
> Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: lpfc: make a couple of functions static
2017-05-18 9:35 ` Colin King
@ 2017-06-13 1:05 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2017-06-13 1:05 UTC (permalink / raw)
To: Colin King
Cc: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
Colin,
> functions lpfc_nvmet_cleanup_io_context and
> lpfc_nvmet_setup_io_context can be made static as they do not need to
> be in global scope.
>
> Cleans up sparse warnings:
> "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
> Should it be static?"
> "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
> Should it be static?"
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: lpfc: make a couple of functions static
@ 2017-06-13 1:05 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2017-06-13 1:05 UTC (permalink / raw)
To: Colin King
Cc: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
Colin,
> functions lpfc_nvmet_cleanup_io_context and
> lpfc_nvmet_setup_io_context can be made static as they do not need to
> be in global scope.
>
> Cleans up sparse warnings:
> "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
> Should it be static?"
> "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
> Should it be static?"
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-13 1:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 9:35 [PATCH] scsi: lpfc: make a couple of functions static Colin King
2017-05-18 9:35 ` Colin King
2017-05-29 23:08 ` James Smart
2017-05-29 23:08 ` James Smart
2017-06-13 1:05 ` Martin K. Petersen
2017-06-13 1:05 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.