[PATCH] zlib: Mark get_unaligned16() as __maybe_unused

[PATCH] zlib: Mark get_unaligned16() as __maybe_unused

[Matthias Kaehlcke]

The function is not used with all configurations. Adding the attribute
fixes the following warning when building with clang and
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y:

lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16'
    [-Werror,-Wunused-function]
get_unaligned16(const unsigned short *p)

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 lib/zlib_inflate/inffast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/zlib_inflate/inffast.c b/lib/zlib_inflate/inffast.c
index 2c13ecc5bb2c..05a6d9626d9f 100644
--- a/lib/zlib_inflate/inffast.c
+++ b/lib/zlib_inflate/inffast.c
@@ -27,7 +27,7 @@ union uu {
 };
 
 /* Endian independed version */
-static inline unsigned short
+static inline unsigned short __maybe_unused
 get_unaligned16(const unsigned short *p)
 {
 	union uu  mm;
-- 
2.13.0.303.g4ebf302169-goog

Re: [PATCH] zlib: Mark get_unaligned16() as __maybe_unused

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2282 bytes --]

Hi Matthias,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.12-rc1 next-20170518]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/zlib-Mark-get_unaligned16-as-__maybe_unused/20170519-083133
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=powerpc 

All error/warnings (new ones prefixed by >>):

>> arch/powerpc/boot/inffast.c:31:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'get_unaligned16'
    get_unaligned16(const unsigned short *p)
    ^~~~~~~~~~~~~~~
   arch/powerpc/boot/inffast.c: In function 'inflate_fast':
>> arch/powerpc/boot/inffast.c:48:27: warning: implicit declaration of function 'get_unaligned16' [-Wimplicit-function-declaration]
    #  define UP_UNALIGNED(a) get_unaligned16(++(a))
                              ^
   arch/powerpc/boot/inffast.c:281:20: note: in expansion of macro 'UP_UNALIGNED'
           PUP(sout) = UP_UNALIGNED(sfrom);
                       ^~~~~~~~~~~~
--
   In file included from ./arch/powerpc/boot/decompress_inflate.c:10:0,
                    from arch/powerpc/boot/decompress.c:37:
>> ./arch/powerpc/boot/inffast.c:31:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'get_unaligned16'
    get_unaligned16(const unsigned short *p)
    ^~~~~~~~~~~~~~~
   ./arch/powerpc/boot/inffast.c: In function 'inflate_fast':
>> ./arch/powerpc/boot/inffast.c:48:27: warning: implicit declaration of function 'get_unaligned16' [-Wimplicit-function-declaration]
    #  define UP_UNALIGNED(a) get_unaligned16(++(a))
                              ^
   ./arch/powerpc/boot/inffast.c:281:20: note: in expansion of macro 'UP_UNALIGNED'
           PUP(sout) = UP_UNALIGNED(sfrom);
                       ^~~~~~~~~~~~

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23372 bytes --]

[PATCH] zlib: Mark get_unaligned16() as __maybe_unused

[Matthias Kaehlcke]

The function is not used with all configurations. Adding the attribute
fixes the following warning when building with clang and
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y:

lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16'
    [-Werror,-Wunused-function]
get_unaligned16(const unsigned short *p)

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
 lib/zlib_inflate/inffast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/zlib_inflate/inffast.c b/lib/zlib_inflate/inffast.c
index 2c13ecc5bb2c..05a6d9626d9f 100644
--- a/lib/zlib_inflate/inffast.c
+++ b/lib/zlib_inflate/inffast.c
@@ -27,7 +27,7 @@ union uu {
 };
 
 /* Endian independed version */
-static inline unsigned short
+static inline unsigned short __maybe_unused
 get_unaligned16(const unsigned short *p)
 {
 	union uu  mm;
-- 
2.13.0.303.g4ebf302169-goog