All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-mm@kvack.org, Dan Streetman <ddstreet@ieee.org>,
	Seth Jennings <sjenning@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()
Date: Sun, 21 May 2017 11:56:54 +0200	[thread overview]
Message-ID: <20170521095654.bzpaa2obfszrajgb@ninjato> (raw)
In-Reply-To: <7bd4b458-6f6e-416b-97a9-b1b3d0840144@users.sourceforge.net>

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Markus,

> > Markus, can you please stop CCing me on every of those patches?
> 
> Yes, of course.

Thanks!

> >> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> 
> Did I interpret any information from your presentation slides in an
> inappropriate way?

Have you read my LWN article "Best practices for a big patch series"?

https://lwn.net/Articles/585782/

> > And why do you create a patch for every occasion in the same file?
> 
> This can occasionally happen when I am more unsure about the change acceptance
> for a specific place.

Why were you unsure here?

> This can also happen as a side effect if such a source code search pattern
> will point hundreds of places out for further software development considerations.
> How would you prefer to clarify the remaining update candidates there?

Maybe the article mentioned can provice further guidance?

Have a nice sunday,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-mm@kvack.org, Dan Streetman <ddstreet@ieee.org>,
	Seth Jennings <sjenning@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare()
Date: Sun, 21 May 2017 09:56:54 +0000	[thread overview]
Message-ID: <20170521095654.bzpaa2obfszrajgb@ninjato> (raw)
In-Reply-To: <7bd4b458-6f6e-416b-97a9-b1b3d0840144@users.sourceforge.net>

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Markus,

> > Markus, can you please stop CCing me on every of those patches?
> 
> Yes, of course.

Thanks!

> >> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> 
> Did I interpret any information from your presentation slides in an
> inappropriate way?

Have you read my LWN article "Best practices for a big patch series"?

https://lwn.net/Articles/585782/

> > And why do you create a patch for every occasion in the same file?
> 
> This can occasionally happen when I am more unsure about the change acceptance
> for a specific place.

Why were you unsure here?

> This can also happen as a side effect if such a source code search pattern
> will point hundreds of places out for further software development considerations.
> How would you prefer to clarify the remaining update candidates there?

Maybe the article mentioned can provice further guidance?

Have a nice sunday,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-21  9:56 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-21  8:23 [PATCH 0/3] zswap: Adjustments for three function implementations SF Markus Elfring
2017-05-21  8:23 ` SF Markus Elfring
2017-05-21  8:23 ` SF Markus Elfring
2017-05-21  8:25 ` [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create() SF Markus Elfring
2017-05-21  8:25   ` SF Markus Elfring
2017-05-21  8:25   ` SF Markus Elfring
2017-05-30 23:18   ` Dan Streetman
2017-05-30 23:18     ` Dan Streetman
2017-05-30 23:18     ` Dan Streetman
2017-05-21  8:26 ` [PATCH 2/3] zswap: Improve a size determination in zswap_frontswap_init() SF Markus Elfring
2017-05-21  8:26   ` SF Markus Elfring
2017-05-21  8:26   ` SF Markus Elfring
2017-05-30 23:19   ` Dan Streetman
2017-05-30 23:19     ` Dan Streetman
2017-05-30 23:19     ` Dan Streetman
2017-05-21  8:27 ` [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare() SF Markus Elfring
2017-05-21  8:27   ` SF Markus Elfring
2017-05-21  8:27   ` SF Markus Elfring
2017-05-21  8:47   ` Wolfram Sang
2017-05-21  8:47     ` [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepar Wolfram Sang
2017-05-21  9:40     ` zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare() SF Markus Elfring
2017-05-21  9:40       ` SF Markus Elfring
2017-05-21  9:40       ` SF Markus Elfring
2017-05-21  9:56       ` Wolfram Sang [this message]
2017-05-21  9:56         ` Wolfram Sang
2017-05-21 10:12         ` Using best practices for big software change possibilities SF Markus Elfring
2017-05-21 10:12           ` SF Markus Elfring
2017-05-21 10:12           ` SF Markus Elfring
2017-05-21 10:27           ` Wolfram Sang
2017-05-21 10:27             ` Wolfram Sang
2017-05-21 10:45             ` SF Markus Elfring
2017-05-21 10:45               ` SF Markus Elfring
2017-05-21 10:45               ` SF Markus Elfring
2017-05-30 23:20   ` [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare() Dan Streetman
2017-05-30 23:20     ` Dan Streetman
2017-05-30 23:20     ` [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepar Dan Streetman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170521095654.bzpaa2obfszrajgb@ninjato \
    --to=wsa@the-dreams.de \
    --cc=ddstreet@ieee.org \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sjenning@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.