[U-Boot] [PATCH v2] test: py: Add cmd_echo dependency

* [U-Boot] [PATCH v2] test: py: Add cmd_echo dependency
@ 2017-05-15 12:29 Michal Simek
  2017-05-15 21:49 ` Stephen Warren
  2017-05-22 17:58 ` [U-Boot] [U-Boot,v2] " Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2017-05-15 12:29 UTC (permalink / raw)
  To: u-boot

There is missing dependency on echo command. Mark tests which requires
echo.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- Removed incorrect dependency on echo command
- Add empty line before header and module import
- Mark the whole file with global pytestmark - all reported by Stephen

 test/py/tests/test_env.py          | 3 +++
 test/py/tests/test_shell_basics.py | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py
index 035dbf5cac4c..b7f960c755fe 100644
--- a/test/py/tests/test_env.py
+++ b/test/py/tests/test_env.py
@@ -164,6 +164,7 @@ def test_env_echo_exists(state_test_env):
     value = state_test_env.env[var]
     validate_set(state_test_env, var, value)
 
+ at pytest.mark.buildconfigspec('cmd_echo')
 def test_env_echo_non_existent(state_test_env):
     """Test echoing a variable that doesn't exist."""
 
@@ -179,6 +180,7 @@ def test_env_printenv_non_existent(state_test_env):
         response = c.run_command('printenv %s' % var)
     assert(response == '## Error: "%s" not defined' % var)
 
+ at pytest.mark.buildconfigspec('cmd_echo')
 def test_env_unset_non_existent(state_test_env):
     """Test unsetting a nonexistent variable."""
 
@@ -202,6 +204,7 @@ def test_env_set_existing(state_test_env):
     set_var(state_test_env, var, value)
     validate_set(state_test_env, var, value)
 
+ at pytest.mark.buildconfigspec('cmd_echo')
 def test_env_unset_existing(state_test_env):
     """Test unsetting a variable."""
 
diff --git a/test/py/tests/test_shell_basics.py b/test/py/tests/test_shell_basics.py
index 702e5e27e002..0024d5f7f619 100644
--- a/test/py/tests/test_shell_basics.py
+++ b/test/py/tests/test_shell_basics.py
@@ -4,6 +4,10 @@
 
 # Test basic shell functionality, such as commands separate by semi-colons.
 
+import pytest
+
+pytestmark = pytest.mark.buildconfigspec('cmd_echo')
+
 def test_shell_execute(u_boot_console):
     """Test any shell command."""
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread