From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] mtd: mchp23k256: Add support for mchp23lcv1024
Date: Tue, 23 May 2017 03:57:23 +0200 [thread overview]
Message-ID: <20170523015723.GL13759@lunn.ch> (raw)
In-Reply-To: <f2d5f14ab64a412eab5eab5d572cc4a6@svr-chch-ex1.atlnz.lc>
> Agreed. How about this revised commit message
>
> --- 8< ---
> mtd: mchp23k256: Add support for mchp23lcv1024
>
> The mchp23lcv1024 is similar to the mchp23k256, the differences (from a
> software point of view) are the capacity of the chip and the size of the
> addresses used.
>
> There is no way to detect the specific chip so we must be told via a
> Device Tree or default to mchp23k256 when device tree is not used.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> --- >8 ---
Yes, that is good.
> Can someone fixup the commit message or should I re-send?
The less the maintainer has to do, the more likely he will do it.
But hold on a few days, and see if you get any more comments.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: Mark Rutland <mark.rutland@arm.com>,
"boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Richard Weinberger <richard@nod.at>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH v3 5/5] mtd: mchp23k256: Add support for mchp23lcv1024
Date: Tue, 23 May 2017 03:57:23 +0200 [thread overview]
Message-ID: <20170523015723.GL13759@lunn.ch> (raw)
In-Reply-To: <f2d5f14ab64a412eab5eab5d572cc4a6@svr-chch-ex1.atlnz.lc>
> Agreed. How about this revised commit message
>
> --- 8< ---
> mtd: mchp23k256: Add support for mchp23lcv1024
>
> The mchp23lcv1024 is similar to the mchp23k256, the differences (from a
> software point of view) are the capacity of the chip and the size of the
> addresses used.
>
> There is no way to detect the specific chip so we must be told via a
> Device Tree or default to mchp23k256 when device tree is not used.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> --- >8 ---
Yes, that is good.
> Can someone fixup the commit message or should I re-send?
The less the maintainer has to do, the more likely he will do it.
But hold on a few days, and see if you get any more comments.
Andrew
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2017-05-23 1:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 0:43 [PATCH v3 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham
2017-05-23 0:43 ` [PATCH v3 1/5] mtd: mchp23k256: Add OF device ID table Chris Packham
2017-05-23 0:43 ` [PATCH v3 2/5] mtd: mchp23k256: switch to mtd_device_register() Chris Packham
2017-05-23 0:43 ` [PATCH v3 3/5] mtd: handle partitioning on devices with 0 erasesize Chris Packham
2017-05-23 0:43 ` [PATCH v3 4/5] mtd: mchp23k256: add partitioning support Chris Packham
2017-05-23 0:43 ` [PATCH v3 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham
2017-05-23 0:58 ` Andrew Lunn
2017-05-23 0:58 ` Andrew Lunn
2017-05-23 1:38 ` Chris Packham
2017-05-23 1:38 ` Chris Packham
2017-05-23 1:57 ` Andrew Lunn [this message]
2017-05-23 1:57 ` Andrew Lunn
2017-05-23 1:57 ` Andrew Lunn
2017-05-23 7:14 ` Boris Brezillon
2017-05-23 7:14 ` Boris Brezillon
2017-05-23 20:29 ` Chris Packham
2017-05-23 20:29 ` Chris Packham
2017-05-23 7:39 ` [PATCH v3 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Boris Brezillon
2017-05-23 11:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523015723.GL13759@lunn.ch \
--to=andrew@lunn.ch \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.