From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v1 00/12] NFS/RDMA client-side patches proposed for v4.13 Date: Tue, 23 May 2017 10:53:37 -0400 [thread overview] Message-ID: <20170523142629.961.81233.stgit@manet.1015granger.net> (raw) This series contains a major fix for client-side NFS/RDMA. When a signal fires, it's possible for the server's RPC reply to race with the client code that terminates the RPC after a signal. The result is both of these code paths try to invalidate the same MR at the same time. Because FRWR invalidation is typically fast, it's nearly impossible to hit the race with FRWR. However, FMR invalidation happens at about the same speed as the NFS server responds, so it's more likely to hit this window when using FMR. FMR is also more sensitive to concurrent operations on the same MR, which can result in a kernel crash or an HCA firmware reset. As part of closing the signal race window, the reply handler is restructured and several error recovery paths in the invalidation code are fixed. In addition to this fix, there is a small but important change to make NFSv4.1 Transparent State Migration work. This enables basic test cases to pass successfully. However, NFSv4.1 TSM is still under test, so the default setting of CONFIG_NFS_V4_1_MIGRATION remains unchanged for the moment. Available in the "nfs-rdma-for-4.13" topic branch of this git repo: git://git.linux-nfs.org/projects/cel/cel-2.6.git Or for browsing: http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=log;h=refs/heads/nfs-rdma-for-4.13 Chuck Lever (12): xprtrdma: Don't defer MR recovery if ro_map fails xprtrdma: On invalidation failure, remove MWs from rl_registered xprtrdma: Fix FRWR invalidation error recovery xprtrdma: Pre-mark remotely invalidated MRs xprtrdma: Pass only the list of registered MRs to ro_unmap_sync xprtrdma: Rename rpcrdma_req::rl_free xprtrdma: Fix client lock-up after application signal fires NFSv4.1: Handle EXCHGID4_FLAG_CONFIRMED_R during NFSv4.1 migration xprtrdma: Demote "connect" log messages xprtrdma: FMR does not need list_del_init() xprtrdma: Replace PAGE_MASK with offset_in_page() xprtrdma: Fix documenting comments in frwr_ops.c fs/nfs/nfs4proc.c | 2 - fs/nfs/nfs4state.c | 11 +++ net/sunrpc/xprtrdma/fmr_ops.c | 47 ++++++++------- net/sunrpc/xprtrdma/frwr_ops.c | 69 ++++++++++------------ net/sunrpc/xprtrdma/rpc_rdma.c | 125 +++++++++++++++++++++++++-------------- net/sunrpc/xprtrdma/transport.c | 3 + net/sunrpc/xprtrdma/verbs.c | 55 ++++------------- net/sunrpc/xprtrdma/xprt_rdma.h | 40 ++++++++++++ 8 files changed, 204 insertions(+), 148 deletions(-) -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com> To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Subject: [PATCH v1 00/12] NFS/RDMA client-side patches proposed for v4.13 Date: Tue, 23 May 2017 10:53:37 -0400 [thread overview] Message-ID: <20170523142629.961.81233.stgit@manet.1015granger.net> (raw) This series contains a major fix for client-side NFS/RDMA. When a signal fires, it's possible for the server's RPC reply to race with the client code that terminates the RPC after a signal. The result is both of these code paths try to invalidate the same MR at the same time. Because FRWR invalidation is typically fast, it's nearly impossible to hit the race with FRWR. However, FMR invalidation happens at about the same speed as the NFS server responds, so it's more likely to hit this window when using FMR. FMR is also more sensitive to concurrent operations on the same MR, which can result in a kernel crash or an HCA firmware reset. As part of closing the signal race window, the reply handler is restructured and several error recovery paths in the invalidation code are fixed. In addition to this fix, there is a small but important change to make NFSv4.1 Transparent State Migration work. This enables basic test cases to pass successfully. However, NFSv4.1 TSM is still under test, so the default setting of CONFIG_NFS_V4_1_MIGRATION remains unchanged for the moment. Available in the "nfs-rdma-for-4.13" topic branch of this git repo: git://git.linux-nfs.org/projects/cel/cel-2.6.git Or for browsing: http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=log;h=refs/heads/nfs-rdma-for-4.13 Chuck Lever (12): xprtrdma: Don't defer MR recovery if ro_map fails xprtrdma: On invalidation failure, remove MWs from rl_registered xprtrdma: Fix FRWR invalidation error recovery xprtrdma: Pre-mark remotely invalidated MRs xprtrdma: Pass only the list of registered MRs to ro_unmap_sync xprtrdma: Rename rpcrdma_req::rl_free xprtrdma: Fix client lock-up after application signal fires NFSv4.1: Handle EXCHGID4_FLAG_CONFIRMED_R during NFSv4.1 migration xprtrdma: Demote "connect" log messages xprtrdma: FMR does not need list_del_init() xprtrdma: Replace PAGE_MASK with offset_in_page() xprtrdma: Fix documenting comments in frwr_ops.c fs/nfs/nfs4proc.c | 2 - fs/nfs/nfs4state.c | 11 +++ net/sunrpc/xprtrdma/fmr_ops.c | 47 ++++++++------- net/sunrpc/xprtrdma/frwr_ops.c | 69 ++++++++++------------ net/sunrpc/xprtrdma/rpc_rdma.c | 125 +++++++++++++++++++++++++-------------- net/sunrpc/xprtrdma/transport.c | 3 + net/sunrpc/xprtrdma/verbs.c | 55 ++++------------- net/sunrpc/xprtrdma/xprt_rdma.h | 40 ++++++++++++ 8 files changed, 204 insertions(+), 148 deletions(-) -- Chuck Lever
next reply other threads:[~2017-05-23 14:53 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-23 14:53 Chuck Lever [this message] 2017-05-23 14:53 ` [PATCH v1 00/12] NFS/RDMA client-side patches proposed for v4.13 Chuck Lever [not found] ` <20170523142629.961.81233.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> 2017-05-23 14:53 ` [PATCH v1 01/12] xprtrdma: Don't defer MR recovery if ro_map fails Chuck Lever 2017-05-23 14:53 ` Chuck Lever 2017-05-23 14:53 ` [PATCH v1 02/12] xprtrdma: On invalidation failure, remove MWs from rl_registered Chuck Lever 2017-05-23 14:53 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 03/12] xprtrdma: Fix FRWR invalidation error recovery Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 04/12] xprtrdma: Pre-mark remotely invalidated MRs Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 05/12] xprtrdma: Pass only the list of registered MRs to ro_unmap_sync Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 06/12] xprtrdma: Rename rpcrdma_req::rl_free Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 07/12] xprtrdma: Fix client lock-up after application signal fires Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 08/12] NFSv4.1: Handle EXCHGID4_FLAG_CONFIRMED_R during NFSv4.1 migration Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 09/12] xprtrdma: Demote "connect" log messages Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:54 ` [PATCH v1 10/12] xprtrdma: FMR does not need list_del_init() Chuck Lever 2017-05-23 14:54 ` Chuck Lever 2017-05-23 14:55 ` [PATCH v1 11/12] xprtrdma: Replace PAGE_MASK with offset_in_page() Chuck Lever 2017-05-23 14:55 ` Chuck Lever 2017-05-23 14:55 ` [PATCH v1 12/12] xprtrdma: Fix documenting comments in frwr_ops.c Chuck Lever 2017-05-23 14:55 ` Chuck Lever
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170523142629.961.81233.stgit@manet.1015granger.net \ --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \ --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.