* [U-Boot] [PATCH] rockchip: Set up default PWM flags @ 2017-05-24 0:15 Simon Glass 2017-10-06 16:26 ` [U-Boot] " Philipp Tomsich 2017-10-06 16:26 ` Philipp Tomsich 0 siblings, 2 replies; 3+ messages in thread From: Simon Glass @ 2017-05-24 0:15 UTC (permalink / raw) To: u-boot At present if the PWM set_invert() method is not called then the flags are not set up and the driver does not work properly. Fix this by setting up the default flags when probing. Signed-off-by: Simon Glass <sjg@chromium.org> Fixes: 874ee59 (rockchip: pwm: implement pwm_set_invert()) --- drivers/pwm/rk_pwm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/rk_pwm.c b/drivers/pwm/rk_pwm.c index f3b2f7615d..5d78d4a67d 100644 --- a/drivers/pwm/rk_pwm.c +++ b/drivers/pwm/rk_pwm.c @@ -92,6 +92,7 @@ static int rk_pwm_probe(struct udevice *dev) return -EINVAL; } priv->freq = clk_get_rate(&clk); + priv->enable_conf = PWM_DUTY_POSTIVE | PWM_INACTIVE_POSTIVE; return 0; } -- 2.13.0.219.gdb65acc882-goog ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] rockchip: Set up default PWM flags 2017-05-24 0:15 [U-Boot] [PATCH] rockchip: Set up default PWM flags Simon Glass @ 2017-10-06 16:26 ` Philipp Tomsich 2017-10-06 16:26 ` Philipp Tomsich 1 sibling, 0 replies; 3+ messages in thread From: Philipp Tomsich @ 2017-10-06 16:26 UTC (permalink / raw) To: u-boot > At present if the PWM set_invert() method is not called then the flags are > not set up and the driver does not work properly. Fix this by setting up > the default flags when probing. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Fixes: 874ee59 (rockchip: pwm: implement pwm_set_invert()) > --- > > drivers/pwm/rk_pwm.c | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] rockchip: Set up default PWM flags 2017-05-24 0:15 [U-Boot] [PATCH] rockchip: Set up default PWM flags Simon Glass 2017-10-06 16:26 ` [U-Boot] " Philipp Tomsich @ 2017-10-06 16:26 ` Philipp Tomsich 1 sibling, 0 replies; 3+ messages in thread From: Philipp Tomsich @ 2017-10-06 16:26 UTC (permalink / raw) To: u-boot > At present if the PWM set_invert() method is not called then the flags are > not set up and the driver does not work properly. Fix this by setting up > the default flags when probing. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Fixes: 874ee59 (rockchip: pwm: implement pwm_set_invert()) > --- > > drivers/pwm/rk_pwm.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-06 16:26 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-24 0:15 [U-Boot] [PATCH] rockchip: Set up default PWM flags Simon Glass 2017-10-06 16:26 ` [U-Boot] " Philipp Tomsich 2017-10-06 16:26 ` Philipp Tomsich
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.