All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs: tree-log.c: Wrong printk information about namelen
@ 2017-05-24  1:31 Su Yue
  2017-05-26 18:38 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Su Yue @ 2017-05-24  1:31 UTC (permalink / raw)
  To: linux-btrfs

In verify_dir_item, it wants to printk name_len of dir_item but
printk data_len acutally.

Fix it by calling btrfs_dir_name_len instead of btrfs_dir_data_len.

Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
 fs/btrfs/dir-item.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c
index 60a750678a82..c24d615e3d7f 100644
--- a/fs/btrfs/dir-item.c
+++ b/fs/btrfs/dir-item.c
@@ -468,7 +468,7 @@ int verify_dir_item(struct btrfs_fs_info *fs_info,
 
 	if (btrfs_dir_name_len(leaf, dir_item) > namelen) {
 		btrfs_crit(fs_info, "invalid dir item name len: %u",
-		       (unsigned)btrfs_dir_data_len(leaf, dir_item));
+		       (unsigned)btrfs_dir_name_len(leaf, dir_item));
 		return 1;
 	}
 
-- 
2.13.0




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs: tree-log.c: Wrong printk information about namelen
  2017-05-24  1:31 [PATCH] btrfs: tree-log.c: Wrong printk information about namelen Su Yue
@ 2017-05-26 18:38 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-05-26 18:38 UTC (permalink / raw)
  To: Su Yue; +Cc: linux-btrfs

On Wed, May 24, 2017 at 09:31:32AM +0800, Su Yue wrote:
> In verify_dir_item, it wants to printk name_len of dir_item but
> printk data_len acutally.

Good catch, thanks.

Reviewed-by: David Sterba <dsterba@suse.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-26 18:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-24  1:31 [PATCH] btrfs: tree-log.c: Wrong printk information about namelen Su Yue
2017-05-26 18:38 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.