From: "Du, Changbin" <changbin.du@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
changbin.du@intel.com, daniel.vetter@intel.com,
jani.nikula@linux.intel.com, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, zhenyuw@linux.intel.com
Subject: Re: [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected
Date: Wed, 24 May 2017 17:36:56 +0800 [thread overview]
Message-ID: <20170524093656.GA23626@intel.com> (raw)
In-Reply-To: <20170524092131.GA21114@nuc-i3427.alporthouse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1022 bytes --]
On Wed, May 24, 2017 at 10:21:31AM +0100, Chris Wilson wrote:
> On Wed, May 24, 2017 at 04:50:39PM +0800, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> >
> > At least we need one MPT module (currently only have one) selected
> > to get GVTg functional. When GVTg is enabled while no MPT selected,
> > the build just includes useless GVTg code. This doesn't make sense.
>
> See the Kconfig "choice" directive.
> -Chris
>
I was thought about "choice" as in mind firstly and that is good. But I think
this is better since it make it totaly impossible that GVT is enabled while no
MPT. With "choice", if we forget disable GVT after unselect all MPTs, we still
compile GVT in but will never not use it.
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
--
Thanks,
Changbin Du
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-24 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 8:50 [PATCH] drm/i915: prevent generating unusable gvt build which no mpt module is selected changbin.du
2017-05-24 9:17 ` Zhenyu Wang
2017-05-24 9:21 ` Chris Wilson
2017-05-24 9:36 ` Du, Changbin [this message]
2017-05-24 9:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-24 11:35 ` [PATCH] " Jani Nikula
2017-05-25 6:09 ` Du, Changbin
2017-05-26 9:58 ` Jani Nikula
2017-05-26 10:27 ` Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524093656.GA23626@intel.com \
--to=changbin.du@intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.