* [PATCH v2] clk: mvebu: add support for 1866MHz variants
@ 2017-05-23 21:01 Ralph Sennhauser
2017-05-24 13:48 ` Gregory CLEMENT
2017-06-01 7:24 ` Stephen Boyd
0 siblings, 2 replies; 5+ messages in thread
From: Ralph Sennhauser @ 2017-05-23 21:01 UTC (permalink / raw)
To: linux-clk
Cc: Andrew Lunn, Gregory CLEMENT, Ralph Sennhauser,
Michael Turquette, Stephen Boyd, linux-kernel
The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
list of supported CPU frequencies. Also update multiplier and divisor
for the l2clk and ddrclk.
Noticed by the following warning:
[ 0.000000] Selected CPU frequency (16) unsupported
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
Hi everyone,
This patch was part of a series adding support for the Linksys WRT3200ACM which
got mostly merged already. So this one comes as a stand-alone patch intended
for 4.13.
Thanks
Ralph
---
Changes since v1:
- Update multipliers for and divisors for l2clk and ddrclk
---
drivers/clk/mvebu/armada-38x.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c
index 8bccf4e..394aa6f 100644
--- a/drivers/clk/mvebu/armada-38x.c
+++ b/drivers/clk/mvebu/armada-38x.c
@@ -49,7 +49,8 @@ static const u32 armada_38x_cpu_frequencies[] __initconst = {
0, 0, 0, 0,
1066 * 1000 * 1000, 0, 0, 0,
1332 * 1000 * 1000, 0, 0, 0,
- 1600 * 1000 * 1000,
+ 1600 * 1000 * 1000, 0, 0, 0,
+ 1866 * 1000 * 1000,
};
static u32 __init armada_38x_get_cpu_freq(void __iomem *sar)
@@ -79,7 +80,7 @@ static const int armada_38x_cpu_l2_ratios[32][2] __initconst = {
{1, 2}, {0, 1}, {0, 1}, {0, 1},
{1, 2}, {0, 1}, {0, 1}, {0, 1},
{1, 2}, {0, 1}, {0, 1}, {0, 1},
- {0, 1}, {0, 1}, {0, 1}, {0, 1},
+ {1, 2}, {0, 1}, {0, 1}, {0, 1},
{0, 1}, {0, 1}, {0, 1}, {0, 1},
{0, 1}, {0, 1}, {0, 1}, {0, 1},
{0, 1}, {0, 1}, {0, 1}, {0, 1},
@@ -90,7 +91,7 @@ static const int armada_38x_cpu_ddr_ratios[32][2] __initconst = {
{1, 2}, {0, 1}, {0, 1}, {0, 1},
{1, 2}, {0, 1}, {0, 1}, {0, 1},
{1, 2}, {0, 1}, {0, 1}, {0, 1},
- {0, 1}, {0, 1}, {0, 1}, {0, 1},
+ {1, 2}, {0, 1}, {0, 1}, {0, 1},
{0, 1}, {0, 1}, {0, 1}, {0, 1},
{0, 1}, {0, 1}, {0, 1}, {0, 1},
{0, 1}, {0, 1}, {0, 1}, {0, 1},
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: mvebu: add support for 1866MHz variants
2017-05-23 21:01 [PATCH v2] clk: mvebu: add support for 1866MHz variants Ralph Sennhauser
@ 2017-05-24 13:48 ` Gregory CLEMENT
2017-06-01 7:24 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: Gregory CLEMENT @ 2017-05-24 13:48 UTC (permalink / raw)
To: Ralph Sennhauser
Cc: linux-clk, Andrew Lunn, Michael Turquette, Stephen Boyd, linux-kernel
Hi Ralph,
On mar., mai 23 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
Adding a word about the fact this patch is for the armada 38x SoC in the
title would be nice.
> The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> list of supported CPU frequencies. Also update multiplier and divisor
> for the l2clk and ddrclk.
>
> Noticed by the following warning:
> [ 0.000000] Selected CPU frequency (16) unsupported
I checked your values with the hardware datasheet and they match the
documentation:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> ---
>
> Hi everyone,
>
> This patch was part of a series adding support for the Linksys WRT3200ACM which
> got mostly merged already. So this one comes as a stand-alone patch intended
> for 4.13.
>
> Thanks
> Ralph
> ---
>
> Changes since v1:
>
> - Update multipliers for and divisors for l2clk and ddrclk
> ---
> drivers/clk/mvebu/armada-38x.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c
> index 8bccf4e..394aa6f 100644
> --- a/drivers/clk/mvebu/armada-38x.c
> +++ b/drivers/clk/mvebu/armada-38x.c
> @@ -49,7 +49,8 @@ static const u32 armada_38x_cpu_frequencies[] __initconst = {
> 0, 0, 0, 0,
> 1066 * 1000 * 1000, 0, 0, 0,
> 1332 * 1000 * 1000, 0, 0, 0,
> - 1600 * 1000 * 1000,
> + 1600 * 1000 * 1000, 0, 0, 0,
> + 1866 * 1000 * 1000,
> };
>
> static u32 __init armada_38x_get_cpu_freq(void __iomem *sar)
> @@ -79,7 +80,7 @@ static const int armada_38x_cpu_l2_ratios[32][2] __initconst = {
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> - {0, 1}, {0, 1}, {0, 1}, {0, 1},
> + {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> @@ -90,7 +91,7 @@ static const int armada_38x_cpu_ddr_ratios[32][2] __initconst = {
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> - {0, 1}, {0, 1}, {0, 1}, {0, 1},
> + {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: mvebu: add support for 1866MHz variants
@ 2017-05-24 13:48 ` Gregory CLEMENT
0 siblings, 0 replies; 5+ messages in thread
From: Gregory CLEMENT @ 2017-05-24 13:48 UTC (permalink / raw)
To: Ralph Sennhauser
Cc: linux-clk, Andrew Lunn, Michael Turquette, Stephen Boyd, linux-kernel
Hi Ralph,
On mar., mai 23 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
Adding a word about the fact this patch is for the armada 38x SoC in the
title would be nice.
> The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> list of supported CPU frequencies. Also update multiplier and divisor
> for the l2clk and ddrclk.
>
> Noticed by the following warning:
> [ 0.000000] Selected CPU frequency (16) unsupported
I checked your values with the hardware datasheet and they match the
documentation:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> ---
>
> Hi everyone,
>
> This patch was part of a series adding support for the Linksys WRT3200ACM which
> got mostly merged already. So this one comes as a stand-alone patch intended
> for 4.13.
>
> Thanks
> Ralph
> ---
>
> Changes since v1:
>
> - Update multipliers for and divisors for l2clk and ddrclk
> ---
> drivers/clk/mvebu/armada-38x.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/mvebu/armada-38x.c b/drivers/clk/mvebu/armada-38x.c
> index 8bccf4e..394aa6f 100644
> --- a/drivers/clk/mvebu/armada-38x.c
> +++ b/drivers/clk/mvebu/armada-38x.c
> @@ -49,7 +49,8 @@ static const u32 armada_38x_cpu_frequencies[] __initconst = {
> 0, 0, 0, 0,
> 1066 * 1000 * 1000, 0, 0, 0,
> 1332 * 1000 * 1000, 0, 0, 0,
> - 1600 * 1000 * 1000,
> + 1600 * 1000 * 1000, 0, 0, 0,
> + 1866 * 1000 * 1000,
> };
>
> static u32 __init armada_38x_get_cpu_freq(void __iomem *sar)
> @@ -79,7 +80,7 @@ static const int armada_38x_cpu_l2_ratios[32][2] __initconst = {
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> - {0, 1}, {0, 1}, {0, 1}, {0, 1},
> + {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> @@ -90,7 +91,7 @@ static const int armada_38x_cpu_ddr_ratios[32][2] __initconst = {
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {1, 2}, {0, 1}, {0, 1}, {0, 1},
> - {0, 1}, {0, 1}, {0, 1}, {0, 1},
> + {1, 2}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> {0, 1}, {0, 1}, {0, 1}, {0, 1},
> --
> 2.10.2
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: mvebu: add support for 1866MHz variants
2017-05-24 13:48 ` Gregory CLEMENT
(?)
@ 2017-05-24 15:02 ` Ralph Sennhauser
-1 siblings, 0 replies; 5+ messages in thread
From: Ralph Sennhauser @ 2017-05-24 15:02 UTC (permalink / raw)
To: Gregory CLEMENT
Cc: linux-clk, Andrew Lunn, Michael Turquette, Stephen Boyd, linux-kernel
On Wed, 24 May 2017 15:48:50 +0200
Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> Hi Ralph,
>
> On mar., mai 23 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com>
> wrote:
>
> Adding a word about the fact this patch is for the armada 38x SoC in
> the title would be nice.
Agreed.
>
> > The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> > list of supported CPU frequencies. Also update multiplier and
> > divisor for the l2clk and ddrclk.
> >
> > Noticed by the following warning:
> > [ 0.000000] Selected CPU frequency (16) unsupported
>
> I checked your values with the hardware datasheet and they match the
> documentation:
>
> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>
Thanks for checking.
Ralph
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] clk: mvebu: add support for 1866MHz variants
2017-05-23 21:01 [PATCH v2] clk: mvebu: add support for 1866MHz variants Ralph Sennhauser
2017-05-24 13:48 ` Gregory CLEMENT
@ 2017-06-01 7:24 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2017-06-01 7:24 UTC (permalink / raw)
To: Ralph Sennhauser
Cc: linux-clk, Andrew Lunn, Gregory CLEMENT, Michael Turquette, linux-kernel
On 05/23, Ralph Sennhauser wrote:
> The Linksys WRT3200ACM CPU is clocked at 1866MHz. Add 1866MHz to the
> list of supported CPU frequencies. Also update multiplier and divisor
> for the l2clk and ddrclk.
>
> Noticed by the following warning:
> [ 0.000000] Selected CPU frequency (16) unsupported
>
> Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-01 7:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 21:01 [PATCH v2] clk: mvebu: add support for 1866MHz variants Ralph Sennhauser
2017-05-24 13:48 ` Gregory CLEMENT
2017-05-24 13:48 ` Gregory CLEMENT
2017-05-24 15:02 ` Ralph Sennhauser
2017-06-01 7:24 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.