* [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking
@ 2017-05-25 7:25 Chris Wilson
2017-05-25 7:44 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-05-25 13:49 ` [PATCH] " Joonas Lahtinen
0 siblings, 2 replies; 5+ messages in thread
From: Chris Wilson @ 2017-05-25 7:25 UTC (permalink / raw)
To: intel-gfx
As only GGTT vma may be permanently pinned and are always at the head of
the object's vma list, as soon as we seen a ppGTT vma we can stop
searching for any_vma_pinned().
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_shrinker.c b/drivers/gpu/drm/i915/i915_gem_shrinker.c
index 9fe4d0c66549..6dfe66c96081 100644
--- a/drivers/gpu/drm/i915/i915_gem_shrinker.c
+++ b/drivers/gpu/drm/i915/i915_gem_shrinker.c
@@ -66,9 +66,17 @@ static bool any_vma_pinned(struct drm_i915_gem_object *obj)
{
struct i915_vma *vma;
- list_for_each_entry(vma, &obj->vma_list, obj_link)
+ list_for_each_entry(vma, &obj->vma_list, obj_link) {
+ /* Only GGTT vma may be permanently pinned, and are always
+ * at the start of the list. We can stop hunting as soon
+ * as we see a ppGTT vma.
+ */
+ if (!i915_vma_is_ggtt(vma))
+ break;
+
if (i915_vma_is_pinned(vma))
return true;
+ }
return false;
}
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Only GGTT vma may be pinned and prevent shrinking
2017-05-25 7:25 [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking Chris Wilson
@ 2017-05-25 7:44 ` Patchwork
2017-05-25 13:49 ` [PATCH] " Joonas Lahtinen
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-05-25 7:44 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Only GGTT vma may be pinned and prevent shrinking
URL : https://patchwork.freedesktop.org/series/24906/
State : failure
== Summary ==
Series 24906v1 drm/i915: Only GGTT vma may be pinned and prevent shrinking
https://patchwork.freedesktop.org/api/1.0/series/24906/revisions/1/mbox/
Test core_auth:
Subgroup basic-auth:
pass -> INCOMPLETE (fi-skl-6260u)
pass -> INCOMPLETE (fi-skl-6770hq)
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:448s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:435s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:585s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:507s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:489s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:485s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:420s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:410s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:418s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:488s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:464s
fi-kbl-7500u total:278 pass:255 dwarn:5 dfail:0 fail:0 skip:18 time:465s
fi-kbl-7560u total:278 pass:263 dwarn:5 dfail:0 fail:0 skip:10 time:569s
fi-skl-6260u total:278 pass:0 dwarn:0 dfail:0 fail:0 skip:0
fi-skl-6700hq total:278 pass:239 dwarn:0 dfail:1 fail:17 skip:21 time:433s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:464s
fi-skl-6770hq total:278 pass:0 dwarn:0 dfail:0 fail:0 skip:0
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:437s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:536s
fi-snb-2600 total:278 pass:247 dwarn:0 dfail:0 fail:2 skip:29 time:399s
af161db6dba99f58096174c0456f211aab3976ad drm-tip: 2017y-05m-25d-01h-32m-39s UTC integration manifest
574a5a33 drm/i915: Only GGTT vma may be pinned and prevent shrinking
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4805/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking
2017-05-25 7:25 [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking Chris Wilson
2017-05-25 7:44 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-05-25 13:49 ` Joonas Lahtinen
2017-05-25 14:17 ` Chris Wilson
2017-05-26 12:50 ` Chris Wilson
1 sibling, 2 replies; 5+ messages in thread
From: Joonas Lahtinen @ 2017-05-25 13:49 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On to, 2017-05-25 at 08:25 +0100, Chris Wilson wrote:
> As only GGTT vma may be permanently pinned and are always at the head of
> the object's vma list, as soon as we seen a ppGTT vma we can stop
> searching for any_vma_pinned().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Is this in the kerneldoc of the list?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking
2017-05-25 13:49 ` [PATCH] " Joonas Lahtinen
@ 2017-05-25 14:17 ` Chris Wilson
2017-05-26 12:50 ` Chris Wilson
1 sibling, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-05-25 14:17 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
On Thu, May 25, 2017 at 04:49:56PM +0300, Joonas Lahtinen wrote:
> On to, 2017-05-25 at 08:25 +0100, Chris Wilson wrote:
> > As only GGTT vma may be permanently pinned and are always at the head of
> > the object's vma list, as soon as we seen a ppGTT vma we can stop
> > searching for any_vma_pinned().
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Is this in the kerneldoc of the list?
We enforce it in code, not comments. /s
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking
2017-05-25 13:49 ` [PATCH] " Joonas Lahtinen
2017-05-25 14:17 ` Chris Wilson
@ 2017-05-26 12:50 ` Chris Wilson
1 sibling, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-05-26 12:50 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
On Thu, May 25, 2017 at 04:49:56PM +0300, Joonas Lahtinen wrote:
> On to, 2017-05-25 at 08:25 +0100, Chris Wilson wrote:
> > As only GGTT vma may be permanently pinned and are always at the head of
> > the object's vma list, as soon as we seen a ppGTT vma we can stop
> > searching for any_vma_pinned().
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Is this in the kerneldoc of the list?
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Pushed this last night and sent a patch for the kerneldoc, thanks for the
review.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-26 12:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 7:25 [PATCH] drm/i915: Only GGTT vma may be pinned and prevent shrinking Chris Wilson
2017-05-25 7:44 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-05-25 13:49 ` [PATCH] " Joonas Lahtinen
2017-05-25 14:17 ` Chris Wilson
2017-05-26 12:50 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.