All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown
Date: Thu, 25 May 2017 15:04:26 -0300	[thread overview]
Message-ID: <20170525180426.GR32274@thinpad.lan.raisama.net> (raw)
In-Reply-To: <87d1az64ab.fsf@dusky.pond.sub.org>

On Tue, May 23, 2017 at 04:23:08PM +0200, Markus Armbruster wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
> 
> > Keep the Popen object around to we can query its exit code later.
> >
> > To keep the existing 'self._popen is None' checks working, add a
> > is_running() method, that will check if the process is still running.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> 
> Looks harmless enough.  Have you tested the scripts using this module
> still work?

Now I did. :)

I see only two users of qemu.py and qtest.py:

  tests/migration/guestperf/engine.py:import qemu
  tests/qemu-iotests/iotests.py:import qtest

I just tested both using:

  $ make check-tests/qemu-iotests-quick.sh
  $ make tests/migration/initrd-stress.img PTHREAD_LIB=-pthread
  $ ./tests/migration/guestperf.py > /tmp/guestperf.json

and they seem to be working.

(It looks like there's no Makefile rule to run guestperf.py)

BTW, it seems to be impossible to build initrd-stress.img on a out-of-tree
build.  I had to run ./configure inside the source tree to be able to run
guestperf.py.

-- 
Eduardo

  reply	other threads:[~2017-05-25 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-13  3:33 [Qemu-devel] [PATCH v2 0/3] script for crash-testing -device Eduardo Habkost
2017-05-13  3:33 ` [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown Eduardo Habkost
2017-05-23 14:23   ` Markus Armbruster
2017-05-25 18:04     ` Eduardo Habkost [this message]
2017-05-29 11:40       ` Markus Armbruster
2017-05-13  3:33 ` [Qemu-devel] [PATCH v2 2/3] qemu.py: Add QEMUMachine.exitcode() method Eduardo Habkost
2017-05-13  3:33 ` [Qemu-devel] [PATCH v2 3/3] scripts: Test script to look for -device crashes Eduardo Habkost
2017-05-23 14:52   ` Markus Armbruster
2017-05-24 16:39     ` Eduardo Habkost
2017-05-29  9:25       ` Markus Armbruster
2017-05-31 17:41         ` Eduardo Habkost
2017-05-13  4:05 ` [Qemu-devel] [PATCH v2 0/3] script for crash-testing -device no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170525180426.GR32274@thinpad.lan.raisama.net \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=marcel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.