[PATCH] [media] atomisp: disable several warnings when W=1

[PATCH] [media] atomisp: disable several warnings when W=1

[Mauro Carvalho Chehab]

The atomisp currently produce hundreds of warnings when W=1.

It is a known fact that this driver is currently in bad
shape, and there are lot of things to be done here.

We don't want to be bothered by those "minor" stuff for now,
while the driver doesn't receive a major cleanup. So,
disable those warnings.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/staging/media/atomisp/i2c/Makefile          | 4 ++++
 drivers/staging/media/atomisp/i2c/imx/Makefile      | 5 +++++
 drivers/staging/media/atomisp/i2c/ov5693/Makefile   | 5 +++++
 drivers/staging/media/atomisp/pci/atomisp2/Makefile | 5 +++++
 4 files changed, 19 insertions(+)

diff --git a/drivers/staging/media/atomisp/i2c/Makefile b/drivers/staging/media/atomisp/i2c/Makefile
index 466517c7c8e6..a1afca6ec31f 100644
--- a/drivers/staging/media/atomisp/i2c/Makefile
+++ b/drivers/staging/media/atomisp/i2c/Makefile
@@ -19,3 +19,7 @@ obj-$(CONFIG_VIDEO_AP1302)     += ap1302.o
 
 obj-$(CONFIG_VIDEO_LM3554) += lm3554.o
 
+# HACK! While this driver is in bad shape, don't enable several warnings
+#       that would be otherwise enabled with W=1
+ccflags-y += -Wno-unused-but-set-variable -Wno-missing-prototypes \
+	     -Wno-unused-const-variable -Wno-missing-declarations
diff --git a/drivers/staging/media/atomisp/i2c/imx/Makefile b/drivers/staging/media/atomisp/i2c/imx/Makefile
index 6b13a3a66e49..0eceb7374bec 100644
--- a/drivers/staging/media/atomisp/i2c/imx/Makefile
+++ b/drivers/staging/media/atomisp/i2c/imx/Makefile
@@ -4,3 +4,8 @@ imx1x5-objs := imx.o drv201.o ad5816g.o dw9714.o dw9719.o dw9718.o vcm.o otp.o o
 
 ov8858_driver-objs := ../ov8858.o dw9718.o vcm.o
 obj-$(CONFIG_VIDEO_OV8858)     += ov8858_driver.o
+
+# HACK! While this driver is in bad shape, don't enable several warnings
+#       that would be otherwise enabled with W=1
+ccflags-y += -Wno-unused-but-set-variable -Wno-missing-prototypes \
+             -Wno-unused-const-variable -Wno-missing-declarations
diff --git a/drivers/staging/media/atomisp/i2c/ov5693/Makefile b/drivers/staging/media/atomisp/i2c/ov5693/Makefile
index c9c0e1245858..fd2ef2e3c31e 100644
--- a/drivers/staging/media/atomisp/i2c/ov5693/Makefile
+++ b/drivers/staging/media/atomisp/i2c/ov5693/Makefile
@@ -1 +1,6 @@
 obj-$(CONFIG_VIDEO_OV5693) += ov5693.o
+
+# HACK! While this driver is in bad shape, don't enable several warnings
+#       that would be otherwise enabled with W=1
+ccflags-y += -Wno-unused-but-set-variable -Wno-missing-prototypes \
+             -Wno-unused-const-variable -Wno-missing-declarations
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/Makefile b/drivers/staging/media/atomisp/pci/atomisp2/Makefile
index f126a89a08e9..8ccb5f29f2c1 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/Makefile
+++ b/drivers/staging/media/atomisp/pci/atomisp2/Makefile
@@ -353,3 +353,8 @@ DEFINES += -DSYSTEM_hive_isp_css_2400_system -DISP2400
 
 ccflags-y += $(INCLUDES) $(DEFINES) -fno-common
 
+# HACK! While this driver is in bad shape, don't enable several warnings
+#       that would be otherwise enabled with W=1
+ccflags-y += -Wno-unused-const-variable -Wno-missing-prototypes \
+	     -Wno-unused-but-set-variable -Wno-missing-declarations \
+	     -Wno-suggest-attribute=format -Wno-missing-prototypes
-- 
2.9.3

Re: [PATCH] [media] atomisp: disable several warnings when W=1

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]

Hi Mauro,

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20170525]
[cannot apply to v4.12-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/atomisp-disable-several-warnings-when-W-1/20170522-051410
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-s1-05252345 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c: In function 'atomisp_release':
   drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:898: warning: 'pipe' may be used uninitialized in this function
   drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:899: warning: 'acc_pipe' may be used uninitialized in this function
   At top level:
>> cc1: warning: unrecognized command line option "-Wno-suggest-attribute=format"
>> cc1: warning: unrecognized command line option "-Wno-unused-but-set-variable"
>> cc1: warning: unrecognized command line option "-Wno-unused-const-variable"
--
   drivers/staging/media//atomisp/pci/atomisp2/atomisp_fops.c: In function 'atomisp_release':
   drivers/staging/media//atomisp/pci/atomisp2/atomisp_fops.c:898: warning: 'pipe' may be used uninitialized in this function
   drivers/staging/media//atomisp/pci/atomisp2/atomisp_fops.c:899: warning: 'acc_pipe' may be used uninitialized in this function
   At top level:
>> cc1: warning: unrecognized command line option "-Wno-suggest-attribute=format"
>> cc1: warning: unrecognized command line option "-Wno-unused-but-set-variable"
>> cc1: warning: unrecognized command line option "-Wno-unused-const-variable"

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26633 bytes --]

Re: [PATCH] [media] atomisp: disable several warnings when W=1

[Arnd Bergmann]

On Thu, May 25, 2017 at 7:03 PM, kbuild test robot <lkp@intel.com> wrote:

>>> cc1: warning: unrecognized command line option "-Wno-suggest-attribute=format"
>>> cc1: warning: unrecognized command line option "-Wno-unused-but-set-variable"
>>> cc1: warning: unrecognized command line option "-Wno-unused-const-variable"

Ah right, these need to use "$(cc-disable-warning)" in the Makefile. I
also missed
this when I looked at the original patch/

        Arnd