* [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
@ 2017-05-27 19:22 Oleg Drokin
2017-05-27 20:26 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Oleg Drokin @ 2017-05-27 19:22 UTC (permalink / raw)
To: linux-stable
lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
lov_user_md pointer from user- or kernel-space. This changes the
behavior of copy_from_user() on SPARC and may result in a misaligned
access exception which in turn oopses the kernel. In fact the
relevant argument to lov_getstripe() is never called with a
kernel-space pointer and so changing the address limits is unnecessary
and so we remove the calls to save, set, and restore the address
limits.
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Reviewed-on: http://review.whamcloud.com/6150
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Li Wei <wei.g.li@intel.com>
CC: linux-stable <stable@vger.kernel.org> # >= v3.11
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 2e1bd47..e6727ce 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
@@ -293,18 +293,10 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm,
size_t lmmk_size;
size_t lum_size;
int rc;
- mm_segment_t seg;
if (!lsm)
return -ENODATA;
- /*
- * "Switch to kernel segment" to allow copying from kernel space by
- * copy_{to,from}_user().
- */
- seg = get_fs();
- set_fs(KERNEL_DS);
-
if (lsm->lsm_magic != LOV_MAGIC_V1 && lsm->lsm_magic != LOV_MAGIC_V3) {
CERROR("bad LSM MAGIC: 0x%08X != 0x%08X nor 0x%08X\n",
lsm->lsm_magic, LOV_MAGIC_V1, LOV_MAGIC_V3);
@@ -406,6 +398,5 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm,
out_free:
kvfree(lmmk);
out:
- set_fs(seg);
return rc;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
2017-05-27 19:22 [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe() Oleg Drokin
@ 2017-05-27 20:26 ` Greg KH
2017-05-27 22:38 ` Oleg Drokin
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2017-05-27 20:26 UTC (permalink / raw)
To: Oleg Drokin; +Cc: linux-stable
On Sat, May 27, 2017 at 03:22:18PM -0400, Oleg Drokin wrote:
> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
> lov_user_md pointer from user- or kernel-space. This changes the
> behavior of copy_from_user() on SPARC and may result in a misaligned
> access exception which in turn oopses the kernel. In fact the
> relevant argument to lov_getstripe() is never called with a
> kernel-space pointer and so changing the address limits is unnecessary
> and so we remove the calls to save, set, and restore the address
> limits.
>
> Signed-off-by: John L. Hammond <john.hammond@intel.com>
> Reviewed-on: http://review.whamcloud.com/6150
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> Reviewed-by: Li Wei <wei.g.li@intel.com>
> CC: linux-stable <stable@vger.kernel.org> # >= v3.11
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
> 1 file changed, 9 deletions(-)
What was the git commit id of this patch in Linus's tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
2017-05-27 20:26 ` Greg KH
@ 2017-05-27 22:38 ` Oleg Drokin
2017-05-28 5:29 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Oleg Drokin @ 2017-05-27 22:38 UTC (permalink / raw)
To: Greg KH; +Cc: linux-stable
On May 27, 2017, at 4:26 PM, Greg KH wrote:
> On Sat, May 27, 2017 at 03:22:18PM -0400, Oleg Drokin wrote:
>> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
>> lov_user_md pointer from user- or kernel-space. This changes the
>> behavior of copy_from_user() on SPARC and may result in a misaligned
>> access exception which in turn oopses the kernel. In fact the
>> relevant argument to lov_getstripe() is never called with a
>> kernel-space pointer and so changing the address limits is unnecessary
>> and so we remove the calls to save, set, and restore the address
>> limits.
>>
>> Signed-off-by: John L. Hammond <john.hammond@intel.com>
>> Reviewed-on: http://review.whamcloud.com/6150
>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
>> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
>> Reviewed-by: Li Wei <wei.g.li@intel.com>
>> CC: linux-stable <stable@vger.kernel.org> # >= v3.11
>> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
>> ---
>> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
>> 1 file changed, 9 deletions(-)
>
> What was the git commit id of this patch in Linus's tree?
It's not in Linus tree yet.
I was just informed that this patch should go to stable by Al, so I added stable
to the list.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
2017-05-27 22:38 ` Oleg Drokin
@ 2017-05-28 5:29 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2017-05-28 5:29 UTC (permalink / raw)
To: Oleg Drokin; +Cc: linux-stable
On Sat, May 27, 2017 at 06:38:06PM -0400, Oleg Drokin wrote:
>
> On May 27, 2017, at 4:26 PM, Greg KH wrote:
>
> > On Sat, May 27, 2017 at 03:22:18PM -0400, Oleg Drokin wrote:
> >> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
> >> lov_user_md pointer from user- or kernel-space. This changes the
> >> behavior of copy_from_user() on SPARC and may result in a misaligned
> >> access exception which in turn oopses the kernel. In fact the
> >> relevant argument to lov_getstripe() is never called with a
> >> kernel-space pointer and so changing the address limits is unnecessary
> >> and so we remove the calls to save, set, and restore the address
> >> limits.
> >>
> >> Signed-off-by: John L. Hammond <john.hammond@intel.com>
> >> Reviewed-on: http://review.whamcloud.com/6150
> >> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
> >> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> >> Reviewed-by: Li Wei <wei.g.li@intel.com>
> >> CC: linux-stable <stable@vger.kernel.org> # >= v3.11
> >> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> >> ---
> >> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
> >> 1 file changed, 9 deletions(-)
> >
> > What was the git commit id of this patch in Linus's tree?
>
> It's not in Linus tree yet.
> I was just informed that this patch should go to stable by Al, so I added stable
> to the list.
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
2017-05-29 14:28 ` Greg Kroah-Hartman
@ 2017-05-29 15:55 ` Oleg Drokin
0 siblings, 0 replies; 7+ messages in thread
From: Oleg Drokin @ 2017-05-29 15:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: devel, Andreas Dilger, James Simmons, Al Viro,
Linux Kernel Mailing List, Lustre Development List,
John L . Hammond
On May 29, 2017, at 10:28 AM, Greg Kroah-Hartman wrote:
> On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote:
>> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
>> lov_user_md pointer from user- or kernel-space. This changes the
>> behavior of copy_from_user() on SPARC and may result in a misaligned
>> access exception which in turn oopses the kernel. In fact the
>> relevant argument to lov_getstripe() is never called with a
>> kernel-space pointer and so changing the address limits is unnecessary
>> and so we remove the calls to save, set, and restore the address
>> limits.
>>
>> Signed-off-by: John L. Hammond <john.hammond@intel.com>
>> Reviewed-on: http://review.whamcloud.com/6150
>> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
>> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
>> Reviewed-by: Li Wei <wei.g.li@intel.com>
>> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
>> ---
>> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
>> 1 file changed, 9 deletions(-)
>
> So is this the patch that you want applied to the staging tree(s) as
> well? If so, please let me know, otherwise I have no clue…
Yes, this is it.
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
2017-05-27 3:40 Oleg Drokin
@ 2017-05-29 14:28 ` Greg Kroah-Hartman
2017-05-29 15:55 ` Oleg Drokin
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2017-05-29 14:28 UTC (permalink / raw)
To: Oleg Drokin
Cc: devel, Andreas Dilger, James Simmons, Al Viro,
Linux Kernel Mailing List, Lustre Development List,
John L . Hammond
On Fri, May 26, 2017 at 11:40:33PM -0400, Oleg Drokin wrote:
> lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
> lov_user_md pointer from user- or kernel-space. This changes the
> behavior of copy_from_user() on SPARC and may result in a misaligned
> access exception which in turn oopses the kernel. In fact the
> relevant argument to lov_getstripe() is never called with a
> kernel-space pointer and so changing the address limits is unnecessary
> and so we remove the calls to save, set, and restore the address
> limits.
>
> Signed-off-by: John L. Hammond <john.hammond@intel.com>
> Reviewed-on: http://review.whamcloud.com/6150
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> Reviewed-by: Li Wei <wei.g.li@intel.com>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
> 1 file changed, 9 deletions(-)
So is this the patch that you want applied to the staging tree(s) as
well? If so, please let me know, otherwise I have no clue...
Come on, you know better than this...
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe()
@ 2017-05-27 3:40 Oleg Drokin
2017-05-29 14:28 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Oleg Drokin @ 2017-05-27 3:40 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, Andreas Dilger, James Simmons, Al Viro
Cc: Linux Kernel Mailing List, Lustre Development List, Oleg Drokin,
John L . Hammond
lov_getstripe() calls set_fs(KERNEL_DS) so that it can handle a struct
lov_user_md pointer from user- or kernel-space. This changes the
behavior of copy_from_user() on SPARC and may result in a misaligned
access exception which in turn oopses the kernel. In fact the
relevant argument to lov_getstripe() is never called with a
kernel-space pointer and so changing the address limits is unnecessary
and so we remove the calls to save, set, and restore the address
limits.
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Reviewed-on: http://review.whamcloud.com/6150
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3221
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Li Wei <wei.g.li@intel.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
---
drivers/staging/lustre/lustre/lov/lov_pack.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
index 2e1bd47..e6727ce 100644
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c
@@ -293,18 +293,10 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm,
size_t lmmk_size;
size_t lum_size;
int rc;
- mm_segment_t seg;
if (!lsm)
return -ENODATA;
- /*
- * "Switch to kernel segment" to allow copying from kernel space by
- * copy_{to,from}_user().
- */
- seg = get_fs();
- set_fs(KERNEL_DS);
-
if (lsm->lsm_magic != LOV_MAGIC_V1 && lsm->lsm_magic != LOV_MAGIC_V3) {
CERROR("bad LSM MAGIC: 0x%08X != 0x%08X nor 0x%08X\n",
lsm->lsm_magic, LOV_MAGIC_V1, LOV_MAGIC_V3);
@@ -406,6 +398,5 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm,
out_free:
kvfree(lmmk);
out:
- set_fs(seg);
return rc;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-05-29 15:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-27 19:22 [PATCH] staging/lustre/lov: remove set_fs() call from lov_getstripe() Oleg Drokin
2017-05-27 20:26 ` Greg KH
2017-05-27 22:38 ` Oleg Drokin
2017-05-28 5:29 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-05-27 3:40 Oleg Drokin
2017-05-29 14:28 ` Greg Kroah-Hartman
2017-05-29 15:55 ` Oleg Drokin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.