All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Borislav Petkov <bp@suse.de>,
	Tony Luck <tony.luck@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list
Date: Sun, 28 May 2017 19:22:09 +0200	[thread overview]
Message-ID: <20170528172209.vgoux4bznrapiikl@pd.tnic> (raw)
In-Reply-To: <1495658507-7413-2-git-send-email-Yazen.Ghannam@amd.com>

On Wed, May 24, 2017 at 03:41:46PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> There needs to be a list_head outside of a linked list in order to iterate
> over it and have access to all its elements. This is because the
> list_for_each* macros iterate starting from head->next rather than head.
> 
> Define a list_head for the threshold blocks list in struct threshold_bank

struct threshold_block {

	...

        struct list_head miscj;                 /*
                                                 * List of threshold blocks
                                                 * within a bank.
                                                 */

There's your list_head right there.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Borislav Petkov <bp@suse.de>,
	Tony Luck <tony.luck@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list
Date: Sun, 28 May 2017 19:22:09 +0200	[thread overview]
Message-ID: <20170528172209.vgoux4bznrapiikl@pd.tnic> (raw)

On Wed, May 24, 2017 at 03:41:46PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
> 
> There needs to be a list_head outside of a linked list in order to iterate
> over it and have access to all its elements. This is because the
> list_for_each* macros iterate starting from head->next rather than head.
> 
> Define a list_head for the threshold blocks list in struct threshold_bank

struct threshold_block {

	...

        struct list_head miscj;                 /*
                                                 * List of threshold blocks
                                                 * within a bank.
                                                 */

There's your list_head right there.

  reply	other threads:[~2017-05-28 17:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 20:41 [PATCH 1/3] x86/mce/AMD: Use msr_stat when clearing MCA_STATUS Yazen Ghannam
2017-05-24 20:41 ` [1/3] " Yazen Ghannam
2017-05-24 20:41 ` [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list Yazen Ghannam
2017-05-24 20:41   ` [2/3] " Yazen Ghannam
2017-05-28 17:22   ` Borislav Petkov [this message]
2017-05-28 17:22     ` Borislav Petkov
2017-05-30 12:39     ` [PATCH 2/3] " Ghannam, Yazen
2017-05-30 12:39       ` [2/3] " Yazen Ghannam
2017-05-30 13:56       ` [PATCH 2/3] " Borislav Petkov
2017-05-30 13:56         ` [2/3] " Borislav Petkov
2017-05-30 14:06         ` [PATCH 2/3] " Ghannam, Yazen
2017-05-30 14:06           ` [2/3] " Yazen Ghannam
2017-05-30 14:10           ` [PATCH 2/3] " Borislav Petkov
2017-05-30 14:10             ` [2/3] " Borislav Petkov
2017-05-24 20:41 ` [PATCH 3/3] x86/mce/AMD: Use saved threshold block info in interrupt handler Yazen Ghannam
2017-05-24 20:41   ` [3/3] " Yazen Ghannam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170528172209.vgoux4bznrapiikl@pd.tnic \
    --to=bp@alien8.de \
    --cc=Yazen.Ghannam@amd.com \
    --cc=bp@suse.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.