* [PATCH] gpiolib: remove unused variable
@ 2017-05-30 9:21 Arnd Bergmann
2017-05-30 10:07 ` Andy Shevchenko
2017-05-30 23:57 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-30 9:21 UTC (permalink / raw)
To: Linus Walleij
Cc: Arnd Bergmann, Lars-Peter Clausen, Andy Shevchenko, linux-gpio,
linux-kernel
This was left behind by a cleanup patch:
drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-Werror=unused-variable]
Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded loop")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/gpiolib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const char *name)
static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
{
- int i;
-
if (!gpiochip->irq_need_valid_mask)
return 0;
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: remove unused variable
2017-05-30 9:21 [PATCH] gpiolib: remove unused variable Arnd Bergmann
@ 2017-05-30 10:07 ` Andy Shevchenko
2017-05-30 23:57 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-05-30 10:07 UTC (permalink / raw)
To: Arnd Bergmann, Linus Walleij; +Cc: Lars-Peter Clausen, linux-gpio, linux-kernel
On Tue, 2017-05-30 at 11:21 +0200, Arnd Bergmann wrote:
> This was left behind by a cleanup patch:
>
> drivers/gpio/gpiolib.c: In function
> 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-
> Werror=unused-variable]
Right, thanks for it!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open
> coded loop")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpio/gpiolib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index be8097097326..62ffb4e293d2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1471,8 +1471,6 @@ static struct gpio_chip *find_chip_by_name(const
> char *name)
>
> static int gpiochip_irqchip_init_valid_mask(struct gpio_chip
> *gpiochip)
> {
> - int i;
> -
> if (!gpiochip->irq_need_valid_mask)
> return 0;
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpiolib: remove unused variable
2017-05-30 9:21 [PATCH] gpiolib: remove unused variable Arnd Bergmann
2017-05-30 10:07 ` Andy Shevchenko
@ 2017-05-30 23:57 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-05-30 23:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Lars-Peter Clausen, Andy Shevchenko, linux-gpio, linux-kernel
On Tue, May 30, 2017 at 11:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> This was left behind by a cleanup patch:
>
> drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask':
> drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-Werror=unused-variable]
>
> Fixes: 923a654c186c ("gpiolib: Re-use bitmap_fill() instead of open coded loop")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-30 23:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 9:21 [PATCH] gpiolib: remove unused variable Arnd Bergmann
2017-05-30 10:07 ` Andy Shevchenko
2017-05-30 23:57 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.