All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme/pci: Remove watchdog timer
Date: Tue, 30 May 2017 10:20:57 -0400	[thread overview]
Message-ID: <20170530142057.GA2845@localhost.localdomain> (raw)
In-Reply-To: <20170528094152.GB14199@lst.de>

On Sun, May 28, 2017@11:41:52AM +0200, Christoph Hellwig wrote:
> 
> Otherwise this looks good to me, but I'd like to defer it until
> we have the multiple reset issue sorted out, to avoid conflicts.

That's okay to defer till after that settles. I'll need to respin this
anyway since I mistakely re-read CSTS instead of reading it once.

I am hoping to get this in this round since it would quiet a lot of
errors I'm frequently pinged on: a non-posted request during a hotremove
downstream a switch creates a lot of problems for hardware if you don't
have DPC enabled.

One thing I'm just realizing, though, this will break subsystem reset.
We were depending on the watchdog to detect that event, but now we require
an IO timeout. It's easy enough to fix that from the host initiating
the NSSR, but there's no way to notify other hosts connected to the
same subsystem.

Despite that, I still think this patch is still a step in the right
direction for previously mentioned reasons.

  reply	other threads:[~2017-05-30 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 12:16 [PATCH] nvme/pci: Remove watchdog timer Keith Busch
2017-05-28  9:41 ` Christoph Hellwig
2017-05-30 14:20   ` Keith Busch [this message]
2017-06-01 12:50     ` Christoph Hellwig
2017-06-01 13:13       ` Keith Busch
2017-06-05  8:19         ` Christoph Hellwig
2017-05-30 11:53 ` Sagi Grimberg
2017-05-31 16:21   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530142057.GA2845@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.