From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme/pci: Remove watchdog timer
Date: Tue, 30 May 2017 14:53:28 +0300 [thread overview]
Message-ID: <6eb8ac59-cb3f-d0eb-f6cb-fb232e30957c@grimberg.me> (raw)
In-Reply-To: <1495800988-27311-1-git-send-email-keith.busch@intel.com>
> static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
> {
> struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
> @@ -957,6 +1001,17 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
> struct nvme_dev *dev = nvmeq->dev;
> struct request *abort_req;
> struct nvme_command cmd;
> + u32 csts = readl(dev->bar + NVME_REG_CSTS);
> +
> + /*
> + * Reset immediately if the controller is failed
> + */
> + if (nvme_should_reset(dev, readl(dev->bar + NVME_REG_CSTS))) {
> + nvme_warn_reset(dev, csts);
> + nvme_dev_disable(dev, false);
Why the nvme_dev_disable here? its going to happen in reset_work..
Other then that this change looks good!
next prev parent reply other threads:[~2017-05-30 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 12:16 [PATCH] nvme/pci: Remove watchdog timer Keith Busch
2017-05-28 9:41 ` Christoph Hellwig
2017-05-30 14:20 ` Keith Busch
2017-06-01 12:50 ` Christoph Hellwig
2017-06-01 13:13 ` Keith Busch
2017-06-05 8:19 ` Christoph Hellwig
2017-05-30 11:53 ` Sagi Grimberg [this message]
2017-05-31 16:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb8ac59-cb3f-d0eb-f6cb-fb232e30957c@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.