From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL v2 1/5] target/sh4: log unauthorized accesses using qemu_log_mask
Date: Tue, 30 May 2017 21:15:49 +0200 [thread overview]
Message-ID: <20170530191553.31500-2-aurelien@aurel32.net> (raw)
In-Reply-To: <20170530191553.31500-1-aurelien@aurel32.net>
qemu_log_mask() is preferred over fprintf() for logging errors.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
target/sh4/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sh4/helper.c b/target/sh4/helper.c
index 8f8ce81401..4c024f9529 100644
--- a/target/sh4/helper.c
+++ b/target/sh4/helper.c
@@ -420,7 +420,7 @@ static int get_physical_address(CPUSH4State * env, target_ulong * physical,
if (!(env->sr & (1u << SR_MD))
&& (address < 0xe0000000 || address >= 0xe4000000)) {
/* Unauthorized access in user mode (only store queues are available) */
- fprintf(stderr, "Unauthorized access\n");
+ qemu_log_mask(LOG_GUEST_ERROR, "Unauthorized access\n");
if (rw == 0)
return MMU_DADDR_ERROR_READ;
else if (rw == 1)
--
2.11.0
next prev parent reply other threads:[~2017-05-30 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 19:15 [Qemu-devel] [PULL v2 0/5] Queued target/sh4 patches Aurelien Jarno
2017-05-30 19:15 ` Aurelien Jarno [this message]
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 2/5] target/sh4: fix reset when using a kernel and an initrd Aurelien Jarno
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 3/5] target/sh4: introduce DELAY_SLOT_MASK Aurelien Jarno
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 4/5] target/sh4: ignore interrupts in a delay slot Aurelien Jarno
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 5/5] target/sh4: fix RTE instruction " Aurelien Jarno
2017-06-01 14:01 ` [Qemu-devel] [PULL v2 0/5] Queued target/sh4 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530191553.31500-2-aurelien@aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.