All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL v2 4/5] target/sh4: ignore interrupts in a delay slot
Date: Tue, 30 May 2017 21:15:52 +0200	[thread overview]
Message-ID: <20170530191553.31500-5-aurelien@aurel32.net> (raw)
In-Reply-To: <20170530191553.31500-1-aurelien@aurel32.net>

Delay slots are indivisible, therefore avoid scheduling an interrupt in
the delay slot. However exceptions are possible.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 target/sh4/helper.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/target/sh4/helper.c b/target/sh4/helper.c
index 5785d6d22a..28d93c2543 100644
--- a/target/sh4/helper.c
+++ b/target/sh4/helper.c
@@ -871,8 +871,16 @@ int cpu_sh4_is_cached(CPUSH4State * env, target_ulong addr)
 bool superh_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
 {
     if (interrupt_request & CPU_INTERRUPT_HARD) {
-        superh_cpu_do_interrupt(cs);
-        return true;
+        SuperHCPU *cpu = SUPERH_CPU(cs);
+        CPUSH4State *env = &cpu->env;
+
+        /* Delay slots are indivisible, ignore interrupts */
+        if (env->flags & DELAY_SLOT_MASK) {
+            return false;
+        } else {
+            superh_cpu_do_interrupt(cs);
+            return true;
+        }
     }
     return false;
 }
-- 
2.11.0

  parent reply	other threads:[~2017-05-30 19:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 19:15 [Qemu-devel] [PULL v2 0/5] Queued target/sh4 patches Aurelien Jarno
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 1/5] target/sh4: log unauthorized accesses using qemu_log_mask Aurelien Jarno
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 2/5] target/sh4: fix reset when using a kernel and an initrd Aurelien Jarno
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 3/5] target/sh4: introduce DELAY_SLOT_MASK Aurelien Jarno
2017-05-30 19:15 ` Aurelien Jarno [this message]
2017-05-30 19:15 ` [Qemu-devel] [PULL v2 5/5] target/sh4: fix RTE instruction delay slot Aurelien Jarno
2017-06-01 14:01 ` [Qemu-devel] [PULL v2 0/5] Queued target/sh4 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530191553.31500-5-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.