[PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[Michael Kelley]

Add direct #include statements for declarations of csum_tcpudp_magic()
and csum_ipv6_magic(). While the needed #include's are picked up
indirectly for the x86 architecture, they aren't on other
architectures, resulting in compile errors.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
 drivers/net/hyperv/netvsc_drv.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 4421a6d..ca952b3 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -37,6 +37,8 @@
 #include <net/route.h>
 #include <net/sock.h>
 #include <net/pkt_sched.h>
+#include <asm/checksum.h>
+#include <net/ip6_checksum.h>
 
 #include "hyperv_net.h"
 
-- 
1.7.1

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[Joe Perches]

On Tue, 2017-05-30 at 10:43 -0700, Michael Kelley wrote:
> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
[]
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4421a6d..ca952b3 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -37,6 +37,8 @@
>  #include <net/route.h>
>  #include <net/sock.h>
>  #include <net/pkt_sched.h>
> +#include <asm/checksum.h>

Maybe
#include <net/checksum.h>
instead?

> +#include <net/ip6_checksum.h>
>  
>  #include "hyperv_net.h"
>  

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[David Miller]

From: Michael Kelley <mikelley@microsoft.com>
Date: Tue, 30 May 2017 10:43:04 -0700

> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
> 
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>

Applied, thank you.

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[David Miller]

From: Michael Kelley <mikelley@microsoft.com>
Date: Tue, 30 May 2017 10:43:04 -0700

> Add direct #include statements for declarations of csum_tcpudp_magic()
> and csum_ipv6_magic(). While the needed #include's are picked up
> indirectly for the x86 architecture, they aren't on other
> architectures, resulting in compile errors.
> 
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>

Applied, thank you.

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[Joe Perches]

On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote:
> From: Michael Kelley <mikelley@microsoft.com>
> Date: Tue, 30 May 2017 10:43:04 -0700
> 
> > Add direct #include statements for declarations of csum_tcpudp_magic()
> > and csum_ipv6_magic(). While the needed #include's are picked up
> > indirectly for the x86 architecture, they aren't on other
> > architectures, resulting in compile errors.
> > 
> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
> 
> Applied, thank you.

Did you apply this one or the v2?

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[David Miller]

From: Joe Perches <joe@perches.com>
Date: Wed, 31 May 2017 15:59:31 -0700

> On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote:
>> From: Michael Kelley <mikelley@microsoft.com>
>> Date: Tue, 30 May 2017 10:43:04 -0700
>> 
>> > Add direct #include statements for declarations of csum_tcpudp_magic()
>> > and csum_ipv6_magic(). While the needed #include's are picked up
>> > indirectly for the x86 architecture, they aren't on other
>> > architectures, resulting in compile errors.
>> > 
>> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
>> 
>> Applied, thank you.
> 
> Did you apply this one or the v2?

I got v2 which used net/checksum.h et al.

Re: [PATCH net-next 1/1] netvsc: Add #include's for csum_* function declarations

[David Miller]

From: Joe Perches <joe@perches.com>
Date: Wed, 31 May 2017 15:59:31 -0700

> On Wed, 2017-05-31 at 13:59 -0400, David Miller wrote:
>> From: Michael Kelley <mikelley@microsoft.com>
>> Date: Tue, 30 May 2017 10:43:04 -0700
>> 
>> > Add direct #include statements for declarations of csum_tcpudp_magic()
>> > and csum_ipv6_magic(). While the needed #include's are picked up
>> > indirectly for the x86 architecture, they aren't on other
>> > architectures, resulting in compile errors.
>> > 
>> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
>> 
>> Applied, thank you.
> 
> Did you apply this one or the v2?

I got v2 which used net/checksum.h et al.