From: Christoph Hellwig <hch@lst.de>
To: David Howells <dhowells@redhat.com>
Cc: linux-raid@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-nvdimm@lists.01.org, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Amir Goldstein <amir73il@gmail.com>,
linux-kernel@vger.kernel.org,
Steven Whitehouse <swhiteho@redhat.com>,
linux-xfs@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Shaohua Li <shli@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
Date: Wed, 31 May 2017 11:41:57 +0200 [thread overview]
Message-ID: <20170531094157.GA10511@lst.de> (raw)
In-Reply-To: <9377.1496138404@warthog.procyon.org.uk>
On Tue, May 30, 2017 at 11:00:04AM +0100, David Howells wrote:
> This isn't going to work. You've effectively changed the types of the fields
> in the UUID struct from BE to CPU-endian, but you're still calling
> generate_random_uuid(), which produces a BE UUID. You need to leave the
> struct members as __beXX or stop using the core UUID routines.
>
> Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
> afs_uuid. You can then leave the (un)marshalling code alone.
That's one option. The other option would be to revert
"afs: Use core kernel UUID generation", as that also changed the
v1 UUID to a v4 uuid. Does the afs protocol require a v1 uuid
or does it just use the formwat on the wire?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Mimi Zohar
<zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
Amir Goldstein <amir73il-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steven Whitehouse
<swhiteho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Shaohua Li <shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
Date: Wed, 31 May 2017 11:41:57 +0200 [thread overview]
Message-ID: <20170531094157.GA10511@lst.de> (raw)
In-Reply-To: <9377.1496138404-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
On Tue, May 30, 2017 at 11:00:04AM +0100, David Howells wrote:
> This isn't going to work. You've effectively changed the types of the fields
> in the UUID struct from BE to CPU-endian, but you're still calling
> generate_random_uuid(), which produces a BE UUID. You need to leave the
> struct members as __beXX or stop using the core UUID routines.
>
> Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
> afs_uuid. You can then leave the (un)marshalling code alone.
That's one option. The other option would be to revert
"afs: Use core kernel UUID generation", as that also changed the
v1 UUID to a v4 uuid. Does the afs protocol require a v1 uuid
or does it just use the formwat on the wire?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
Date: Wed, 31 May 2017 11:41:57 +0200 [thread overview]
Message-ID: <20170531094157.GA10511@lst.de> (raw)
In-Reply-To: <9377.1496138404@warthog.procyon.org.uk>
On Tue, May 30, 2017 at 11:00:04AM +0100, David Howells wrote:
> This isn't going to work. You've effectively changed the types of the fields
> in the UUID struct from BE to CPU-endian, but you're still calling
> generate_random_uuid(), which produces a BE UUID. You need to leave the
> struct members as __beXX or stop using the core UUID routines.
>
> Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
> afs_uuid. You can then leave the (un)marshalling code alone.
That's one option. The other option would be to revert
"afs: Use core kernel UUID generation", as that also changed the
v1 UUID to a v4 uuid. Does the afs protocol require a v1 uuid
or does it just use the formwat on the wire?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org, Shaohua Li <shli@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-xfs@vger.kernel.org, linux-raid@vger.kernel.org,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
Date: Wed, 31 May 2017 11:41:57 +0200 [thread overview]
Message-ID: <20170531094157.GA10511@lst.de> (raw)
In-Reply-To: <9377.1496138404@warthog.procyon.org.uk>
On Tue, May 30, 2017 at 11:00:04AM +0100, David Howells wrote:
> This isn't going to work. You've effectively changed the types of the fields
> in the UUID struct from BE to CPU-endian, but you're still calling
> generate_random_uuid(), which produces a BE UUID. You need to leave the
> struct members as __beXX or stop using the core UUID routines.
>
> Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
> afs_uuid. You can then leave the (un)marshalling code alone.
That's one option. The other option would be to revert
"afs: Use core kernel UUID generation", as that also changed the
v1 UUID to a v4 uuid. Does the afs protocol require a v1 uuid
or does it just use the formwat on the wire?
next prev parent reply other threads:[~2017-05-31 9:41 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 10:19 cleanup UUID types V5 Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 02/22] xfs: use uuid_copy() helper to abstract uuid_t Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 03/22] xfs: use uuid_be to implement the uuid_t type Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 04/22] md: namespace private helper names Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 05/22] uuid: remove uuid_be defintions from the uapi header Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 06/22] uuid: rename uuid types Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 07/22] uuid: don't export guid_index and uuid_index Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 08/22] uuid: hoist helpers uuid_equal() and uuid_copy() from xfs Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 09/22] uuid: hoist uuid_is_null() helper from libnvdimm Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 10/22] S390/sysinfo: use uuid_is_null instead of opencoding it Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 11/22] xfs: remove uuid_getnodeuniq and xfs_uu_t Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 12/22] xfs: use the common helper uuid_is_null() Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` [PATCH 13/22] block: remove blk_part_pack_uuid Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:19 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 14/22] ima/policy: switch to use uuid_t Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 15/22] fs: switch ->s_uuid to uuid_t Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 16/22] overlayfs: use uuid_t instead of uuid_be Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 17/22] partitions/ldm: switch to use uuid_t Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 18/22] sysctl: " Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 19/22] nvme: switch to uuid_t Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 20/22] scsi_debug: " Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 21/22] tmpfs: generate random sb->s_uuid Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` [PATCH 22/22] MAINTAINERS: add uuid entry Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-28 10:20 ` Christoph Hellwig
2017-05-30 10:00 ` [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" David Howells
2017-05-30 10:00 ` David Howells
2017-05-30 10:00 ` David Howells
2017-05-31 9:41 ` Christoph Hellwig [this message]
2017-05-31 9:41 ` Christoph Hellwig
2017-05-31 9:41 ` Christoph Hellwig
2017-05-31 9:41 ` Christoph Hellwig
2017-05-31 10:33 ` David Howells
2017-05-31 10:33 ` David Howells
2017-05-31 10:33 ` David Howells
2017-05-31 10:33 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531094157.GA10511@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=shli@kernel.org \
--cc=swhiteho@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.