All of lore.kernel.org
 help / color / mirror / Atom feed
From: <laurentiu.tudor@nxp.com>
To: <gregkh@linuxfoundation.org>, <stuyoder@gmail.com>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
	<agraf@suse.de>, <arnd@arndb.de>, <ioana.ciornei@nxp.com>,
	<ruxandra.radulescu@nxp.com>, <bharat.bhushan@nxp.com>,
	<catalin.horghidan@nxp.com>, <leoyang.li@nxp.com>,
	<roy.pledge@nxp.com>, <linux-arm-kernel@lists.infradead.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: [PATCH 02/10] staging: fsl-mc: fix macros with possible side effects
Date: Wed, 31 May 2017 13:58:44 +0300	[thread overview]
Message-ID: <20170531105852.22304-3-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170531105852.22304-1-laurentiu.tudor@nxp.com>

From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Several macros were triggering this checkpatch.pl warning:
  "Macro argument reuse '$arg' - possible side-effects?"
Fix the warning by avoiding multiple macro argument use.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
 drivers/staging/fsl-mc/bus/dprc-driver.c      | 10 +++++++---
 drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 11 +++++++----
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index d723c69..39c9a3b 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -21,9 +21,13 @@
 
 #define FSL_MC_DPRC_DRIVER_NAME    "fsl_mc_dprc"
 
-#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc) \
-	(strcmp((_mc_dev)->obj_desc.type, (_obj_desc)->type) == 0 && \
-	 (_mc_dev)->obj_desc.id == (_obj_desc)->id)
+#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc)				\
+({									\
+	struct fsl_mc_device *__mc_dev = _mc_dev;			\
+	struct dprc_obj_desc *__obj_desc = _obj_desc;			\
+	(strcmp(__mc_dev->obj_desc.type, __obj_desc->type) == 0 &&	\
+	__mc_dev->obj_desc.id == __obj_desc->id);			\
+})
 
 struct dprc_child_objs {
 	int child_count;
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
index ce07096..d3def40 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
@@ -17,10 +17,13 @@
 #include "dpcon-cmd.h"
 #include "fsl-mc-private.h"
 
-#define FSL_MC_IS_ALLOCATABLE(_obj_type) \
-	(strcmp(_obj_type, "dpbp") == 0 || \
-	 strcmp(_obj_type, "dpmcp") == 0 || \
-	 strcmp(_obj_type, "dpcon") == 0)
+#define FSL_MC_IS_ALLOCATABLE(_obj_type)	\
+({						\
+	const char *__obj_type = _obj_type;	\
+	(strcmp(__obj_type, "dpbp") == 0 ||	\
+	 strcmp(__obj_type, "dpmcp") == 0 ||	\
+	 strcmp(__obj_type, "dpcon") == 0);	\
+})
 
 /**
  * fsl_mc_resource_pool_add_device - add allocatable object to a resource
-- 
2.9.4

WARNING: multiple messages have this Message-ID (diff)
From: laurentiu.tudor@nxp.com (laurentiu.tudor at nxp.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] staging: fsl-mc: fix macros with possible side effects
Date: Wed, 31 May 2017 13:58:44 +0300	[thread overview]
Message-ID: <20170531105852.22304-3-laurentiu.tudor@nxp.com> (raw)
In-Reply-To: <20170531105852.22304-1-laurentiu.tudor@nxp.com>

From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Several macros were triggering this checkpatch.pl warning:
  "Macro argument reuse '$arg' - possible side-effects?"
Fix the warning by avoiding multiple macro argument use.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
 drivers/staging/fsl-mc/bus/dprc-driver.c      | 10 +++++++---
 drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 11 +++++++----
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index d723c69..39c9a3b 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -21,9 +21,13 @@
 
 #define FSL_MC_DPRC_DRIVER_NAME    "fsl_mc_dprc"
 
-#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc) \
-	(strcmp((_mc_dev)->obj_desc.type, (_obj_desc)->type) == 0 && \
-	 (_mc_dev)->obj_desc.id == (_obj_desc)->id)
+#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc)				\
+({									\
+	struct fsl_mc_device *__mc_dev = _mc_dev;			\
+	struct dprc_obj_desc *__obj_desc = _obj_desc;			\
+	(strcmp(__mc_dev->obj_desc.type, __obj_desc->type) == 0 &&	\
+	__mc_dev->obj_desc.id == __obj_desc->id);			\
+})
 
 struct dprc_child_objs {
 	int child_count;
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
index ce07096..d3def40 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
@@ -17,10 +17,13 @@
 #include "dpcon-cmd.h"
 #include "fsl-mc-private.h"
 
-#define FSL_MC_IS_ALLOCATABLE(_obj_type) \
-	(strcmp(_obj_type, "dpbp") == 0 || \
-	 strcmp(_obj_type, "dpmcp") == 0 || \
-	 strcmp(_obj_type, "dpcon") == 0)
+#define FSL_MC_IS_ALLOCATABLE(_obj_type)	\
+({						\
+	const char *__obj_type = _obj_type;	\
+	(strcmp(__obj_type, "dpbp") == 0 ||	\
+	 strcmp(__obj_type, "dpmcp") == 0 ||	\
+	 strcmp(__obj_type, "dpcon") == 0);	\
+})
 
 /**
  * fsl_mc_resource_pool_add_device - add allocatable object to a resource
-- 
2.9.4

  parent reply	other threads:[~2017-05-31 11:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 10:58 [PATCH v6 00/10] staging: fsl-mc: move bus driver out of staging laurentiu.tudor
2017-05-31 10:58 ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 01/10] staging: fsl-mc: enclose macro params in parens laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-06-03  8:41   ` Greg KH
2017-06-03  8:41     ` Greg KH
2017-06-06 12:03     ` Laurentiu Tudor
2017-06-06 12:03       ` Laurentiu Tudor
2017-05-31 10:58 ` laurentiu.tudor [this message]
2017-05-31 10:58   ` [PATCH 02/10] staging: fsl-mc: fix macros with possible side effects laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 03/10] staging: fsl-mc: simplify couple of deallocations laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 04/10] staging: fsl-mc: drop a few useless #includes laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 05/10] staging: fsl-mc: remove extra blank line laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 06/10] staging: fsl-mc: drop unused forward declaration laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH v2 07/10] staging: fsl-mc: add binding path to MAINTAINERS laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 08/10] staging: fsl-mc: drop reference to restool laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH 09/10] staging: fsl-mc: add reference to mc-bus DT binding laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 10:58 ` [PATCH v4 10/10] staging: fsl-mc: move bus driver out of staging laurentiu.tudor
2017-05-31 10:58   ` laurentiu.tudor at nxp.com
2017-05-31 11:15   ` Marc Zyngier
2017-05-31 11:15     ` Marc Zyngier
2017-05-31 11:31     ` Laurentiu Tudor
2017-05-31 11:31       ` Laurentiu Tudor
2017-06-03  8:40   ` Greg KH
2017-06-03  8:40     ` Greg KH
2017-06-06 14:03     ` Laurentiu Tudor
2017-06-06 14:03       ` Laurentiu Tudor
2017-06-06 14:20       ` Greg KH
2017-06-06 14:20         ` Greg KH
2017-06-06 14:23         ` Laurentiu Tudor
2017-06-06 14:23           ` Laurentiu Tudor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531105852.22304-3-laurentiu.tudor@nxp.com \
    --to=laurentiu.tudor@nxp.com \
    --cc=agraf@suse.de \
    --cc=arnd@arndb.de \
    --cc=bharat.bhushan@nxp.com \
    --cc=catalin.horghidan@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roy.pledge@nxp.com \
    --cc=ruxandra.radulescu@nxp.com \
    --cc=stuyoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.