All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Martin Peres <martin.peres@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] lib/kms: Force a full reprobe if we find a bad link
Date: Wed, 31 May 2017 13:42:24 +0100	[thread overview]
Message-ID: <20170531124224.GP23936@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <bf889515-723c-aa56-3f7b-0b21c2becafa@linux.intel.com>

On Wed, May 31, 2017 at 01:40:00PM +0300, Martin Peres wrote:
> On 26/05/17 14:48, Chris Wilson wrote:
> >If we do a shallow probe of the connector and it reports the link failed
> >previous (link-status != GOOD), force a full probe of the connector to
> >give the kernel a chance to validate the mode list.
> 
> Sounds good, but will this make the tests SKIP if no modes are available?

I'm actually not sure what will happen if the mode is removed. I think
the tests are just using the first mode in the list? At the moment I
hope just to stop turning a single failure into many, it is still a bug
that the link training failed and was not recovered. Alternatively, we
can ask why isn't the kernel taking the corrective action when presented
with a new setcrtc?

I'm not sure what the correct approach here should be, just what is the
contract the kernel is expecting of userspace? Should that contract
apply to new clients unaware of the earlier error?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-05-31 12:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 11:48 [PATCH igt] lib/kms: Force a full reprobe if we find a bad link Chris Wilson
2017-05-26 11:54 ` Chris Wilson
2017-05-31 10:40 ` Martin Peres
2017-05-31 12:42   ` Chris Wilson [this message]
2017-05-31 13:44     ` Martin Peres
2017-05-31 13:55       ` Chris Wilson
2017-05-31 14:45         ` Martin Peres
2017-06-07 11:13           ` Martin Peres
2017-06-07 11:33             ` Chris Wilson
2017-06-07 11:58               ` Martin Peres
2017-06-07 12:26                 ` Lofstedt, Marta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531124224.GP23936@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=martin.peres@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.