All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Peres <martin.peres@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org, "Lofstedt,
	Marta" <marta.lofstedt@intel.com>
Subject: Re: [PATCH igt] lib/kms: Force a full reprobe if we find a bad link
Date: Wed, 7 Jun 2017 14:58:58 +0300	[thread overview]
Message-ID: <e770570c-df9a-b328-5521-a56d7835efa2@linux.intel.com> (raw)
In-Reply-To: <149683519355.24475.10892372138007025755@mail.alporthouse.com>

On 07/06/17 14:33, Chris Wilson wrote:
> Quoting Martin Peres (2017-06-07 12:13:24)
>> How about this: When the modeset call fails, check if the link-status is
>> BAD. If not, return a FAIL. If so, force a full re-probe, pick the
>> highest available mode and try again. Do this until a mode applies. If
>> no modes are left, just SKIP the test altogether.
>>
>> Does this sound reasonable?
> 
> The problem here is that we need to loop back to the test for it to
> decide on the next mode. In most cases we don't care, but igt_kms.c
> doesn't know this. But if e.g. we have a CRC computed for one size, it
> needs to be swapped out for the new mode.

Oh dear, isn't life fun?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-06-07 11:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 11:48 [PATCH igt] lib/kms: Force a full reprobe if we find a bad link Chris Wilson
2017-05-26 11:54 ` Chris Wilson
2017-05-31 10:40 ` Martin Peres
2017-05-31 12:42   ` Chris Wilson
2017-05-31 13:44     ` Martin Peres
2017-05-31 13:55       ` Chris Wilson
2017-05-31 14:45         ` Martin Peres
2017-06-07 11:13           ` Martin Peres
2017-06-07 11:33             ` Chris Wilson
2017-06-07 11:58               ` Martin Peres [this message]
2017-06-07 12:26                 ` Lofstedt, Marta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e770570c-df9a-b328-5521-a56d7835efa2@linux.intel.com \
    --to=martin.peres@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=marta.lofstedt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.