* [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
@ 2017-05-30 15:04 Greg Kurz
2017-05-30 15:09 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-05-30 16:34 ` [Qemu-devel] " Christian Borntraeger
0 siblings, 2 replies; 6+ messages in thread
From: Greg Kurz @ 2017-05-30 15:04 UTC (permalink / raw)
To: qemu-devel
Cc: Cornelia Huck, Christian Borntraeger, qemu-trivial, Fam Zheng,
Alexander Graf
The docker-run-test-build@debian-s390x-cross target fails with:
strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
strip: Unable to recognise the format of the input file `s390-ccw.elf'
The configure script defines a STRIP makefile variable whose default
value is ${cross_prefix}strip. Let's use it.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
pc-bios/s390-ccw/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
index 79a46b67356f..7af57dad109c 100644
--- a/pc-bios/s390-ccw/Makefile
+++ b/pc-bios/s390-ccw/Makefile
@@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
$(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
s390-ccw.img: s390-ccw.elf
- $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
+ $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
$(OBJECTS): Makefile
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-30 15:04 [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
@ 2017-05-30 15:09 ` Philippe Mathieu-Daudé
2017-05-30 16:34 ` [Qemu-devel] " Christian Borntraeger
1 sibling, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-05-30 15:09 UTC (permalink / raw)
To: Greg Kurz, qemu-devel
Cc: Cornelia Huck, Christian Borntraeger, qemu-trivial, Fam Zheng,
Alexander Graf
On 05/30/2017 12:04 PM, Greg Kurz wrote:
> The docker-run-test-build@debian-s390x-cross target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> pc-bios/s390-ccw/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..7af57dad109c 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
> s390-ccw.img: s390-ccw.elf
> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>
> $(OBJECTS): Makefile
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-30 15:04 [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
2017-05-30 15:09 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2017-05-30 16:34 ` Christian Borntraeger
2017-05-30 16:56 ` Greg Kurz
1 sibling, 1 reply; 6+ messages in thread
From: Christian Borntraeger @ 2017-05-30 16:34 UTC (permalink / raw)
To: Greg Kurz, qemu-devel
Cc: Cornelia Huck, qemu-trivial, Fam Zheng, Alexander Graf
On 05/30/2017 05:04 PM, Greg Kurz wrote:
> The docker-run-test-build@debian-s390x-cross target fails with:
>
> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>
> The configure script defines a STRIP makefile variable whose default
> value is ${cross_prefix}strip. Let's use it.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> pc-bios/s390-ccw/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> index 79a46b67356f..7af57dad109c 100644
> --- a/pc-bios/s390-ccw/Makefile
> +++ b/pc-bios/s390-ccw/Makefile
> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>
> s390-ccw.img: s390-ccw.elf
> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>
> $(OBJECTS): Makefile
>
>
I was going to apply this, but it fails with --disable-strip like
/bin/sh: --strip-unneeded: command not found
Makefile:25: recipe for target 's390-ccw.img' failed
make[1]: *** [s390-ccw.img] Error 127
Makefile:354: recipe for target 'romsubdir-s390-ccw' failed
make: *** [romsubdir-s390-ccw] Error 2
Not yet sure whats going on.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-30 16:34 ` [Qemu-devel] " Christian Borntraeger
@ 2017-05-30 16:56 ` Greg Kurz
2017-05-31 13:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kurz @ 2017-05-30 16:56 UTC (permalink / raw)
To: Christian Borntraeger
Cc: qemu-devel, Cornelia Huck, qemu-trivial, Fam Zheng, Alexander Graf
[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]
On Tue, 30 May 2017 18:34:46 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 05/30/2017 05:04 PM, Greg Kurz wrote:
> > The docker-run-test-build@debian-s390x-cross target fails with:
> >
> > strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> > strip: Unable to recognise the format of the input file `s390-ccw.elf'
> >
> > The configure script defines a STRIP makefile variable whose default
> > value is ${cross_prefix}strip. Let's use it.
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
> > ---
> > pc-bios/s390-ccw/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> > index 79a46b67356f..7af57dad109c 100644
> > --- a/pc-bios/s390-ccw/Makefile
> > +++ b/pc-bios/s390-ccw/Makefile
> > @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
> > $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
> >
> > s390-ccw.img: s390-ccw.elf
> > - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> > + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> >
> > $(OBJECTS): Makefile
> >
> >
>
> I was going to apply this, but it fails with --disable-strip like
>
> /bin/sh: --strip-unneeded: command not found
> Makefile:25: recipe for target 's390-ccw.img' failed
> make[1]: *** [s390-ccw.img] Error 127
> Makefile:354: recipe for target 'romsubdir-s390-ccw' failed
> make: *** [romsubdir-s390-ccw] Error 2
>
> Not yet sure whats going on.
>
configure doesn't generate STRIP when --disable-strip or --enable-debug... so
I guess we shouldn't use it here, but rather generate a s390_cross_prefix like
in roms/Makefile ?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-30 16:56 ` Greg Kurz
@ 2017-05-31 13:15 ` Laurent Vivier
2017-05-31 13:30 ` Greg Kurz
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2017-05-31 13:15 UTC (permalink / raw)
To: Greg Kurz, Christian Borntraeger
Cc: Cornelia Huck, qemu-trivial, Fam Zheng, qemu-devel, Alexander Graf
On 30/05/2017 18:56, Greg Kurz wrote:
> On Tue, 30 May 2017 18:34:46 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>
>> On 05/30/2017 05:04 PM, Greg Kurz wrote:
>>> The docker-run-test-build@debian-s390x-cross target fails with:
>>>
>>> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
>>> strip: Unable to recognise the format of the input file `s390-ccw.elf'
>>>
>>> The configure script defines a STRIP makefile variable whose default
>>> value is ${cross_prefix}strip. Let's use it.
>>>
>>> Signed-off-by: Greg Kurz <groug@kaod.org>
>>> ---
>>> pc-bios/s390-ccw/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
>>> index 79a46b67356f..7af57dad109c 100644
>>> --- a/pc-bios/s390-ccw/Makefile
>>> +++ b/pc-bios/s390-ccw/Makefile
>>> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
>>> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
>>>
>>> s390-ccw.img: s390-ccw.elf
>>> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>>> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
>>>
>>> $(OBJECTS): Makefile
>>>
>>>
>>
>> I was going to apply this, but it fails with --disable-strip like
>>
>> /bin/sh: --strip-unneeded: command not found
>> Makefile:25: recipe for target 's390-ccw.img' failed
>> make[1]: *** [s390-ccw.img] Error 127
>> Makefile:354: recipe for target 'romsubdir-s390-ccw' failed
>> make: *** [romsubdir-s390-ccw] Error 2
>>
>> Not yet sure whats going on.
>>
>
> configure doesn't generate STRIP when --disable-strip or --enable-debug... so
> I guess we shouldn't use it here, but rather generate a s390_cross_prefix like
> in roms/Makefile ?
>
I experimented the problem when I played with docker, and fixed the
problem as you did (with STRIP).
But I think it's a good idea to compile s390 rom as it is done for ppc64
and ppc roms.
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile
2017-05-31 13:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2017-05-31 13:30 ` Greg Kurz
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kurz @ 2017-05-31 13:30 UTC (permalink / raw)
To: Laurent Vivier
Cc: Christian Borntraeger, Cornelia Huck, qemu-trivial, Fam Zheng,
qemu-devel, Alexander Graf
[-- Attachment #1: Type: text/plain, Size: 2440 bytes --]
On Wed, 31 May 2017 15:15:56 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> On 30/05/2017 18:56, Greg Kurz wrote:
> > On Tue, 30 May 2017 18:34:46 +0200
> > Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> >
> >> On 05/30/2017 05:04 PM, Greg Kurz wrote:
> >>> The docker-run-test-build@debian-s390x-cross target fails with:
> >>>
> >>> strip --strip-unneeded s390-ccw.elf -o s390-ccw.img
> >>> strip: Unable to recognise the format of the input file `s390-ccw.elf'
> >>>
> >>> The configure script defines a STRIP makefile variable whose default
> >>> value is ${cross_prefix}strip. Let's use it.
> >>>
> >>> Signed-off-by: Greg Kurz <groug@kaod.org>
> >>> ---
> >>> pc-bios/s390-ccw/Makefile | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
> >>> index 79a46b67356f..7af57dad109c 100644
> >>> --- a/pc-bios/s390-ccw/Makefile
> >>> +++ b/pc-bios/s390-ccw/Makefile
> >>> @@ -22,7 +22,7 @@ s390-ccw.elf: $(OBJECTS)
> >>> $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $(OBJECTS),"BUILD","$(TARGET_DIR)$@")
> >>>
> >>> s390-ccw.img: s390-ccw.elf
> >>> - $(call quiet-command,strip --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> >>> + $(call quiet-command,$(STRIP) --strip-unneeded $< -o $@,"STRIP","$(TARGET_DIR)$@")
> >>>
> >>> $(OBJECTS): Makefile
> >>>
> >>>
> >>
> >> I was going to apply this, but it fails with --disable-strip like
> >>
> >> /bin/sh: --strip-unneeded: command not found
> >> Makefile:25: recipe for target 's390-ccw.img' failed
> >> make[1]: *** [s390-ccw.img] Error 127
> >> Makefile:354: recipe for target 'romsubdir-s390-ccw' failed
> >> make: *** [romsubdir-s390-ccw] Error 2
> >>
> >> Not yet sure whats going on.
> >>
> >
> > configure doesn't generate STRIP when --disable-strip or --enable-debug... so
> > I guess we shouldn't use it here, but rather generate a s390_cross_prefix like
> > in roms/Makefile ?
> >
>
> I experimented the problem when I played with docker, and fixed the
> problem as you did (with STRIP).
>
I've sent a v2 with a 'STRIP ?= strip' line to handle the issue reported
by Christian.
> But I think it's a good idea to compile s390 rom as it is done for ppc64
> and ppc roms.
>
Yeah, I was thinking about that too but I don't know all the ins and outs.
> Laurent
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-31 13:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 15:04 [Qemu-devel] [PATCH] pc-bios/s390-ccw: use STRIP variable in Makefile Greg Kurz
2017-05-30 15:09 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-05-30 16:34 ` [Qemu-devel] " Christian Borntraeger
2017-05-30 16:56 ` Greg Kurz
2017-05-31 13:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2017-05-31 13:30 ` Greg Kurz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.