* "Redirecting" a bug report to the relevant list
@ 2017-05-31 11:07 Petru Mihancea
2017-05-31 18:31 ` [PATCH libata/for-4.12-fixes] libata: fix error checking in in ata_parse_force_one() Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Petru Mihancea @ 2017-05-31 11:07 UTC (permalink / raw)
To: linux-ide
Hi,
I misclassified the bug report at the following link. Since I do not
want to introduce duplications, I thought it might be better to send
an email to the list that looks relevant.
https://bugzilla.kernel.org/show_bug.cgi?id=195785
Thank you,
Petru Mihancea
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH libata/for-4.12-fixes] libata: fix error checking in in ata_parse_force_one()
2017-05-31 11:07 "Redirecting" a bug report to the relevant list Petru Mihancea
@ 2017-05-31 18:31 ` Tejun Heo
2017-06-01 9:03 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2017-05-31 18:31 UTC (permalink / raw)
To: Petru Mihancea; +Cc: linux-ide
>From f7cf69ae171592d133c69b9adaa5de7cfb6038ea Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Wed, 31 May 2017 14:26:26 -0400
ata_parse_force_one() was incorrectly comparing @p to @endp when it
should have been comparing @id. The only consequence is that it may
end up using an invalid port number in "libata.force" module param
instead of rejecting it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Petru-Florin Mihancea <petrum@gmail.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=195785
---
Applied to libata/for-4.12-fixes. Thanks.
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 2d83b8c75965..e157a0e44419 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6800,7 +6800,7 @@ static int __init ata_parse_force_one(char **cur,
}
force_ent->port = simple_strtoul(id, &endp, 10);
- if (p == endp || *endp != '\0') {
+ if (id == endp || *endp != '\0') {
*reason = "invalid port/link";
return -EINVAL;
}
--
2.13.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH libata/for-4.12-fixes] libata: fix error checking in in ata_parse_force_one()
2017-05-31 18:31 ` [PATCH libata/for-4.12-fixes] libata: fix error checking in in ata_parse_force_one() Tejun Heo
@ 2017-06-01 9:03 ` Sergei Shtylyov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2017-06-01 9:03 UTC (permalink / raw)
To: Tejun Heo, Petru Mihancea; +Cc: linux-ide
Hello!
s/in in/in/ in the subject. :-)
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-01 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 11:07 "Redirecting" a bug report to the relevant list Petru Mihancea
2017-05-31 18:31 ` [PATCH libata/for-4.12-fixes] libata: fix error checking in in ata_parse_force_one() Tejun Heo
2017-06-01 9:03 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.