* [patch] staging: speakup: check for null before calling TTY's flush_buffer
@ 2017-05-31 19:50 Okash Khawaja
0 siblings, 0 replies; only message in thread
From: Okash Khawaja @ 2017-05-31 19:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Samuel Thibault, linux-kernel
Cc: William Hubbs, Chris Brannon, Kirk Reiser, speakup, devel
We should check the flush_buffer method of a tty for null before
invoking it. Some drivers such as usbserial don't implement
flush_buffer. This will be required for upcoming patches where we expand
spk_ttyio to support more than just ttyS*.
Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
drivers/staging/speakup/spk_ttyio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -227,7 +227,8 @@ static unsigned char spk_ttyio_in_nowait
static void spk_ttyio_flush_buffer(void)
{
- speakup_tty->ops->flush_buffer(speakup_tty);
+ if (speakup_tty->ops->flush_buffer)
+ speakup_tty->ops->flush_buffer(speakup_tty);
}
int spk_ttyio_synth_probe(struct spk_synth *synth)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-05-31 19:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 19:50 [patch] staging: speakup: check for null before calling TTY's flush_buffer Okash Khawaja
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.