All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com,
	catalin.marinas@arm.com, mark.rutland@arm.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, peterz@infradead.org,
	mingo@redhat.com, jnair@caviumnetworks.com, gpkulkarni@gmail.com
Subject: Re: [PATCH v2 2/2] perf: ThunderX2: Add Cavium Thunderx2 SoC UNCORE PMU driver
Date: Thu, 1 Jun 2017 02:31:19 +0800	[thread overview]
Message-ID: <201706010245.AKqnQgAP%fengguang.wu@intel.com> (raw)
In-Reply-To: <1496224663-13819-3-git-send-email-ganapatrao.kulkarni@cavium.com>

[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]

Hi Ganapatrao,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ganapatrao-Kulkarni/perf-uncore-Adding-documentation-for-ThunderX2-pmu-uncore-driver/20170531-204518
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/perf/thunderx2_pmu.c: In function 'thunderx2_uncore_update':
>> drivers/perf/thunderx2_pmu.c:499:18: warning: left shift count >= width of type [-Wshift-count-overflow]
      delta = (((1UL << 32) - prev) + new);
                     ^~

vim +499 drivers/perf/thunderx2_pmu.c

   483		u64 delta;
   484		struct hw_perf_event *hwc = &event->hw;
   485		struct thunderx2_pmu_uncore_channel *pmu_uncore;
   486		enum thunderx2_uncore_type type;
   487	
   488		pmu_uncore = pmu_to_thunderx2_pmu_uncore(event->pmu);
   489		type = pmu_uncore->uncore_dev->type;
   490	
   491		if (pmu_uncore->uncore_dev->select_channel)
   492			pmu_uncore->uncore_dev->select_channel(event);
   493	
   494		new = reg_readl(hwc->event_base);
   495		prev = local64_xchg(&hwc->prev_count, new);
   496	
   497		/* handle rollover of counters */
   498		if (new < prev)
 > 499			delta = (((1UL << 32) - prev) + new);
   500		else
   501			delta = new - prev;
   502	
   503		local64_add(delta, &event->count);
   504	}
   505	
   506	enum thunderx2_uncore_type get_uncore_device_type(struct acpi_device *adev)
   507	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60135 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: lkp@intel.com (kbuild test robot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] perf: ThunderX2: Add Cavium Thunderx2 SoC UNCORE PMU driver
Date: Thu, 1 Jun 2017 02:31:19 +0800	[thread overview]
Message-ID: <201706010245.AKqnQgAP%fengguang.wu@intel.com> (raw)
In-Reply-To: <1496224663-13819-3-git-send-email-ganapatrao.kulkarni@cavium.com>

Hi Ganapatrao,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ganapatrao-Kulkarni/perf-uncore-Adding-documentation-for-ThunderX2-pmu-uncore-driver/20170531-204518
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/perf/thunderx2_pmu.c: In function 'thunderx2_uncore_update':
>> drivers/perf/thunderx2_pmu.c:499:18: warning: left shift count >= width of type [-Wshift-count-overflow]
      delta = (((1UL << 32) - prev) + new);
                     ^~

vim +499 drivers/perf/thunderx2_pmu.c

   483		u64 delta;
   484		struct hw_perf_event *hwc = &event->hw;
   485		struct thunderx2_pmu_uncore_channel *pmu_uncore;
   486		enum thunderx2_uncore_type type;
   487	
   488		pmu_uncore = pmu_to_thunderx2_pmu_uncore(event->pmu);
   489		type = pmu_uncore->uncore_dev->type;
   490	
   491		if (pmu_uncore->uncore_dev->select_channel)
   492			pmu_uncore->uncore_dev->select_channel(event);
   493	
   494		new = reg_readl(hwc->event_base);
   495		prev = local64_xchg(&hwc->prev_count, new);
   496	
   497		/* handle rollover of counters */
   498		if (new < prev)
 > 499			delta = (((1UL << 32) - prev) + new);
   500		else
   501			delta = new - prev;
   502	
   503		local64_add(delta, &event->count);
   504	}
   505	
   506	enum thunderx2_uncore_type get_uncore_device_type(struct acpi_device *adev)
   507	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 60135 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170601/e71a0951/attachment-0001.gz>

  reply	other threads:[~2017-05-31 18:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  9:57 [PATCH v2 0/2] Add ThunderX2 SoC Performance Monitoring Unit driver Ganapatrao Kulkarni
2017-05-31  9:57 ` Ganapatrao Kulkarni
2017-05-31  9:57 ` [PATCH v2 1/2] perf: uncore: Adding documentation for ThunderX2 pmu uncore driver Ganapatrao Kulkarni
2017-05-31  9:57   ` Ganapatrao Kulkarni
2017-05-31  9:57 ` [PATCH v2 2/2] perf: ThunderX2: Add Cavium Thunderx2 SoC UNCORE PMU driver Ganapatrao Kulkarni
2017-05-31  9:57   ` Ganapatrao Kulkarni
2017-05-31 18:31   ` kbuild test robot [this message]
2017-05-31 18:31     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201706010245.AKqnQgAP%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=Will.Deacon@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=gpkulkarni@gmail.com \
    --cc=jnair@caviumnetworks.com \
    --cc=kbuild-all@01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.