All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@intel.com>,
	Hannes Reinecke <hare@suse.de>, Max Gurtovoy <maxg@mellanox.com>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns
Date: Thu, 1 Jun 2017 08:33:54 +0200	[thread overview]
Message-ID: <20170601063354.GA16778@lst.de> (raw)
In-Reply-To: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496237370.git.jthumshirn@suse.de>

On Wed, May 31, 2017 at 03:32:11PM +0200, Johannes Thumshirn wrote:
> The uuid field in the nvme_ns structure represents the nguid field
> from the identify namespace command. And as NVMe 1.3 introduced an
> UUID in the NVMe Namespace Identification Descriptor this will
> collide.
> 
> So rename the uuid to nguid to prevent any further
> confusion. Unfortunately we export the nguid to sysfs in the uuid
> sysfs attribute, but this can't be changed anymore without possibly
> breaking existing userspace.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns
Date: Thu, 1 Jun 2017 08:33:54 +0200	[thread overview]
Message-ID: <20170601063354.GA16778@lst.de> (raw)
In-Reply-To: <7e97c34f8ab586615cb57b22a36db2eeb0ccc57f.1496237370.git.jthumshirn@suse.de>

On Wed, May 31, 2017@03:32:11PM +0200, Johannes Thumshirn wrote:
> The uuid field in the nvme_ns structure represents the nguid field
> from the identify namespace command. And as NVMe 1.3 introduced an
> UUID in the NVMe Namespace Identification Descriptor this will
> collide.
> 
> So rename the uuid to nguid to prevent any further
> confusion. Unfortunately we export the nguid to sysfs in the uuid
> sysfs attribute, but this can't be changed anymore without possibly
> breaking existing userspace.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn at suse.de>

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

  reply	other threads:[~2017-06-01  6:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31 13:32 [PATCH v1 0/7] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-05-31 13:32 ` Johannes Thumshirn
2017-05-31 13:32 ` [PATCH v1 1/7] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-06-01  6:33   ` Christoph Hellwig [this message]
2017-06-01  6:33     ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 2/7] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-06-01  6:34   ` Christoph Hellwig
2017-06-01  6:34     ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 3/7] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-06-01  6:42   ` Christoph Hellwig
2017-06-01  6:42     ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 4/7] nvme: get list of namespace descriptors Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-05-31 19:13   ` Max Gurtovoy
2017-05-31 19:13     ` Max Gurtovoy
2017-06-01  6:49   ` Christoph Hellwig
2017-06-01  6:49     ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 5/7] nvme: provide UUID value to userspace Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-06-01  6:49   ` Christoph Hellwig
2017-06-01  6:49     ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 6/7] nvme: change magic 4096 to SZ_4K Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-06-01  6:50   ` Christoph Hellwig
2017-06-01  6:50     ` Christoph Hellwig
2017-05-31 13:32 ` [PATCH v1 7/7] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-05-31 13:32   ` Johannes Thumshirn
2017-06-01  6:52   ` Christoph Hellwig
2017-06-01  6:52     ` Christoph Hellwig
2017-06-01  6:59     ` Hannes Reinecke
2017-06-01  6:59       ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170601063354.GA16778@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.