* [PATCH net-next] dccp: consistently use dccp_write_space()
@ 2017-06-02 15:02 Eric Dumazet
2017-06-04 23:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2017-06-02 15:02 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Gerrit Renker
From: Eric Dumazet <edumazet@google.com>
DCCP uses dccp_write_space() for sk->sk_write_space method.
Unfortunately a passive connection (as provided by accept())
is using the generic sk_stream_write_space() function.
Lets simply inherit sk->sk_write_space from the parent
instead of forcing the generic one.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
net/ipv4/inet_connection_sock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index 82dec8825d28fe01f2dc4172e3e6d4d0d70fd785..a3fa1a5b6d98eb1502ada67bf5d63b12f199c640 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -790,7 +790,6 @@ struct sock *inet_csk_clone_lock(const struct sock *sk,
inet_sk(newsk)->inet_dport = inet_rsk(req)->ir_rmt_port;
inet_sk(newsk)->inet_num = inet_rsk(req)->ir_num;
inet_sk(newsk)->inet_sport = htons(inet_rsk(req)->ir_num);
- newsk->sk_write_space = sk_stream_write_space;
/* listeners have SOCK_RCU_FREE, not the children */
sock_reset_flag(newsk, SOCK_RCU_FREE);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] dccp: consistently use dccp_write_space()
2017-06-02 15:02 [PATCH net-next] dccp: consistently use dccp_write_space() Eric Dumazet
@ 2017-06-04 23:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-04 23:58 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, gerrit
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 02 Jun 2017 08:02:26 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> DCCP uses dccp_write_space() for sk->sk_write_space method.
>
> Unfortunately a passive connection (as provided by accept())
> is using the generic sk_stream_write_space() function.
>
> Lets simply inherit sk->sk_write_space from the parent
> instead of forcing the generic one.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied, thanks Eric.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-04 23:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-02 15:02 [PATCH net-next] dccp: consistently use dccp_write_space() Eric Dumazet
2017-06-04 23:58 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.