From: David Miller <davem@davemloft.net>
To: clabbe.montjoie@gmail.com
Cc: icenowy@aosc.io, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted
Date: Mon, 05 Jun 2017 10:19:57 -0400 (EDT) [thread overview]
Message-ID: <20170605.101957.1159360169934143154.davem@davemloft.net> (raw)
In-Reply-To: <20170605111019.GA29657@Red>
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Mon, 5 Jun 2017 13:10:19 +0200
> On Mon, Jun 05, 2017 at 01:53:23AM +0800, Icenowy Zheng wrote:
>> The EPHY may be already enabled by bootloaders which have Ethernet
>> capability (e.g. current U-Boot). Thus it should be reseted properly
>> before doing the enabling sequence in the dwmac-sun8i driver, otherwise
>> the EMAC reset process may fail if no cable is plugged, and then fail
>> the dwmac-sun8i probing.
>>
>> Tested on Orange Pi PC, One and Zero. All the boards fail to have
>> dwmac-sun8i probed with "EMAC reset timeout" without cable plugged
>> before, and with this fix they're now all able to successfully probe the
>> EMAC without cable plugged and then use the connection after a cable is
>> hot-plugged in.
>>
>> Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i")
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Thanks for the fix.
> Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Since I am the writter of the file, does I have the right to:
> Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> or
> Reviewed-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ?
Anyone whatsoever may contribute Acked-by and Reviewed-by tags to a
patch posting.
This is all documented in Documentation/process/submitting-patches.rst
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: icenowy-h8G6r0blFSE@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted
Date: Mon, 05 Jun 2017 10:19:57 -0400 (EDT) [thread overview]
Message-ID: <20170605.101957.1159360169934143154.davem@davemloft.net> (raw)
In-Reply-To: <20170605111019.GA29657@Red>
From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Mon, 5 Jun 2017 13:10:19 +0200
> On Mon, Jun 05, 2017 at 01:53:23AM +0800, Icenowy Zheng wrote:
>> The EPHY may be already enabled by bootloaders which have Ethernet
>> capability (e.g. current U-Boot). Thus it should be reseted properly
>> before doing the enabling sequence in the dwmac-sun8i driver, otherwise
>> the EMAC reset process may fail if no cable is plugged, and then fail
>> the dwmac-sun8i probing.
>>
>> Tested on Orange Pi PC, One and Zero. All the boards fail to have
>> dwmac-sun8i probed with "EMAC reset timeout" without cable plugged
>> before, and with this fix they're now all able to successfully probe the
>> EMAC without cable plugged and then use the connection after a cable is
>> hot-plugged in.
>>
>> Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i")
>> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
>
> Thanks for the fix.
> Tested-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Since I am the writter of the file, does I have the right to:
> Acked-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> or
> Reviewed-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ?
Anyone whatsoever may contribute Acked-by and Reviewed-by tags to a
patch posting.
This is all documented in Documentation/process/submitting-patches.rst
WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted
Date: Mon, 05 Jun 2017 10:19:57 -0400 (EDT) [thread overview]
Message-ID: <20170605.101957.1159360169934143154.davem@davemloft.net> (raw)
In-Reply-To: <20170605111019.GA29657@Red>
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Mon, 5 Jun 2017 13:10:19 +0200
> On Mon, Jun 05, 2017 at 01:53:23AM +0800, Icenowy Zheng wrote:
>> The EPHY may be already enabled by bootloaders which have Ethernet
>> capability (e.g. current U-Boot). Thus it should be reseted properly
>> before doing the enabling sequence in the dwmac-sun8i driver, otherwise
>> the EMAC reset process may fail if no cable is plugged, and then fail
>> the dwmac-sun8i probing.
>>
>> Tested on Orange Pi PC, One and Zero. All the boards fail to have
>> dwmac-sun8i probed with "EMAC reset timeout" without cable plugged
>> before, and with this fix they're now all able to successfully probe the
>> EMAC without cable plugged and then use the connection after a cable is
>> hot-plugged in.
>>
>> Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i")
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Thanks for the fix.
> Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Since I am the writter of the file, does I have the right to:
> Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> or
> Reviewed-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ?
Anyone whatsoever may contribute Acked-by and Reviewed-by tags to a
patch posting.
This is all documented in Documentation/process/submitting-patches.rst
next prev parent reply other threads:[~2017-06-05 14:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:53 [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted Icenowy Zheng
2017-06-04 17:53 ` Icenowy Zheng
2017-06-04 17:53 ` Icenowy Zheng
2017-06-05 11:10 ` [linux-sunxi] " Corentin Labbe
2017-06-05 11:10 ` Corentin Labbe
2017-06-05 12:44 ` Andrew Lunn
2017-06-05 12:44 ` Andrew Lunn
2017-06-05 12:44 ` Andrew Lunn
2017-06-05 14:19 ` David Miller [this message]
2017-06-05 14:19 ` [linux-sunxi] " David Miller
2017-06-05 14:19 ` David Miller
2017-06-05 15:23 ` David Miller
2017-06-05 15:23 ` David Miller
2017-06-05 15:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605.101957.1159360169934143154.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=clabbe.montjoie@gmail.com \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.