From: Mark Brown <broonie@kernel.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-mediatek@lists.infradead.org, sean.wang@mediatek.com
Subject: Re: [PATCH 2/3] spi: mediatek: support adjust register define
Date: Tue, 6 Jun 2017 19:57:30 +0100 [thread overview]
Message-ID: <20170606185730.mrvgvp4hynftwahx@sirena.org.uk> (raw)
In-Reply-To: <1496387923-31674-3-git-send-email-leilk.liu@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote:
> + /* some IC design adjust register define */
> + bool adjust_reg;
Can we have a name that's more specific to the particular quirk please?
The current name will get confusing if some future chip also needs
slightly different register settings.
Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] spi: mediatek: support adjust register define
Date: Tue, 6 Jun 2017 19:57:30 +0100 [thread overview]
Message-ID: <20170606185730.mrvgvp4hynftwahx@sirena.org.uk> (raw)
In-Reply-To: <1496387923-31674-3-git-send-email-leilk.liu@mediatek.com>
On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote:
> + /* some IC design adjust register define */
> + bool adjust_reg;
Can we have a name that's more specific to the particular quirk please?
The current name will get confusing if some future chip also needs
slightly different register settings.
Otherwise this looks good.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170606/8b667a53/attachment.sig>
next prev parent reply other threads:[~2017-06-06 18:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 7:18 [PATCH 0/3] add mt7622 spi support Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-02 7:18 ` [PATCH 1/3] dt-bindings: spi: mediatek: Add bindings for mediatek MT7622 soc platform Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-06 18:57 ` Mark Brown
2017-06-06 18:57 ` Mark Brown
2017-06-06 19:07 ` Applied "spi: mediatek: Add bindings for mediatek MT7622 soc platform" to the spi tree Mark Brown
2017-06-06 19:07 ` Mark Brown
2017-06-06 19:07 ` Mark Brown
2017-06-02 7:18 ` [PATCH 2/3] spi: mediatek: support adjust register define Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-06 18:57 ` Mark Brown [this message]
2017-06-06 18:57 ` Mark Brown
2017-06-08 1:41 ` lei liu
2017-06-08 1:41 ` lei liu
2017-06-08 1:41 ` lei liu
2017-06-08 1:41 ` lei liu
2017-06-02 7:18 ` [PATCH 3/3] spi: mediatek: add compatible support for mt7622 IC Leilk Liu
2017-06-02 7:18 ` Leilk Liu
2017-06-02 7:18 ` Leilk Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606185730.mrvgvp4hynftwahx@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.