* [PATCH v2] net: mvpp2: do not bypass the mvpp22_port_mii_set function
@ 2017-06-07 6:17 ` Antoine Tenart
0 siblings, 0 replies; 4+ messages in thread
From: Antoine Tenart @ 2017-06-07 6:17 UTC (permalink / raw)
To: davem, netdev, thomas.petazzoni
Cc: Antoine Tenart, gregory.clement, mw, linux, linux-arm-kernel
The mvpp22_port_mii_set() function was added by 2697582144dd, but the
function directly returns without doing anything. This return was used
when debugging and wasn't removed before sending the patch. Fix this.
Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Since v1:
- Added the Fixes tag.
- Added Thomas' Acked-by.
drivers/net/ethernet/marvell/mvpp2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index 9b875d776b29..70bca2a6fb02 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -4186,8 +4186,6 @@ static void mvpp22_port_mii_set(struct mvpp2_port *port)
{
u32 val;
- return;
-
/* Only GOP port 0 has an XLG MAC */
if (port->gop_id == 0) {
val = readl(port->base + MVPP22_XLG_CTRL3_REG);
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] net: mvpp2: do not bypass the mvpp22_port_mii_set function
@ 2017-06-07 6:17 ` Antoine Tenart
0 siblings, 0 replies; 4+ messages in thread
From: Antoine Tenart @ 2017-06-07 6:17 UTC (permalink / raw)
To: linux-arm-kernel
The mvpp22_port_mii_set() function was added by 2697582144dd, but the
function directly returns without doing anything. This return was used
when debugging and wasn't removed before sending the patch. Fix this.
Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Since v1:
- Added the Fixes tag.
- Added Thomas' Acked-by.
drivers/net/ethernet/marvell/mvpp2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index 9b875d776b29..70bca2a6fb02 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -4186,8 +4186,6 @@ static void mvpp22_port_mii_set(struct mvpp2_port *port)
{
u32 val;
- return;
-
/* Only GOP port 0 has an XLG MAC */
if (port->gop_id == 0) {
val = readl(port->base + MVPP22_XLG_CTRL3_REG);
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] net: mvpp2: do not bypass the mvpp22_port_mii_set function
2017-06-07 6:17 ` Antoine Tenart
@ 2017-06-07 19:08 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-06-07 19:08 UTC (permalink / raw)
To: antoine.tenart
Cc: netdev, thomas.petazzoni, gregory.clement, mw, linux, linux-arm-kernel
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Wed, 7 Jun 2017 08:17:50 +0200
> The mvpp22_port_mii_set() function was added by 2697582144dd, but the
> function directly returns without doing anything. This return was used
> when debugging and wasn't removed before sending the patch. Fix this.
>
> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] net: mvpp2: do not bypass the mvpp22_port_mii_set function
@ 2017-06-07 19:08 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-06-07 19:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Wed, 7 Jun 2017 08:17:50 +0200
> The mvpp22_port_mii_set() function was added by 2697582144dd, but the
> function directly returns without doing anything. This return was used
> when debugging and wasn't removed before sending the patch. Fix this.
>
> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-07 19:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-07 6:17 [PATCH v2] net: mvpp2: do not bypass the mvpp22_port_mii_set function Antoine Tenart
2017-06-07 6:17 ` Antoine Tenart
2017-06-07 19:08 ` David Miller
2017-06-07 19:08 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.