[PATCH] u-boot: enable dhcp for MPC8315 board

[PATCH] u-boot: enable dhcp for MPC8315 board

[Ed Bartosh]

Getting ip address from DHCP server is much more convenient
than setting static ip. It allows to configure u-boot in
more generic way and to avoid hardcoding static ip in
u-boot configuration.

Enabled dhcp client functionality for Yocto reference
hardware MPC8315E-RDB.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
index df24c85..8ee1c32 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"
-- 
2.1.4

Re: [PATCH] u-boot: enable dhcp for MPC8315 board

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

On 7 June 2017 at 13:05, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:

> +    file://MPC8315ERDB-enable-DHCP.patch \
>

This file isn't in the patch.

Ross

[-- Attachment #2: Type: text/html, Size: 590 bytes --]

[PATCH v2] u-boot: enable dhcp for MPC8315 board

[Ed Bartosh]

Getting ip address from DHCP server is much more convenient
than setting static ip. It allows to configure u-boot in
more generic way and to avoid hardcoding static ip in
u-boot configuration.

Enabled dhcp client functionality for Yocto reference
hardware MPC8315E-RDB.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12 ++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

diff --git a/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
new file mode 100644
index 0000000..df89e05
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
@@ -0,0 +1,12 @@
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y
diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
index df24c85..8ee1c32 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"
-- 
2.1.4

[PATCH v2] u-boot: enable dhcp for MPC8315 board

[Ed Bartosh]

Getting ip address from DHCP server is much more convenient
than setting static ip. It allows to configure u-boot in
more generic way and to avoid hardcoding static ip in
u-boot configuration.

Enabled dhcp client functionality for Yocto reference
hardware MPC8315E-RDB.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12 ++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4 +++-
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

diff --git a/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
new file mode 100644
index 0000000..df89e05
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
@@ -0,0 +1,12 @@
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y
diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
index df24c85..8ee1c32 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"
-- 
2.1.4

✗ patchtest: failure for u-boot: enable dhcp for MPC8315 board (rev2)

[Patchwork]

== Series Details ==

Series: u-boot: enable dhcp for MPC8315 board (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/7108/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Added patch file is missing Upstream-Status in the header [test_upstream_status_presence] 
  Suggested fix    Add Upstream-Status: <status> to the header of meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate)

* Issue             A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence] 
  Suggested fix    Sign off the added patch file (meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH v2] u-boot: enable dhcp for MPC8315 board

[Richard Purdie]

On Wed, 2017-06-07 at 15:28 +0300, Ed Bartosh wrote:
> Getting ip address from DHCP server is much more convenient
> than setting static ip. It allows to configure u-boot in
> more generic way and to avoid hardcoding static ip in
> u-boot configuration.
> 
> Enabled dhcp client functionality for Yocto reference
> hardware MPC8315E-RDB.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12
> ++++++++++++
>  meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4
> +++-
>  2 files changed, 15 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-
> DHCP.patch

These files are in OE-Core, not meta-yocto but you sent them to the
poky list?

Cheers,

Richard

Re: [PATCH v2] u-boot: enable dhcp for MPC8315 board

[Ed Bartosh]

sorry, wrong list
please, ignore

On Wed, Jun 07, 2017 at 03:28:09PM +0300, Ed Bartosh wrote:
> Getting ip address from DHCP server is much more convenient
> than setting static ip. It allows to configure u-boot in
> more generic way and to avoid hardcoding static ip in
> u-boot configuration.
> 
> Enabled dhcp client functionality for Yocto reference
> hardware MPC8315E-RDB.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
>  meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12 ++++++++++++
>  meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4 +++-
>  2 files changed, 15 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
> 
> diff --git a/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
> new file mode 100644
> index 0000000..df89e05
> --- /dev/null
> +++ b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
> @@ -0,0 +1,12 @@
> +diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
> +index 4e2b705..b02ab1f 100644
> +--- a/configs/MPC8315ERDB_defconfig
> ++++ b/configs/MPC8315ERDB_defconfig
> +@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
> + CONFIG_CMD_I2C=y
> + CONFIG_CMD_USB=y
> + # CONFIG_CMD_SETEXPR is not set
> ++CONFIG_CMD_DHCP=y
> + CONFIG_CMD_MII=y
> + CONFIG_CMD_PING=y
> + CONFIG_CMD_EXT2=y
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
> index df24c85..8ee1c32 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
> @@ -9,6 +9,8 @@ PE = "1"
>  # repo during parse
>  SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
>  
> -SRC_URI = "git://git.denx.de/u-boot.git"
> +SRC_URI = "git://git.denx.de/u-boot.git \
> +    file://MPC8315ERDB-enable-DHCP.patch \
> +"
>  
>  S = "${WORKDIR}/git"
> -- 
> 2.1.4
> 

-- 
--
Regards,
Ed

[PATCH v3] u-boot: enable dhcp for MPC8315 board

[Ed Bartosh]

Getting ip address from DHCP server is much more convenient
than setting static ip. It allows to configure u-boot in
more generic way and to avoid hardcoding static ip in
u-boot configuration.

Enabled dhcp client functionality for Yocto reference
hardware MPC8315E-RDB.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 .../u-boot/files/MPC8315ERDB-enable-DHCP.patch        | 19 +++++++++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc     |  4 +++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

diff --git a/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
new file mode 100644
index 0000000..5a41108
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
@@ -0,0 +1,19 @@
+Enabled dhcp client functionality for Yocto reference
+hardware MPC8315E-RDB.
+
+Upstream-Status: Submitted
+
+Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
+
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y
diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
index df24c85..8ee1c32 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"
-- 
2.1.4

[PATCH v4] u-boot: enable dhcp for MPC8315 board

[Ed Bartosh]

Getting ip address from DHCP server is much more convenient
than setting static ip. It allows to configure u-boot in
more generic way and to avoid hardcoding static ip in
u-boot configuration.

Enabled dhcp client functionality for Yocto reference
hardware MPC8315E-RDB.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
 .../u-boot/files/MPC8315ERDB-enable-DHCP.patch        | 19 +++++++++++++++++++
 meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc     |  4 +++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

diff --git a/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
new file mode 100644
index 0000000..cea52b7
--- /dev/null
+++ b/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
@@ -0,0 +1,19 @@
+Enabled dhcp client functionality for Yocto reference
+hardware MPC8315E-RDB.
+
+Upstream-Status: Pending
+
+Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
+
+diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
+index 4e2b705..b02ab1f 100644
+--- a/configs/MPC8315ERDB_defconfig
++++ b/configs/MPC8315ERDB_defconfig
+@@ -9,6 +9,7 @@ CONFIG_HUSH_PARSER=y
+ CONFIG_CMD_I2C=y
+ CONFIG_CMD_USB=y
+ # CONFIG_CMD_SETEXPR is not set
++CONFIG_CMD_DHCP=y
+ CONFIG_CMD_MII=y
+ CONFIG_CMD_PING=y
+ CONFIG_CMD_EXT2=y
diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
index df24c85..8ee1c32 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc
@@ -9,6 +9,8 @@ PE = "1"
 # repo during parse
 SRCREV = "a705ebc81b7f91bbd0ef7c634284208342901149"
 
-SRC_URI = "git://git.denx.de/u-boot.git"
+SRC_URI = "git://git.denx.de/u-boot.git \
+    file://MPC8315ERDB-enable-DHCP.patch \
+"
 
 S = "${WORKDIR}/git"
-- 
2.1.4

Re: [PATCH v2] u-boot: enable dhcp for MPC8315 board

[Tom Rini]

On Wed, Jun 07, 2017 at 01:32:28PM +0100, Richard Purdie wrote:
> On Wed, 2017-06-07 at 15:28 +0300, Ed Bartosh wrote:
> > Getting ip address from DHCP server is much more convenient
> > than setting static ip. It allows to configure u-boot in
> > more generic way and to avoid hardcoding static ip in
> > u-boot configuration.
> > 
> > Enabled dhcp client functionality for Yocto reference
> > hardware MPC8315E-RDB.
> > 
> > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> > ---
> >  meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch | 12
> > ++++++++++++
> >  meta/recipes-bsp/u-boot/u-boot-common_2017.01.inc           |  4
> > +++-
> >  2 files changed, 15 insertions(+), 1 deletion(-)
> >  create mode 100644 meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-
> > DHCP.patch
> 
> These files are in OE-Core, not meta-yocto but you sent them to the
> poky list?

And really ought to be upstreamed? :)

-- 
Tom

Re: [poky] [PATCH v2] u-boot: enable dhcp for MPC8315 board

[Trevor Woerner]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Wed, Jun 7, 2017 at 8:43 PM, Tom Rini <trini@konsulko.com> wrote:

> On Wed, Jun 07, 2017 at 01:32:28PM +0100, Richard Purdie wrote:
> > On Wed, 2017-06-07 at 15:28 +0300, Ed Bartosh wrote:
> > > Getting ip address from DHCP server is much more convenient
> > > than setting static ip. It allows to configure u-boot in
> > > more generic way and to avoid hardcoding static ip in
> > > u-boot configuration.
> > >
> > > Enabled dhcp client functionality for Yocto reference
> > > hardware MPC8315E-RDB.
>

Is this really something that should be part of the oe-core recipe? This
looks more like something one would find in a BSP layer.

[-- Attachment #2: Type: text/html, Size: 1049 bytes --]

Re: [poky] [PATCH v2] u-boot: enable dhcp for MPC8315 board

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

On Thu, May 03, 2018 at 10:01:54PM -0400, Trevor Woerner wrote:
> On Wed, Jun 7, 2017 at 8:43 PM, Tom Rini <trini@konsulko.com> wrote:
> 
> > On Wed, Jun 07, 2017 at 01:32:28PM +0100, Richard Purdie wrote:
> > > On Wed, 2017-06-07 at 15:28 +0300, Ed Bartosh wrote:
> > > > Getting ip address from DHCP server is much more convenient
> > > > than setting static ip. It allows to configure u-boot in
> > > > more generic way and to avoid hardcoding static ip in
> > > > u-boot configuration.
> > > >
> > > > Enabled dhcp client functionality for Yocto reference
> > > > hardware MPC8315E-RDB.
> 
> Is this really something that should be part of the oe-core recipe? This
> looks more like something one would find in a BSP layer.

It was since it was needed to make this reference BSP slightly more
usable.  It's since been merged upstream.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]