* [PATCH] IB/qib: remove duplicate code
@ 2017-06-07 20:42 Gustavo A. R. Silva
2017-06-08 10:37 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-07 20:42 UTC (permalink / raw)
To: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva
Remove duplicate code.
Addresses-Coverity-ID: 1226951
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/infiniband/hw/qib/qib_mad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index da295e0..c5eaa3c 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
ib_dispatch_event(&event);
}
- ret = subn_get_portinfo(smp, ibdev, port);
-
/* restore re-reg bit per o14-12.2.1 */
pip->clientrereg_resv_subnetto |= clientrereg;
--
2.5.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
2017-06-07 20:42 [PATCH] IB/qib: remove duplicate code Gustavo A. R. Silva
@ 2017-06-08 10:37 ` Leon Romanovsky
2017-06-08 13:14 ` Dennis Dalessandro
2017-07-22 17:20 ` Doug Ledford
2 siblings, 0 replies; 11+ messages in thread
From: Leon Romanovsky @ 2017-06-08 10:37 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Wed, Jun 07, 2017 at 03:42:02PM -0500, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
> ---
> drivers/infiniband/hw/qib/qib_mad.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
@ 2017-06-08 10:37 ` Leon Romanovsky
0 siblings, 0 replies; 11+ messages in thread
From: Leon Romanovsky @ 2017-06-08 10:37 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
On Wed, Jun 07, 2017 at 03:42:02PM -0500, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/qib/qib_mad.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
2017-06-07 20:42 [PATCH] IB/qib: remove duplicate code Gustavo A. R. Silva
@ 2017-06-08 13:14 ` Dennis Dalessandro
2017-06-08 13:14 ` Dennis Dalessandro
2017-07-22 17:20 ` Doug Ledford
2 siblings, 0 replies; 11+ messages in thread
From: Dennis Dalessandro @ 2017-06-08 13:14 UTC (permalink / raw)
To: Gustavo A. R. Silva, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
> ---
> drivers/infiniband/hw/qib/qib_mad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
> index da295e0..c5eaa3c 100644
> --- a/drivers/infiniband/hw/qib/qib_mad.c
> +++ b/drivers/infiniband/hw/qib/qib_mad.c
> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
> ib_dispatch_event(&event);
> }
>
> - ret = subn_get_portinfo(smp, ibdev, port);
> -
> /* restore re-reg bit per o14-12.2.1 */
> pip->clientrereg_resv_subnetto |= clientrereg;
>
>
Would be nice to see a few more words in the commit message rather than
having to go look for Coverity.
Regardless, patch seems fine to me code wise.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
@ 2017-06-08 13:14 ` Dennis Dalessandro
0 siblings, 0 replies; 11+ messages in thread
From: Dennis Dalessandro @ 2017-06-08 13:14 UTC (permalink / raw)
To: Gustavo A. R. Silva, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock
Cc: linux-rdma, linux-kernel
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/qib/qib_mad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
> index da295e0..c5eaa3c 100644
> --- a/drivers/infiniband/hw/qib/qib_mad.c
> +++ b/drivers/infiniband/hw/qib/qib_mad.c
> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
> ib_dispatch_event(&event);
> }
>
> - ret = subn_get_portinfo(smp, ibdev, port);
> -
> /* restore re-reg bit per o14-12.2.1 */
> pip->clientrereg_resv_subnetto |= clientrereg;
>
>
Would be nice to see a few more words in the commit message rather than
having to go look for Coverity.
Regardless, patch seems fine to me code wise.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
2017-06-08 13:14 ` Dennis Dalessandro
@ 2017-06-08 19:52 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 11+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-08 19:52 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Dennis,
Quoting Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>:
> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
>> ---
>> drivers/infiniband/hw/qib/qib_mad.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/qib/qib_mad.c
>> b/drivers/infiniband/hw/qib/qib_mad.c
>> index da295e0..c5eaa3c 100644
>> --- a/drivers/infiniband/hw/qib/qib_mad.c
>> +++ b/drivers/infiniband/hw/qib/qib_mad.c
>> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp
>> *smp, struct ib_device *ibdev,
>> ib_dispatch_event(&event);
>> }
>> - ret = subn_get_portinfo(smp, ibdev, port);
>> -
>> /* restore re-reg bit per o14-12.2.1 */
>> pip->clientrereg_resv_subnetto |= clientrereg;
>>
>
> Would be nice to see a few more words in the commit message rather
> than having to go look for Coverity.
>
I'll take note of that.
> Regardless, patch seems fine to me code wise.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Thank you
--
Gustavo A. R. Silva
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
@ 2017-06-08 19:52 ` Gustavo A. R. Silva
0 siblings, 0 replies; 11+ messages in thread
From: Gustavo A. R. Silva @ 2017-06-08 19:52 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma, linux-kernel
Hi Dennis,
Quoting Dennis Dalessandro <dennis.dalessandro@intel.com>:
> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/infiniband/hw/qib/qib_mad.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/qib/qib_mad.c
>> b/drivers/infiniband/hw/qib/qib_mad.c
>> index da295e0..c5eaa3c 100644
>> --- a/drivers/infiniband/hw/qib/qib_mad.c
>> +++ b/drivers/infiniband/hw/qib/qib_mad.c
>> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp
>> *smp, struct ib_device *ibdev,
>> ib_dispatch_event(&event);
>> }
>> - ret = subn_get_portinfo(smp, ibdev, port);
>> -
>> /* restore re-reg bit per o14-12.2.1 */
>> pip->clientrereg_resv_subnetto |= clientrereg;
>>
>
> Would be nice to see a few more words in the commit message rather
> than having to go look for Coverity.
>
I'll take note of that.
> Regardless, patch seems fine to me code wise.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Thank you
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
2017-06-07 20:42 [PATCH] IB/qib: remove duplicate code Gustavo A. R. Silva
2017-06-08 10:37 ` Leon Romanovsky
2017-06-08 13:14 ` Dennis Dalessandro
@ 2017-07-22 17:20 ` Doug Ledford
[not found] ` <0d5d4e1c-ee2f-2ecb-bf25-b95954cbb5f7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2 siblings, 1 reply; 11+ messages in thread
From: Doug Ledford @ 2017-07-22 17:20 UTC (permalink / raw)
To: Gustavo A. R. Silva, Mike Marciniszyn, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 659 bytes --]
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
This patch was accepted into 4.13-rc, thanks.
In addition, I no longer have the original email for another patch of
yours that was also accepted into 4.13-rc. You created the patch in a
thread asking about the argument position for argument usage in
ib_init_ah_from_wc(). Your comment addition was accepted as well.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
2017-07-22 17:20 ` Doug Ledford
@ 2017-07-22 17:22 ` Doug Ledford
0 siblings, 0 replies; 11+ messages in thread
From: Doug Ledford @ 2017-07-22 17:22 UTC (permalink / raw)
To: Gustavo A. R. Silva, Mike Marciniszyn, Sean Hefty, Hal Rosenstock
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]
On 7/22/2017 1:20 PM, Doug Ledford wrote:
> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
>
> This patch was accepted into 4.13-rc, thanks.
Correction, this patch is in my queue for my for-next branch, only the
other patch, referenced below, made it into 4.13-rc.
> In addition, I no longer have the original email for another patch of
> yours that was also accepted into 4.13-rc. You created the patch in a
> thread asking about the argument position for argument usage in
> ib_init_ah_from_wc(). Your comment addition was accepted as well.
>
>
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
@ 2017-07-22 17:22 ` Doug Ledford
0 siblings, 0 replies; 11+ messages in thread
From: Doug Ledford @ 2017-07-22 17:22 UTC (permalink / raw)
To: Gustavo A. R. Silva, Mike Marciniszyn, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]
On 7/22/2017 1:20 PM, Doug Ledford wrote:
> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> This patch was accepted into 4.13-rc, thanks.
Correction, this patch is in my queue for my for-next branch, only the
other patch, referenced below, made it into 4.13-rc.
> In addition, I no longer have the original email for another patch of
> yours that was also accepted into 4.13-rc. You created the patch in a
> thread asking about the argument position for argument usage in
> ib_init_ah_from_wc(). Your comment addition was accepted as well.
>
>
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] IB/qib: remove duplicate code
2017-07-22 17:22 ` Doug Ledford
(?)
@ 2017-07-22 17:29 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 11+ messages in thread
From: Gustavo A. R. Silva @ 2017-07-22 17:29 UTC (permalink / raw)
To: Doug Ledford, Mike Marciniszyn, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, linux-kernel
Hi Doug,
On 07/22/2017 12:22 PM, Doug Ledford wrote:
> On 7/22/2017 1:20 PM, Doug Ledford wrote:
>> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>>> Remove duplicate code.
>>>
>>> Addresses-Coverity-ID: 1226951
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>>
>> This patch was accepted into 4.13-rc, thanks.
>
> Correction, this patch is in my queue for my for-next branch, only the
> other patch, referenced below, made it into 4.13-rc.
>
That's cool.
>> In addition, I no longer have the original email for another patch of
>> yours that was also accepted into 4.13-rc. You created the patch in a
>> thread asking about the argument position for argument usage in
>> ib_init_ah_from_wc(). Your comment addition was accepted as well.
>>
>>
Yeah, I noticed that. I'm glad to help out. :)
Thank you
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-07-22 17:29 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-07 20:42 [PATCH] IB/qib: remove duplicate code Gustavo A. R. Silva
2017-06-08 10:37 ` Leon Romanovsky
2017-06-08 10:37 ` Leon Romanovsky
2017-06-08 13:14 ` Dennis Dalessandro
2017-06-08 13:14 ` Dennis Dalessandro
[not found] ` <e5d9e8ea-460c-5318-e218-44449e6a3af7-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-08 19:52 ` Gustavo A. R. Silva
2017-06-08 19:52 ` Gustavo A. R. Silva
2017-07-22 17:20 ` Doug Ledford
[not found] ` <0d5d4e1c-ee2f-2ecb-bf25-b95954cbb5f7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-22 17:22 ` Doug Ledford
2017-07-22 17:22 ` Doug Ledford
2017-07-22 17:29 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.