* [PATCH] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
@ 2017-06-08 11:50 Martin Peres
2017-06-08 12:30 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Martin Peres @ 2017-06-08 11:50 UTC (permalink / raw)
To: intel-gfx
I would like to send this patch to the core-for-CI branch, in order to
verify the theory I exposed in fdo#101246.
This patch also hides a potentially serious bug in the sound/hda
driver, which may improve our chances of not being affected by
bugs there. It may actually also fix some of the incompletes we see.
This patch introduces a new keyword (INTEL-GFX-CI-WARN) that IGT can
pick up on in order to report a dmesg-warn.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101246
---
sound/pci/hda/hda_generic.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 557ecfcad158..a59f13d2ea45 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -4471,7 +4471,19 @@ EXPORT_SYMBOL_GPL(snd_hda_gen_mic_autoswitch);
static void call_hp_automute(struct hda_codec *codec,
struct hda_jack_callback *jack)
{
- struct hda_gen_spec *spec = codec->spec;
+ struct hda_gen_spec *spec;
+
+ if (!codec) {
+ printk("INTEL-GFX-CI-WARN: call_hp_automute called with codec == NULL");
+ return;
+ }
+
+ spec = codec->spec;
+ if (!spec) {
+ printk("INTEL-GFX-CI-WARN: call_hp_automute called with codec->spec == NULL");
+ return;
+ }
+
if (spec->hp_automute_hook)
spec->hp_automute_hook(codec, jack);
else
--
2.13.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
2017-06-08 11:50 [PATCH] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute Martin Peres
@ 2017-06-08 12:30 ` Patchwork
2017-06-08 14:17 ` [PATCH v2] " Martin Peres
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-06-08 12:30 UTC (permalink / raw)
To: Martin Peres; +Cc: intel-gfx
== Series Details ==
Series: NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
URL : https://patchwork.freedesktop.org/series/25472/
State : success
== Summary ==
Series 25472v1 NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
https://patchwork.freedesktop.org/api/1.0/series/25472/revisions/1/mbox/
Test kms_busy:
Subgroup basic-flip-default-a:
pass -> DMESG-WARN (fi-skl-6700hq) fdo#101144 +1
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:450s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:438s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:579s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:511s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:445s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:484s
fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:590s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:432s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:415s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:421s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:487s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:467s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:466s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:577s
fi-kbl-r total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:568s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:460s
fi-skl-6700hq total:278 pass:228 dwarn:1 dfail:0 fail:27 skip:22 time:397s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:466s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:498s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:435s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:534s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time:395s
24db004734623b21acb25f58084e5b8eadc4f908 drm-tip: 2017y-06m-08d-09h-22m-33s UTC integration manifest
6ec2707 NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4910/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
2017-06-08 11:50 [PATCH] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute Martin Peres
2017-06-08 12:30 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-06-08 14:17 ` Martin Peres
2017-06-09 10:57 ` [PATCH v3] " Martin Peres
2017-06-08 15:11 ` ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev2) Patchwork
2017-06-09 11:16 ` ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev3) Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Martin Peres @ 2017-06-08 14:17 UTC (permalink / raw)
To: intel-gfx
I would like to send this patch to the core-for-CI branch, in order to
verify the theory I exposed in fdo#101246.
This patch also hides a potentially serious bug in the sound/hda
driver, which may improve our chances of not being affected by
bugs there. It may actually also fix some of the incompletes we see.
v2: use WARN() instead of printf with a custom string
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101246
---
sound/pci/hda/hda_generic.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 557ecfcad158..58dda5a52638 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -4471,7 +4471,15 @@ EXPORT_SYMBOL_GPL(snd_hda_gen_mic_autoswitch);
static void call_hp_automute(struct hda_codec *codec,
struct hda_jack_callback *jack)
{
- struct hda_gen_spec *spec = codec->spec;
+ struct hda_gen_spec *spec;
+
+ if (WARN(!codec, "call_hp_automute called with codec == NULL"))
+ return;
+
+ spec = codec->spec;
+ if (WARN(!spec, "call_hp_automute called with codec->spec == NULL"))
+ printk("INTEL-GFX-CI-WARN: ");
+
if (spec->hp_automute_hook)
spec->hp_automute_hook(codec, jack);
else
--
2.13.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev2)
2017-06-08 11:50 [PATCH] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute Martin Peres
2017-06-08 12:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-08 14:17 ` [PATCH v2] " Martin Peres
@ 2017-06-08 15:11 ` Patchwork
2017-06-09 11:16 ` ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev3) Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-06-08 15:11 UTC (permalink / raw)
To: Martin Peres; +Cc: intel-gfx
== Series Details ==
Series: NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev2)
URL : https://patchwork.freedesktop.org/series/25472/
State : success
== Summary ==
Series 25472v2 NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
https://patchwork.freedesktop.org/api/1.0/series/25472/revisions/2/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125
Test kms_busy:
Subgroup basic-flip-default-b:
fail -> DMESG-WARN (fi-skl-6700hq) fdo#101144
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:445s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:432s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:586s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:513s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:484s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:484s
fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:585s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:429s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:413s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:419s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:493s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:470s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:465s
fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:569s
fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:574s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:458s
fi-skl-6700hq total:278 pass:228 dwarn:2 dfail:0 fail:26 skip:22 time:402s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:466s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:508s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:439s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:533s
fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time:401s
17f9a91122b35ff8eb237b65fec35d347ee49520 drm-tip: 2017y-06m-08d-14h-17m-12s UTC integration manifest
e492be8 NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4911/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
2017-06-08 14:17 ` [PATCH v2] " Martin Peres
@ 2017-06-09 10:57 ` Martin Peres
0 siblings, 0 replies; 6+ messages in thread
From: Martin Peres @ 2017-06-09 10:57 UTC (permalink / raw)
To: intel-gfx
I would like to send this patch to the core-for-CI branch, in order to
verify the theory I exposed in fdo#101246.
This patch also hides a potentially serious bug in the sound/hda
driver, which may improve our chances of not being affected by
bugs there. It may actually also fix some of the incompletes we see.
v2: use WARN() instead of printk with a custom string
v3: return if spec is NULL (was a typo from v2
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101246
---
Sorry, I fixed the typos introduced in the v2.
Note to self: Do not send patches right before leaving for a meeting.
sound/pci/hda/hda_generic.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 557ecfcad158..4ac24a4f2e70 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -4471,7 +4471,15 @@ EXPORT_SYMBOL_GPL(snd_hda_gen_mic_autoswitch);
static void call_hp_automute(struct hda_codec *codec,
struct hda_jack_callback *jack)
{
- struct hda_gen_spec *spec = codec->spec;
+ struct hda_gen_spec *spec;
+
+ if (WARN(!codec, "call_hp_automute called with codec == NULL"))
+ return;
+
+ spec = codec->spec;
+ if (WARN(!spec, "call_hp_automute called with codec->spec == NULL"))
+ return;
+
if (spec->hp_automute_hook)
spec->hp_automute_hook(codec, jack);
else
--
2.13.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev3)
2017-06-08 11:50 [PATCH] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute Martin Peres
` (2 preceding siblings ...)
2017-06-08 15:11 ` ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev2) Patchwork
@ 2017-06-09 11:16 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-06-09 11:16 UTC (permalink / raw)
To: Martin Peres; +Cc: intel-gfx
== Series Details ==
Series: NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev3)
URL : https://patchwork.freedesktop.org/series/25472/
State : success
== Summary ==
Series 25472v3 NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
https://patchwork.freedesktop.org/api/1.0/series/25472/revisions/3/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-snb-2600) fdo#100125 +1
Test kms_flip:
Subgroup basic-flip-vs-dpms:
skip -> PASS (fi-skl-6700hq) fdo#101144
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-6700hq)
Subgroup basic-flip-vs-wf_vblank:
skip -> PASS (fi-skl-6700hq) fdo#99739
Subgroup basic-plain-flip:
skip -> PASS (fi-skl-6700hq)
Test kms_frontbuffer_tracking:
Subgroup basic:
skip -> PASS (fi-skl-6700hq)
Test prime_vgem:
Subgroup basic-fence-flip:
skip -> PASS (fi-skl-6700hq)
fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#101144 https://bugs.freedesktop.org/show_bug.cgi?id=101144
fdo#99739 https://bugs.freedesktop.org/show_bug.cgi?id=99739
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:444s
fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:433s
fi-bsw-n3050 total:278 pass:242 dwarn:0 dfail:0 fail:0 skip:36 time:582s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:518s
fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:488s
fi-byt-n2820 total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:476s
fi-glk-2a total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:589s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:428s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:411s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:416s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:491s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:465s
fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:467s
fi-kbl-7560u total:278 pass:267 dwarn:1 dfail:0 fail:0 skip:10 time:569s
fi-kbl-r total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time:579s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:458s
fi-skl-6700hq total:278 pass:234 dwarn:1 dfail:0 fail:27 skip:16 time:490s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:468s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:476s
fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:435s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time:532s
fi-snb-2600 total:278 pass:248 dwarn:1 dfail:0 fail:0 skip:29 time:400s
5b363842b49a66879d4c67d652923fb04e44b271 drm-tip: 2017y-06m-08d-20h-34m-37s UTC integration manifest
5a8c57d NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4925/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-09 11:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-08 11:50 [PATCH] NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute Martin Peres
2017-06-08 12:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-06-08 14:17 ` [PATCH v2] " Martin Peres
2017-06-09 10:57 ` [PATCH v3] " Martin Peres
2017-06-08 15:11 ` ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev2) Patchwork
2017-06-09 11:16 ` ✓ Fi.CI.BAT: success for NOTFORUPSTREAM sound/hda: add debug information in call_hp_automute (rev3) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.