All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	narmstrong@baylibre.com, linux-amlogic@lists.infradead.org,
	linux-clk@vger.kernel.org, mturquette@baylibre.com,
	sboyd@codeaurora.org, mark.rutland@arm.com, carlo@caione.org,
	khilman@baylibre.com, linux@armlinux.org.uk,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] clk: meson: meson8b: add compatibles for Meson8 and Meson8m2
Date: Thu, 8 Jun 2017 17:44:13 -0500	[thread overview]
Message-ID: <20170608224413.fdv4xlvnjld4bgtz@rob-hp-laptop> (raw)
In-Reply-To: <1496651008.3552.24.camel@baylibre.com>

On Mon, Jun 05, 2017 at 10:23:28AM +0200, Jerome Brunet wrote:
> On Mon, 2017-06-05 at 00:27 +0200, Martin Blumenstingl wrote:
> > > I think you should split the binding documentation and clk changes into
> > > separate
> > > patches.
> > 
> > OK, from what I know is that for "trivial" changes the driver and
> > dt-binding changes can go through one patch.
> > this patch started as a four-line patch which added two lines of
> > documentation and two lines of driver code.
> 
> I'm not aware of such tolerance but if you've have seen that the DT maintainers
> are OK with it, feel free to point me to it.
> 
> Last time I heard about it, DT guys were using filter-branch on the kernel tree
> to create a separate tree, so I was thinking that this "documentation as a
> separate patch" was a hard rule ... but I may be wrong

That is one of the reasons, but there is no hard rule. It's not worth a 
respin just for that either.

Acked-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: meson: meson8b: add compatibles for Meson8 and Meson8m2
Date: Thu, 8 Jun 2017 17:44:13 -0500	[thread overview]
Message-ID: <20170608224413.fdv4xlvnjld4bgtz@rob-hp-laptop> (raw)
In-Reply-To: <1496651008.3552.24.camel@baylibre.com>

On Mon, Jun 05, 2017 at 10:23:28AM +0200, Jerome Brunet wrote:
> On Mon, 2017-06-05 at 00:27 +0200, Martin Blumenstingl wrote:
> > > I think you should split the binding documentation and clk changes into
> > > separate
> > > patches.
> > 
> > OK, from what I know is that for "trivial" changes the driver and
> > dt-binding changes can go through one patch.
> > this patch started as a four-line patch which added two lines of
> > documentation and two lines of driver code.
> 
> I'm not aware of such tolerance but if you've have seen that the DT maintainers
> are OK with it, feel free to point me to it.
> 
> Last time I heard about it, DT guys were using filter-branch on the kernel tree
> to create a separate tree, so I was thinking that this "documentation as a
> separate patch" was a hard rule ... but I may be wrong

That is one of the reasons, but there is no hard rule. It's not worth a 
respin just for that either.

Acked-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/3] clk: meson: meson8b: add compatibles for Meson8 and Meson8m2
Date: Thu, 8 Jun 2017 17:44:13 -0500	[thread overview]
Message-ID: <20170608224413.fdv4xlvnjld4bgtz@rob-hp-laptop> (raw)
In-Reply-To: <1496651008.3552.24.camel@baylibre.com>

On Mon, Jun 05, 2017 at 10:23:28AM +0200, Jerome Brunet wrote:
> On Mon, 2017-06-05 at 00:27 +0200, Martin Blumenstingl wrote:
> > > I think you should split the binding documentation and clk changes into
> > > separate
> > > patches.
> > 
> > OK, from what I know is that for "trivial" changes the driver and
> > dt-binding changes can go through one patch.
> > this patch started as a four-line patch which added two lines of
> > documentation and two lines of driver code.
> 
> I'm not aware of such tolerance but if you've have seen that the DT maintainers
> are OK with it, feel free to point me to it.
> 
> Last time I heard about it, DT guys were using filter-branch on the kernel tree
> to create a separate tree, so I was thinking that this "documentation as a
> separate patch" was a hard rule ... but I may be wrong

That is one of the reasons, but there is no hard rule. It's not worth a 
respin just for that either.

Acked-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2017-06-08 22:44 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-04 18:33 [PATCH 0/3] use the Meson8b clock controller driver on Meson8 SoCs Martin Blumenstingl
2017-06-04 18:33 ` Martin Blumenstingl
2017-06-04 18:33 ` Martin Blumenstingl
2017-06-04 18:33 ` [PATCH 1/3] clk: meson: meson8b: add compatibles for Meson8 and Meson8m2 Martin Blumenstingl
2017-06-04 18:33   ` Martin Blumenstingl
2017-06-04 18:33   ` Martin Blumenstingl
     [not found]   ` <20170604183341.21417-2-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2017-06-04 19:58     ` Jerome Brunet
2017-06-04 19:58       ` Jerome Brunet
2017-06-04 19:58       ` Jerome Brunet
2017-06-04 19:58       ` Jerome Brunet
2017-06-04 22:27       ` Martin Blumenstingl
2017-06-04 22:27         ` Martin Blumenstingl
2017-06-04 22:27         ` Martin Blumenstingl
2017-06-05  8:23         ` Jerome Brunet
2017-06-05  8:23           ` Jerome Brunet
2017-06-05  8:23           ` Jerome Brunet
2017-06-05  8:23           ` Jerome Brunet
2017-06-08 22:44           ` Rob Herring [this message]
2017-06-08 22:44             ` Rob Herring
2017-06-08 22:44             ` Rob Herring
     [not found]       ` <1496606325.3552.16.camel-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-06-09 18:13         ` Kevin Hilman
2017-06-09 18:13           ` Kevin Hilman
2017-06-09 18:13           ` Kevin Hilman
2017-06-09 18:13           ` Kevin Hilman
     [not found]           ` <m2lgp19ghu.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-06-12  7:40             ` Jerome Brunet
2017-06-12  7:40               ` Jerome Brunet
2017-06-12  7:40               ` Jerome Brunet
2017-06-12  7:40               ` Jerome Brunet
2017-06-04 18:33 ` [PATCH 2/3] arm: meson: select the clock controller for Meson8 Martin Blumenstingl
2017-06-04 18:33   ` Martin Blumenstingl
2017-06-04 18:33   ` Martin Blumenstingl
2017-06-04 20:02   ` Jerome Brunet
2017-06-04 20:02     ` Jerome Brunet
2017-06-04 20:02     ` Jerome Brunet
2017-06-09 18:21     ` Kevin Hilman
2017-06-09 18:21       ` Kevin Hilman
2017-06-09 18:21       ` Kevin Hilman
2017-06-09 18:21       ` Kevin Hilman
     [not found] ` <20170604183341.21417-1-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2017-06-04 18:33   ` [PATCH 3/3] ARM: dts: meson8: add and use the real clock controller Martin Blumenstingl
2017-06-04 18:33     ` Martin Blumenstingl
2017-06-04 18:33     ` Martin Blumenstingl
2017-06-04 18:33     ` Martin Blumenstingl
2017-06-04 20:20     ` Jerome Brunet
2017-06-04 20:20       ` Jerome Brunet
2017-06-04 20:20       ` Jerome Brunet
2017-06-04 22:13       ` Martin Blumenstingl
2017-06-04 22:13         ` Martin Blumenstingl
2017-06-04 22:13         ` Martin Blumenstingl
2017-06-07 11:55         ` Neil Armstrong
2017-06-07 11:55           ` Neil Armstrong
2017-06-07 11:55           ` Neil Armstrong
2017-06-07 11:55           ` Neil Armstrong
2017-06-09 18:22       ` Kevin Hilman
2017-06-09 18:22         ` Kevin Hilman
2017-06-09 18:22         ` Kevin Hilman
2017-06-09 18:22         ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608224413.fdv4xlvnjld4bgtz@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.