All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
       [not found] <CGME20170609025951epcas1p19f5ca8c241b8b79068a84eb239ed46ed@epcas1p1.samsung.com>
  2017-06-09  2:59   ` Hoegeun Kwon
@ 2017-06-09  2:59   ` Hoegeun Kwon
  0 siblings, 0 replies; 8+ messages in thread
From: Hoegeun Kwon @ 2017-06-09  2:59 UTC (permalink / raw)
  To: krzk, inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, robh+dt,
	mark.rutland, catalin.marinas, will.deacon
  Cc: javier, dri-devel, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, devicetree, a.hajda, Hoegeun Kwon

It should be connected to OF graph between fimd and dsi.
Add the OF graph between fimd and dsi.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
 arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 590ee44..22d523f 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -311,6 +311,19 @@
 			iommus = <&sysmmu_fimd0>;
 			samsung,sysreg = <&sys_reg>;
 			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					fimd_to_dsi: endpoint {
+						remote-endpoint =
+							<&dsi_to_fimd>;
+					};
+				};
+			};
 		};
 
 		dsi_0: dsi@11C80000 {
@@ -326,6 +339,19 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					dsi_to_fimd: endpoint {
+						remote-endpoint =
+							<&fimd_to_dsi>;
+					};
+				};
+			};
 		};
 
 		sysmmu_fimd0: sysmmu@11E20000 {
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 497a947..773d392 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -193,6 +193,19 @@
 		status = "disabled";
 		#address-cells = <1>;
 		#size-cells = <0>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				dsi_to_fimd: endpoint {
+					remote-endpoint =
+						<&fimd_to_dsi>;
+				};
+			};
+		};
 	};
 
 	camera {
@@ -715,6 +728,19 @@
 		iommus = <&sysmmu_fimd0>;
 		samsung,sysreg = <&sys_reg>;
 		status = "disabled";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				fimd_to_dsi: endpoint {
+					remote-endpoint =
+						<&dsi_to_fimd>;
+				};
+			};
+		};
 	};
 
 	tmu: tmu@100C0000 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
@ 2017-06-09  2:59   ` Hoegeun Kwon
  0 siblings, 0 replies; 8+ messages in thread
From: Hoegeun Kwon @ 2017-06-09  2:59 UTC (permalink / raw)
  To: krzk, inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, robh+dt,
	mark.rutland, catalin.marinas, will.deacon
  Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier,
	Hoegeun Kwon, linux-arm-kernel

It should be connected to OF graph between fimd and dsi.
Add the OF graph between fimd and dsi.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
 arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 590ee44..22d523f 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -311,6 +311,19 @@
 			iommus = <&sysmmu_fimd0>;
 			samsung,sysreg = <&sys_reg>;
 			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					fimd_to_dsi: endpoint {
+						remote-endpoint =
+							<&dsi_to_fimd>;
+					};
+				};
+			};
 		};
 
 		dsi_0: dsi@11C80000 {
@@ -326,6 +339,19 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					dsi_to_fimd: endpoint {
+						remote-endpoint =
+							<&fimd_to_dsi>;
+					};
+				};
+			};
 		};
 
 		sysmmu_fimd0: sysmmu@11E20000 {
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 497a947..773d392 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -193,6 +193,19 @@
 		status = "disabled";
 		#address-cells = <1>;
 		#size-cells = <0>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				dsi_to_fimd: endpoint {
+					remote-endpoint =
+						<&fimd_to_dsi>;
+				};
+			};
+		};
 	};
 
 	camera {
@@ -715,6 +728,19 @@
 		iommus = <&sysmmu_fimd0>;
 		samsung,sysreg = <&sys_reg>;
 		status = "disabled";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				fimd_to_dsi: endpoint {
+					remote-endpoint =
+						<&dsi_to_fimd>;
+				};
+			};
+		};
 	};
 
 	tmu: tmu@100C0000 {
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
@ 2017-06-09  2:59   ` Hoegeun Kwon
  0 siblings, 0 replies; 8+ messages in thread
From: Hoegeun Kwon @ 2017-06-09  2:59 UTC (permalink / raw)
  To: linux-arm-kernel

It should be connected to OF graph between fimd and dsi.
Add the OF graph between fimd and dsi.

Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
 arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
 2 files changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 590ee44..22d523f 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -311,6 +311,19 @@
 			iommus = <&sysmmu_fimd0>;
 			samsung,sysreg = <&sys_reg>;
 			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port at 0 {
+					reg = <0>;
+					fimd_to_dsi: endpoint {
+						remote-endpoint =
+							<&dsi_to_fimd>;
+					};
+				};
+			};
 		};
 
 		dsi_0: dsi at 11C80000 {
@@ -326,6 +339,19 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port at 0 {
+					reg = <0>;
+					dsi_to_fimd: endpoint {
+						remote-endpoint =
+							<&fimd_to_dsi>;
+					};
+				};
+			};
 		};
 
 		sysmmu_fimd0: sysmmu at 11E20000 {
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 497a947..773d392 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -193,6 +193,19 @@
 		status = "disabled";
 		#address-cells = <1>;
 		#size-cells = <0>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+				dsi_to_fimd: endpoint {
+					remote-endpoint =
+						<&fimd_to_dsi>;
+				};
+			};
+		};
 	};
 
 	camera {
@@ -715,6 +728,19 @@
 		iommus = <&sysmmu_fimd0>;
 		samsung,sysreg = <&sys_reg>;
 		status = "disabled";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+				fimd_to_dsi: endpoint {
+					remote-endpoint =
+						<&dsi_to_fimd>;
+				};
+			};
+		};
 	};
 
 	tmu: tmu at 100C0000 {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
  2017-06-09  2:59   ` Hoegeun Kwon
@ 2017-06-09  7:27     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2017-06-09  7:27 UTC (permalink / raw)
  To: Hoegeun Kwon
  Cc: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, robh+dt,
	mark.rutland, catalin.marinas, will.deacon, javier, dri-devel,
	linux-arm-kernel, linux-samsung-soc, linux-kernel, devicetree,
	a.hajda

On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
> It should be connected to OF graph between fimd and dsi.
> Add the OF graph between fimd and dsi.

I need more explanation why this is needed. What happens without this?
What issue is fixed here?

What about Exynos5250 and Exynos5420? I think we do not have a board in
mainline using FIMD but maybe this should be added just for correct
hardware description?


Best regards,
Krzysztof

> 
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>  arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
>  2 files changed, 52 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index 590ee44..22d523f 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -311,6 +311,19 @@
>  			iommus = <&sysmmu_fimd0>;
>  			samsung,sysreg = <&sys_reg>;
>  			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					fimd_to_dsi: endpoint {
> +						remote-endpoint =
> +							<&dsi_to_fimd>;
> +					};
> +				};
> +			};
>  		};
>  
>  		dsi_0: dsi@11C80000 {
> @@ -326,6 +339,19 @@
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					dsi_to_fimd: endpoint {
> +						remote-endpoint =
> +							<&fimd_to_dsi>;
> +					};
> +				};
> +			};
>  		};
>  
>  		sysmmu_fimd0: sysmmu@11E20000 {
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 497a947..773d392 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -193,6 +193,19 @@
>  		status = "disabled";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				dsi_to_fimd: endpoint {
> +					remote-endpoint =
> +						<&fimd_to_dsi>;
> +				};
> +			};
> +		};
>  	};
>  
>  	camera {
> @@ -715,6 +728,19 @@
>  		iommus = <&sysmmu_fimd0>;
>  		samsung,sysreg = <&sys_reg>;
>  		status = "disabled";
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				fimd_to_dsi: endpoint {
> +					remote-endpoint =
> +						<&dsi_to_fimd>;
> +				};
> +			};
> +		};
>  	};
>  
>  	tmu: tmu@100C0000 {
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
@ 2017-06-09  7:27     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2017-06-09  7:27 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
> It should be connected to OF graph between fimd and dsi.
> Add the OF graph between fimd and dsi.

I need more explanation why this is needed. What happens without this?
What issue is fixed here?

What about Exynos5250 and Exynos5420? I think we do not have a board in
mainline using FIMD but maybe this should be added just for correct
hardware description?


Best regards,
Krzysztof

> 
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>  arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
>  2 files changed, 52 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index 590ee44..22d523f 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -311,6 +311,19 @@
>  			iommus = <&sysmmu_fimd0>;
>  			samsung,sysreg = <&sys_reg>;
>  			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 0 {
> +					reg = <0>;
> +					fimd_to_dsi: endpoint {
> +						remote-endpoint =
> +							<&dsi_to_fimd>;
> +					};
> +				};
> +			};
>  		};
>  
>  		dsi_0: dsi at 11C80000 {
> @@ -326,6 +339,19 @@
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port at 0 {
> +					reg = <0>;
> +					dsi_to_fimd: endpoint {
> +						remote-endpoint =
> +							<&fimd_to_dsi>;
> +					};
> +				};
> +			};
>  		};
>  
>  		sysmmu_fimd0: sysmmu at 11E20000 {
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 497a947..773d392 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -193,6 +193,19 @@
>  		status = "disabled";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port at 0 {
> +				reg = <0>;
> +				dsi_to_fimd: endpoint {
> +					remote-endpoint =
> +						<&fimd_to_dsi>;
> +				};
> +			};
> +		};
>  	};
>  
>  	camera {
> @@ -715,6 +728,19 @@
>  		iommus = <&sysmmu_fimd0>;
>  		samsung,sysreg = <&sys_reg>;
>  		status = "disabled";
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port at 0 {
> +				reg = <0>;
> +				fimd_to_dsi: endpoint {
> +					remote-endpoint =
> +						<&dsi_to_fimd>;
> +				};
> +			};
> +		};
>  	};
>  
>  	tmu: tmu at 100C0000 {
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
  2017-06-09  7:27     ` Krzysztof Kozlowski
  (?)
@ 2017-06-09  8:26       ` Hoegeun Kwon
  -1 siblings, 0 replies; 8+ messages in thread
From: Hoegeun Kwon @ 2017-06-09  8:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, robh+dt,
	mark.rutland, catalin.marinas, will.deacon, javier, dri-devel,
	linux-arm-kernel, linux-samsung-soc, linux-kernel, devicetree,
	a.hajda

On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote:
> On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
>> It should be connected to OF graph between fimd and dsi.
>> Add the OF graph between fimd and dsi.
> I need more explanation why this is needed. What happens without this?
> What issue is fixed here?
>
> What about Exynos5250 and Exynos5420? I think we do not have a board in
> mainline using FIMD but maybe this should be added just for correct
> hardware description?

Thank you for your review.

I'm sorry, this patch is wrong.
Please ignore this patch. :)

Best regards,
Hoegeun

>
>
> Best regards,
> Krzysztof
>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
>>   arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
>>   2 files changed, 52 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
>> index 590ee44..22d523f 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -311,6 +311,19 @@
>>   			iommus = <&sysmmu_fimd0>;
>>   			samsung,sysreg = <&sys_reg>;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					fimd_to_dsi: endpoint {
>> +						remote-endpoint =
>> +							<&dsi_to_fimd>;
>> +					};
>> +				};
>> +			};
>>   		};
>>   
>>   		dsi_0: dsi@11C80000 {
>> @@ -326,6 +339,19 @@
>>   			#address-cells = <1>;
>>   			#size-cells = <0>;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					dsi_to_fimd: endpoint {
>> +						remote-endpoint =
>> +							<&fimd_to_dsi>;
>> +					};
>> +				};
>> +			};
>>   		};
>>   
>>   		sysmmu_fimd0: sysmmu@11E20000 {
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 497a947..773d392 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -193,6 +193,19 @@
>>   		status = "disabled";
>>   		#address-cells = <1>;
>>   		#size-cells = <0>;
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +				dsi_to_fimd: endpoint {
>> +					remote-endpoint =
>> +						<&fimd_to_dsi>;
>> +				};
>> +			};
>> +		};
>>   	};
>>   
>>   	camera {
>> @@ -715,6 +728,19 @@
>>   		iommus = <&sysmmu_fimd0>;
>>   		samsung,sysreg = <&sys_reg>;
>>   		status = "disabled";
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +				fimd_to_dsi: endpoint {
>> +					remote-endpoint =
>> +						<&dsi_to_fimd>;
>> +				};
>> +			};
>> +		};
>>   	};
>>   
>>   	tmu: tmu@100C0000 {
>> -- 
>> 1.9.1
>>
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
@ 2017-06-09  8:26       ` Hoegeun Kwon
  0 siblings, 0 replies; 8+ messages in thread
From: Hoegeun Kwon @ 2017-06-09  8:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: mark.rutland, devicetree, linux-samsung-soc, catalin.marinas,
	sw0312.kim, linux-kernel, robh+dt, javier, kgene, dri-devel,
	will.deacon, linux-arm-kernel

On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote:
> On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
>> It should be connected to OF graph between fimd and dsi.
>> Add the OF graph between fimd and dsi.
> I need more explanation why this is needed. What happens without this?
> What issue is fixed here?
>
> What about Exynos5250 and Exynos5420? I think we do not have a board in
> mainline using FIMD but maybe this should be added just for correct
> hardware description?

Thank you for your review.

I'm sorry, this patch is wrong.
Please ignore this patch. :)

Best regards,
Hoegeun

>
>
> Best regards,
> Krzysztof
>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
>>   arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
>>   2 files changed, 52 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
>> index 590ee44..22d523f 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -311,6 +311,19 @@
>>   			iommus = <&sysmmu_fimd0>;
>>   			samsung,sysreg = <&sys_reg>;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					fimd_to_dsi: endpoint {
>> +						remote-endpoint =
>> +							<&dsi_to_fimd>;
>> +					};
>> +				};
>> +			};
>>   		};
>>   
>>   		dsi_0: dsi@11C80000 {
>> @@ -326,6 +339,19 @@
>>   			#address-cells = <1>;
>>   			#size-cells = <0>;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +					dsi_to_fimd: endpoint {
>> +						remote-endpoint =
>> +							<&fimd_to_dsi>;
>> +					};
>> +				};
>> +			};
>>   		};
>>   
>>   		sysmmu_fimd0: sysmmu@11E20000 {
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 497a947..773d392 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -193,6 +193,19 @@
>>   		status = "disabled";
>>   		#address-cells = <1>;
>>   		#size-cells = <0>;
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +				dsi_to_fimd: endpoint {
>> +					remote-endpoint =
>> +						<&fimd_to_dsi>;
>> +				};
>> +			};
>> +		};
>>   	};
>>   
>>   	camera {
>> @@ -715,6 +728,19 @@
>>   		iommus = <&sysmmu_fimd0>;
>>   		samsung,sysreg = <&sys_reg>;
>>   		status = "disabled";
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +				fimd_to_dsi: endpoint {
>> +					remote-endpoint =
>> +						<&dsi_to_fimd>;
>> +				};
>> +			};
>> +		};
>>   	};
>>   
>>   	tmu: tmu@100C0000 {
>> -- 
>> 1.9.1
>>
>
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi
@ 2017-06-09  8:26       ` Hoegeun Kwon
  0 siblings, 0 replies; 8+ messages in thread
From: Hoegeun Kwon @ 2017-06-09  8:26 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote:
> On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
>> It should be connected to OF graph between fimd and dsi.
>> Add the OF graph between fimd and dsi.
> I need more explanation why this is needed. What happens without this?
> What issue is fixed here?
>
> What about Exynos5250 and Exynos5420? I think we do not have a board in
> mainline using FIMD but maybe this should be added just for correct
> hardware description?

Thank you for your review.

I'm sorry, this patch is wrong.
Please ignore this patch. :)

Best regards,
Hoegeun

>
>
> Best regards,
> Krzysztof
>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos3250.dtsi | 26 ++++++++++++++++++++++++++
>>   arch/arm/boot/dts/exynos4.dtsi    | 26 ++++++++++++++++++++++++++
>>   2 files changed, 52 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
>> index 590ee44..22d523f 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -311,6 +311,19 @@
>>   			iommus = <&sysmmu_fimd0>;
>>   			samsung,sysreg = <&sys_reg>;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port at 0 {
>> +					reg = <0>;
>> +					fimd_to_dsi: endpoint {
>> +						remote-endpoint =
>> +							<&dsi_to_fimd>;
>> +					};
>> +				};
>> +			};
>>   		};
>>   
>>   		dsi_0: dsi at 11C80000 {
>> @@ -326,6 +339,19 @@
>>   			#address-cells = <1>;
>>   			#size-cells = <0>;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port at 0 {
>> +					reg = <0>;
>> +					dsi_to_fimd: endpoint {
>> +						remote-endpoint =
>> +							<&fimd_to_dsi>;
>> +					};
>> +				};
>> +			};
>>   		};
>>   
>>   		sysmmu_fimd0: sysmmu at 11E20000 {
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 497a947..773d392 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -193,6 +193,19 @@
>>   		status = "disabled";
>>   		#address-cells = <1>;
>>   		#size-cells = <0>;
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port at 0 {
>> +				reg = <0>;
>> +				dsi_to_fimd: endpoint {
>> +					remote-endpoint =
>> +						<&fimd_to_dsi>;
>> +				};
>> +			};
>> +		};
>>   	};
>>   
>>   	camera {
>> @@ -715,6 +728,19 @@
>>   		iommus = <&sysmmu_fimd0>;
>>   		samsung,sysreg = <&sys_reg>;
>>   		status = "disabled";
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port at 0 {
>> +				reg = <0>;
>> +				fimd_to_dsi: endpoint {
>> +					remote-endpoint =
>> +						<&dsi_to_fimd>;
>> +				};
>> +			};
>> +		};
>>   	};
>>   
>>   	tmu: tmu at 100C0000 {
>> -- 
>> 1.9.1
>>
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-06-09  8:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20170609025951epcas1p19f5ca8c241b8b79068a84eb239ed46ed@epcas1p1.samsung.com>
2017-06-09  2:59 ` [PATCH] ARM: dts: exynos: Add the OF graph between fimd and dsi Hoegeun Kwon
2017-06-09  2:59   ` Hoegeun Kwon
2017-06-09  2:59   ` Hoegeun Kwon
2017-06-09  7:27   ` Krzysztof Kozlowski
2017-06-09  7:27     ` Krzysztof Kozlowski
2017-06-09  8:26     ` Hoegeun Kwon
2017-06-09  8:26       ` Hoegeun Kwon
2017-06-09  8:26       ` Hoegeun Kwon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.