* [PATCH] libahci: wrong comments in ahci_do_softreset()
@ 2017-06-11 14:53 Minwoo Im
2017-06-12 18:08 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Minwoo Im @ 2017-06-11 14:53 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, Minwoo Im
AHCI 1.3.1 Spec says that software shall build two H2D register
FISes in the command list to send a software reset.
The comments in ahci_do_softreset() is currently D2H instead of H2D.
Signed-off-by: Minwoo Im <dn3108@gmail.com>
---
drivers/ata/libahci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 3159f9e..835efe4 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1400,7 +1400,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class,
ata_tf_init(link->device, &tf);
- /* issue the first D2H Register FIS */
+ /* issue the first H2D Register FIS */
msecs = 0;
now = jiffies;
if (time_after(deadline, now))
@@ -1417,7 +1417,7 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class,
/* spec says at least 5us, but be generous and sleep for 1ms */
ata_msleep(ap, 1);
- /* issue the second D2H Register FIS */
+ /* issue the second H2D Register FIS */
tf.ctl &= ~ATA_SRST;
ahci_exec_polled_cmd(ap, pmp, &tf, 0, 0, 0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libahci: wrong comments in ahci_do_softreset()
2017-06-11 14:53 [PATCH] libahci: wrong comments in ahci_do_softreset() Minwoo Im
@ 2017-06-12 18:08 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2017-06-12 18:08 UTC (permalink / raw)
To: Minwoo Im; +Cc: linux-ide
On Sun, Jun 11, 2017 at 11:53:00PM +0900, Minwoo Im wrote:
> AHCI 1.3.1 Spec says that software shall build two H2D register
> FISes in the command list to send a software reset.
> The comments in ahci_do_softreset() is currently D2H instead of H2D.
>
> Signed-off-by: Minwoo Im <dn3108@gmail.com>
Applied to libata/for-4.13.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-12 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-11 14:53 [PATCH] libahci: wrong comments in ahci_do_softreset() Minwoo Im
2017-06-12 18:08 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.